You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by chenying99 <gi...@git.apache.org> on 2018/05/03 02:53:46 UTC

[GitHub] httpcomponents-client pull request #102: 4.5.x (org.apache.http.impl.client)...

GitHub user chenying99 opened a pull request:

    https://github.com/apache/httpcomponents-client/pull/102

    4.5.x (org.apache.http.impl.client)HttpRequestTaskCallable

                    metrics.getRequests().increment(started);
                    metrics.getTasks().increment(started);//这里应该是scheduled
                    metrics.getActiveConnections().decrementAndGet();
    
    line 106,  "started" should be "scheduled"? 
    yes or no?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/httpcomponents-client 4.5.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/httpcomponents-client/pull/102.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #102
    
----
commit 22b412f880b41651d4e8718f108d0c30b832b73a
Author: Oleg Kalnichevski <ol...@...>
Date:   2015-05-24T13:01:39Z

    HttpClient 4.5.x branch
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1681444 13f79535-47bb-0310-9956-ffa450edef68

commit 1fc51847e7ba824ef8d0616b9d16b2861a9978f9
Author: Oleg Kalnichevski <ol...@...>
Date:   2015-05-26T18:59:46Z

    HTTPCLIENT-1650: fluent Executor to create a local CredentialsProvide instance only if credentials are explicitly set
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1681815 13f79535-47bb-0310-9956-ffa450edef68

commit 0ad9857ed81747249f710c6519a638d3b0b6a5d0
Author: Oleg Kalnichevski <ol...@...>
Date:   2015-05-27T14:22:21Z

    Fixed regresson in a deprecated method of FileBody
    Contributed by Andrey Pohilko <apc4 at ya.ru>
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1682040 13f79535-47bb-0310-9956-ffa450edef68

commit ed396445436a0c30cd9e078e2cea1298ac595c6d
Author: Michael Osipov <mi...@...>
Date:   2015-05-28T13:47:24Z

    Fixed typo in exception message
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1682244 13f79535-47bb-0310-9956-ffa450edef68

commit 6cd90f89bef50517312e7d027ea6094821566480
Author: Michael Osipov <mi...@...>
Date:   2015-05-30T19:38:50Z

    HTTPCLIENT-1651: Add ability to disable content compression on a request basis
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1682646 13f79535-47bb-0310-9956-ffa450edef68

commit 8501cb9b0c029fb488a7701a11513ce789422105
Author: Michael Osipov <mi...@...>
Date:   2015-05-30T19:43:22Z

    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1682647 13f79535-47bb-0310-9956-ffa450edef68

commit 4ab8948dc527569aa9cac31f3deec9f3e1ba8f71
Author: Michael Osipov <mi...@...>
Date:   2015-05-30T19:45:10Z

    Unintentionally removed empty lines
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1682648 13f79535-47bb-0310-9956-ffa450edef68

commit eb4a62f60993db199f05932cfbc3f62034abb514
Author: Michael Osipov <mi...@...>
Date:   2015-05-30T20:11:17Z

    HTTPCLIENT-1654: Deprecate/remove RequestConfig#decompressionEnabled in favor of #contentCompressionEnabled
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1682650 13f79535-47bb-0310-9956-ffa450edef68

commit 2227d18696aa5a9ce3cb341ddbf8c5a5f735dc66
Author: Michael Osipov <mi...@...>
Date:   2015-05-30T20:27:58Z

    Added HTTPCLIENT-1654 to release notes
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1682652 13f79535-47bb-0310-9956-ffa450edef68

commit ea21ed26a76177bbf7ee4274de640ab579e13850
Author: Oleg Kalnichevski <ol...@...>
Date:   2015-05-31T10:46:03Z

    HTTPCLIENT-1654: better backward compatibility
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1682713 13f79535-47bb-0310-9956-ffa450edef68

commit 20e3f42df25aad30df097aa12d8b52ad10eeb3bc
Author: Oleg Kalnichevski <ol...@...>
Date:   2015-06-04T07:38:42Z

    Cache request line in HttpRequestWrapper
    Contributed by Dmitry Potapov <dpotapov at yandex-team.ru>
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1683475 13f79535-47bb-0310-9956-ffa450edef68

commit 12482402c405cf0ed38ea4d29f00a6ec9cbb2ea7
Author: Oleg Kalnichevski <ol...@...>
Date:   2015-06-04T08:41:39Z

    Upgraded HttpClient version to 4.5.1-SNAPSHOT
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1683489 13f79535-47bb-0310-9956-ffa450edef68

commit 78cf770aec88b6bfad9dfbdc12d8b92df2d84616
Author: Oleg Kalnichevski <ol...@...>
Date:   2015-06-05T09:17:41Z

    HTTPCLIENT-1655: HttpClient sends RST instead of FIN ACK sequence when using non-persistant connections
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1683684 13f79535-47bb-0310-9956-ffa450edef68

commit c6be20feb0a5e2a9c24fc68653b2e315b73f0f7c
Author: Oleg Kalnichevski <ol...@...>
Date:   2015-06-13T16:31:15Z

    HTTPCLIENT-1658: fixed regression in RequestBuilder#copy
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1685285 13f79535-47bb-0310-9956-ffa450edef68

commit 3b94921d03316330de1180b4bacb16ebf7eb99d0
Author: Oleg Kalnichevski <ol...@...>
Date:   2015-07-23T15:25:56Z

    HTTPCLIENT-1667: RequestBuilder does not take charset into account when creating UrlEncodedFormEntity
    Contributed by Sergey Smith <smithsv at bk.ru>
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1692404 13f79535-47bb-0310-9956-ffa450edef68

commit bd29207ff9db2e85e2bd8a97b2589cb247d96b89
Author: Oleg Kalnichevski <ol...@...>
Date:   2015-07-24T08:56:26Z

    HTTPCLIENT-1668: Fluent request incorrectly handles connect timeout setting
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1692467 13f79535-47bb-0310-9956-ffa450edef68

commit 369b375c3bbc71f7e84b10e9221be15269fb20ca
Author: Oleg Kalnichevski <ol...@...>
Date:   2015-08-07T07:33:11Z

    Use httpbin.org in examples
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1694618 13f79535-47bb-0310-9956-ffa450edef68

commit ab3bdf022910c1fbd2221d2c1d598f142dadd1d9
Author: Oleg Kalnichevski <ol...@...>
Date:   2015-08-07T07:40:08Z

    HTTPCLIENT-1674: fixed project url in pom.xml
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1694624 13f79535-47bb-0310-9956-ffa450edef68

commit dee78eca68ec4f6f907b7b0ac5ab93fec6fe880c
Author: Oleg Kalnichevski <ol...@...>
Date:   2015-08-07T18:51:38Z

    Removed unused import
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1694729 13f79535-47bb-0310-9956-ffa450edef68

commit 795a092dbd572f15b3f2d33203415e2b8bf9f2a9
Author: Michael Osipov <mi...@...>
Date:   2015-08-11T10:00:42Z

    Correct spelling of user 'principal' in the documentation
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1695238 13f79535-47bb-0310-9956-ffa450edef68

commit 18f9b7986b9965d2d7f29ad71f590eeef046fecb
Author: Oleg Kalnichevski <ol...@...>
Date:   2015-08-12T14:34:10Z

    HTTPCLIENT-1673: org.apache.http.entity.mime.content.* missing from OSGi exports
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1695536 13f79535-47bb-0310-9956-ffa450edef68

commit 7f66d5dc61651cd2f024901e5f9243d72fe361a4
Author: Oleg Kalnichevski <ol...@...>
Date:   2015-08-16T14:18:53Z

    HTTPCLIENT-1673: revert change, which was not necessary
    and add test that proves that it's not necessary.
    Mostly provide bones of future OSGi tests.
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1696142 13f79535-47bb-0310-9956-ffa450edef68

commit 2b3230123aa4a94652f50e8d3b8d93f2200545ac
Author: Oleg Kalnichevski <ol...@...>
Date:   2015-08-16T14:19:04Z

    HTTPCLIENT-1673: make the test case a bit more substantial.
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1696143 13f79535-47bb-0310-9956-ffa450edef68

commit 3ae055638f5993ae7c2c644865301e23cd34fb9f
Author: Michael Osipov <mi...@...>
Date:   2015-08-19T13:02:54Z

    HTTPCLIENT-1106: Use character arrays for passwords in Credentials objects, not Strings
    
    Deprecate constructors using String-based passwords
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1696576 13f79535-47bb-0310-9956-ffa450edef68

commit c0938e1f5592f77995c713c4897e87a596d9084d
Author: Oleg Kalnichevski <ol...@...>
Date:   2015-08-21T13:34:01Z

    Revert "HTTPCLIENT-1673: make the test case a bit more substantial."
    
    This reverts commit 2b3230123aa4a94652f50e8d3b8d93f2200545ac.
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1696971 13f79535-47bb-0310-9956-ffa450edef68

commit 80ff3b2e27a5a99ead75845f9d8151246605c13b
Author: Oleg Kalnichevski <ol...@...>
Date:   2015-08-21T13:35:04Z

    Revert "HTTPCLIENT-1673: revert change, which was not necessary"
    
    This reverts commit 7f66d5dc61651cd2f024901e5f9243d72fe361a4.
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1696973 13f79535-47bb-0310-9956-ffa450edef68

commit 6fd73b5fb52b44ef7670765a35d88cbf939b36a5
Author: Oleg Kalnichevski <ol...@...>
Date:   2015-08-30T16:34:38Z

    HTTPCLIENT-1680: redirect of a POST request causes ClientProtocolException
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1700136 13f79535-47bb-0310-9956-ffa450edef68

commit 8cf6df2c8ba7b6835116b783bfd05a0416d77b79
Author: Oleg Kalnichevski <ol...@...>
Date:   2015-09-04T13:47:05Z

    Log socket timeout values
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1701258 13f79535-47bb-0310-9956-ffa450edef68

commit abc894b3b86ab102371653993f65c51fb292a408
Author: Oleg Kalnichevski <ol...@...>
Date:   2015-09-09T16:52:37Z

    Upgraded HttpCore to version 4.4.3
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1702055 13f79535-47bb-0310-9956-ffa450edef68

commit 3b9a03913bcdb7a1c1be70135c4a5f0ccefc963d
Author: Oleg Kalnichevski <ol...@...>
Date:   2015-09-11T12:28:36Z

    Updated release notes for HttpClient 4.5.1 release
    
    git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1702444 13f79535-47bb-0310-9956-ffa450edef68

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] httpcomponents-client issue #102: 4.5.x (org.apache.http.impl.client)HttpReq...

Posted by perlun <gi...@git.apache.org>.
Github user perlun commented on the issue:

    https://github.com/apache/httpcomponents-client/pull/102
  
    @ok2c 
    
    > The right way to deal with the problem is to raise a JIRA with ASF Infra and kindly ask them to close the PR for us (and a few others).
    
    Makes sense. Feel free to do it, I'm just a (mostly) innocent bystander. :innocent: 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] httpcomponents-client issue #102: 4.5.x (org.apache.http.impl.client)HttpReq...

Posted by ok2c <gi...@git.apache.org>.
Github user ok2c commented on the issue:

    https://github.com/apache/httpcomponents-client/pull/102
  
    @perlun I seriously doubt he would care. The right way to deal with the problem is to raise a JIRA with ASF Infra and kindly ask them to close the PR for us (and a few others). 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] httpcomponents-client issue #102: 4.5.x (org.apache.http.impl.client)HttpReq...

Posted by ok2c <gi...@git.apache.org>.
Github user ok2c commented on the issue:

    https://github.com/apache/httpcomponents-client/pull/102
  
    @perlun Sadly, I cant. I have read only access to the project hosted at GitHub. Only select folks at ASF Infra can do that.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] httpcomponents-client issue #102: 4.5.x (org.apache.http.impl.client)HttpReq...

Posted by ok2c <gi...@git.apache.org>.
Github user ok2c commented on the issue:

    https://github.com/apache/httpcomponents-client/pull/102
  
    @chenying99 Please close this PR.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] httpcomponents-client issue #102: 4.5.x (org.apache.http.impl.client)HttpReq...

Posted by ok2c <gi...@git.apache.org>.
Github user ok2c commented on the issue:

    https://github.com/apache/httpcomponents-client/pull/102
  
    @chenying99 _please_ **close** this pull request! It drags in 181 unrelated commits. Please close this pull request or reduce the change-set just to those changes you are proposing.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] httpcomponents-client issue #102: 4.5.x (org.apache.http.impl.client)HttpReq...

Posted by perlun <gi...@git.apache.org>.
Github user perlun commented on the issue:

    https://github.com/apache/httpcomponents-client/pull/102
  
    @chenying99 seems to have left the building. @ok2c, could you just close it perhaps?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] httpcomponents-client issue #102: 4.5.x (org.apache.http.impl.client)HttpReq...

Posted by perlun <gi...@git.apache.org>.
Github user perlun commented on the issue:

    https://github.com/apache/httpcomponents-client/pull/102
  
    @ok2c 
    
    > @perlun Sadly, I cant. I have read only access to the project hosted at GitHub. Only select folks at ASF Infra can do that.
    
    I see. Maybe @sebbASF has access or know someone who has?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org