[GitHub] [shardingsphere] sandynz commented on issue #14661: [DistSQL] Add some new syntax to manage scaling configurations.

[GitBox <gi...@apache.org>]

sandynz commented on issue #14661:
URL: https://github.com/apache/shardingsphere/issues/14661#issuecomment-1011790808


   The design and implementation cost a short time, since scaling require DistSQL in `5.1.0` release recently. Thank you very much! @RaigorJiang 
   
   I've tested all the `CREATE` examples above, every one of them works. I just did more test now, and I found some situation:
   
   1. Looks there're strict constraints.
   
   Empty scaling configuration is allowed, it means `INPUT`, `OUTPUT`, `STREAM_CHANNEL`, `COMPLETION_DETECTOR` and `DATA_CONSISTENCY_CHECKER` are optional.
   
   Seems they're not optional for now, in `minimal automatic process`, `complete automatic process` and `manual process`.
   When any of them are not configured, it show error message. e.g.
   
   ```
   mysql> CREATE SHARDING SCALING scaling_name1(
       -> COMPLETION_DETECTOR(TYPE(NAME=IDLE, PROPERTIES("incremental-task-idle-minute-threshold"=30)))
       -> );
   ERROR 1235 (42000): This version of ShardingSphere-Proxy doesn't yet support this SQL. 'You have an error in your SQL syntax'
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org