You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Adrien Grand (JIRA)" <ji...@apache.org> on 2012/09/25 19:10:07 UTC
[jira] [Created] (LUCENE-4426) New ValueSource implementations that
wrap DocValues
Adrien Grand created LUCENE-4426:
------------------------------------
Summary: New ValueSource implementations that wrap DocValues
Key: LUCENE-4426
URL: https://issues.apache.org/jira/browse/LUCENE-4426
Project: Lucene - Core
Issue Type: New Feature
Components: modules/other
Reporter: Adrien Grand
Assignee: Adrien Grand
Priority: Minor
Fix For: 4.1, 5.0
We should have ValueSource implementations that wrap DocValues in lucene-queries so that DocValues can be used in function queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4426) New ValueSource implementations
that wrap DocValues
Posted by "Adrien Grand (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463038#comment-13463038 ]
Adrien Grand commented on LUCENE-4426:
--------------------------------------
bq. How does this relate to NumericIndexDocValueSource?
I didn't know about this class! Maybe the new classes of my patch could replace this one:
* the objectVal method returns an object whose type matches the ValueSource name,
* there is the StrDocValuesFieldSource to deal with DocValues.Type.BYTES* when they are UTF8-encoded Strings
* they use a default source when the segment has no DocValues
* they give the ability to load direct sources
(My goal is to reuse them in SOLR-3855)
bq. I am confused why the current one only handles 3 types?
Right. Strange that it is able to deal with VAR_INTS but none of FIXED_INTS_*.
> New ValueSource implementations that wrap DocValues
> ---------------------------------------------------
>
> Key: LUCENE-4426
> URL: https://issues.apache.org/jira/browse/LUCENE-4426
> Project: Lucene - Core
> Issue Type: New Feature
> Components: modules/other
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Fix For: 4.1, 5.0
>
> Attachments: LUCENE-4426.patch
>
>
> We should have ValueSource implementations that wrap DocValues in lucene-queries so that DocValues can be used in function queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-4426) New ValueSource implementations
that wrap DocValues
Posted by "Adrien Grand (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrien Grand resolved LUCENE-4426.
----------------------------------
Resolution: Fixed
Committed (r1394513 on trunk and r1394529 on the 4.x branch).
> New ValueSource implementations that wrap DocValues
> ---------------------------------------------------
>
> Key: LUCENE-4426
> URL: https://issues.apache.org/jira/browse/LUCENE-4426
> Project: Lucene - Core
> Issue Type: New Feature
> Components: modules/other
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Fix For: 4.1, 5.0
>
> Attachments: LUCENE-4426.patch, LUCENE-4426.patch, LUCENE-4426.patch
>
>
> We should have ValueSource implementations that wrap DocValues in lucene-queries so that DocValues can be used in function queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4426) New ValueSource implementations that
wrap DocValues
Posted by "Adrien Grand (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrien Grand updated LUCENE-4426:
---------------------------------
Attachment: LUCENE-4426.patch
Right, it makes sense to have all numeric types in the same class. Here is a new patch that also adds FIXED_INTS_* support to {{NumericIndexDocValueSource}} and adds a deprecation notice.
> New ValueSource implementations that wrap DocValues
> ---------------------------------------------------
>
> Key: LUCENE-4426
> URL: https://issues.apache.org/jira/browse/LUCENE-4426
> Project: Lucene - Core
> Issue Type: New Feature
> Components: modules/other
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Fix For: 4.1, 5.0
>
> Attachments: LUCENE-4426.patch, LUCENE-4426.patch
>
>
> We should have ValueSource implementations that wrap DocValues in lucene-queries so that DocValues can be used in function queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4426) New ValueSource implementations
that wrap DocValues
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463016#comment-13463016 ]
Robert Muir commented on LUCENE-4426:
-------------------------------------
How does this relate to NumericIndexDocValueSource?
I am confused why the current one only handles 3 types?
> New ValueSource implementations that wrap DocValues
> ---------------------------------------------------
>
> Key: LUCENE-4426
> URL: https://issues.apache.org/jira/browse/LUCENE-4426
> Project: Lucene - Core
> Issue Type: New Feature
> Components: modules/other
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Fix For: 4.1, 5.0
>
> Attachments: LUCENE-4426.patch
>
>
> We should have ValueSource implementations that wrap DocValues in lucene-queries so that DocValues can be used in function queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4426) New ValueSource implementations that
wrap DocValues
Posted by "Adrien Grand (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrien Grand updated LUCENE-4426:
---------------------------------
Attachment: LUCENE-4426.patch
New patch :
- added optimisation when SortedSource.hasPackedDocToOrd() is true,
- a few more tests.
> New ValueSource implementations that wrap DocValues
> ---------------------------------------------------
>
> Key: LUCENE-4426
> URL: https://issues.apache.org/jira/browse/LUCENE-4426
> Project: Lucene - Core
> Issue Type: New Feature
> Components: modules/other
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Fix For: 4.1, 5.0
>
> Attachments: LUCENE-4426.patch, LUCENE-4426.patch, LUCENE-4426.patch
>
>
> We should have ValueSource implementations that wrap DocValues in lucene-queries so that DocValues can be used in function queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4426) New ValueSource implementations
that wrap DocValues
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463060#comment-13463060 ]
Robert Muir commented on LUCENE-4426:
-------------------------------------
I think the previous patch was done before additional fixed types were added.
We could always deprecate the old one (probably should deprecate AND fix it if we do that).
Your patch is better (e.g. checks hasArray, etc) from the implementation side.
The only thing i dont get is if maybe it really should just be one class like the old one.
I dont know why we need Int/Float versions of the classes when these implementations have
things like intVal()/floatVal()/doubleVal()...
> New ValueSource implementations that wrap DocValues
> ---------------------------------------------------
>
> Key: LUCENE-4426
> URL: https://issues.apache.org/jira/browse/LUCENE-4426
> Project: Lucene - Core
> Issue Type: New Feature
> Components: modules/other
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Fix For: 4.1, 5.0
>
> Attachments: LUCENE-4426.patch
>
>
> We should have ValueSource implementations that wrap DocValues in lucene-queries so that DocValues can be used in function queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4426) New ValueSource implementations that
wrap DocValues
Posted by "Adrien Grand (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrien Grand updated LUCENE-4426:
---------------------------------
Attachment: LUCENE-4426.patch
This patch adds {{ValueSource}} implementations for ints, longs, floats, doubles, dates and UTF8-encoded Strings.
> New ValueSource implementations that wrap DocValues
> ---------------------------------------------------
>
> Key: LUCENE-4426
> URL: https://issues.apache.org/jira/browse/LUCENE-4426
> Project: Lucene - Core
> Issue Type: New Feature
> Components: modules/other
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Fix For: 4.1, 5.0
>
> Attachments: LUCENE-4426.patch
>
>
> We should have ValueSource implementations that wrap DocValues in lucene-queries so that DocValues can be used in function queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org