[jira] [Commented] (KAFKA-2570) New consumer should commit before every rebalance when auto-commit is enabled

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933950#comment-14933950 ] 

ASF GitHub Bot commented on KAFKA-2570:
---------------------------------------

GitHub user hachikuji opened a pull request:

    https://github.com/apache/kafka/pull/257

    KAFKA-2570: commit offsets on rebalance/close when auto-commit is enabled

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hachikuji/kafka KAFKA-2570

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/257.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #257
    
----
commit b11b0cc93652f0ef9af492eeb2e99873737306ee
Author: Jason Gustafson <ja...@confluent.io>
Date:   2015-09-23T22:30:10Z

    KAFKA-2570; commit offsets on rebalance/close when auto-commit is enabled

----


> New consumer should commit before every rebalance when auto-commit is enabled
> -----------------------------------------------------------------------------
>
>                 Key: KAFKA-2570
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2570
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Jason Gustafson
>            Assignee: Jason Gustafson
>             Fix For: 0.9.0.0
>
>
> If not, then the consumer may see duplicates even on normal rebalances, since we will always reset to the previous commit after rebalancing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)