[GitHub] [lucene-solr] pcsanwald commented on issue #966: LUCENE-9024 Optimize IntroSelector to use median of medians

[GitBox <gi...@apache.org>]

pcsanwald commented on issue #966: LUCENE-9024 Optimize IntroSelector to use median of medians
URL: https://github.com/apache/lucene-solr/pull/966#issuecomment-546330004
 
 
   @jpountz thanks for the detailed review! I will be addressing your comments today. One comment:
   
   > it should be `to+random.nextInt(5)`, is it what you are proposing?
   
   That's part of it. but even with a right parameter of `to+0`, the code is never exercised over the whole array, as it's exclusive. So, I am not 100% sure I am right, but, it seems to me that there is no way to quickSelect on an entire array, as `to = arr.len` is still exclusive. I guess this has not been a problem in practice, but, I wanted to raise it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org