You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@cocoon.apache.org by jo...@apache.org on 2004/01/15 01:21:26 UTC
cvs commit: cocoon-2.1/src/blocks/woody/samples/forms form2_bind_xml.xml
joerg 2004/01/14 16:21:26
Modified: src/blocks/woody/samples/forms form2_bind_xml.xml
Log:
fixes problem with binding sample:
http://marc.theaimsgroup.com/?t=107411789000009&r=1&w=2
Can somebody explain why?
Revision Changes Path
1.7 +1 -1 cocoon-2.1/src/blocks/woody/samples/forms/form2_bind_xml.xml
Index: form2_bind_xml.xml
===================================================================
RCS file: /home/cvs/cocoon-2.1/src/blocks/woody/samples/forms/form2_bind_xml.xml,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- form2_bind_xml.xml 18 Dec 2003 07:43:16 -0000 1.6
+++ form2_bind_xml.xml 15 Jan 2004 00:21:26 -0000 1.7
@@ -18,7 +18,7 @@
<!-- for non-string datatypes, a convertor must be specified. These are
the same convertors as can be used in form definitions, but require an
extra datatype attribute. Here we use the default convertor for longs. -->
- <wd:convertor datatype="long"/>
+ <wd:convertor datatype="integer"/>
</wb:value>
<wb:value id="choose" path="choose/@value">
Re: cvs commit: cocoon-2.1/src/blocks/woody/samples/forms form2_bind_xml.xml
Posted by Tony Collen <co...@umn.edu>.
Joerg Heinicke wrote:
> On 15.01.2004 13:32, Marc Portier wrote:
>
>>> When searching for the reason of the non-working I looked at
>>> form2_xml.xml, line 95:
>>>
>>> <wd:repeater id="contacts">
>>> <wd:widgets>
>>> <wd:output id="id">
>>> <wd:datatype base="long"/>
>>> </wd:output>
>>>
>>> and that's long and I didn't understand why it did not work but
>>> after the change in form_bind_xml.xml. Comparing 2 strings like
>>> contacts and number can be so difficult :) Yes, now I also
>>> understand the reason.
>>>
>>
>> yeah, well, I don't know if it is intended or not, but I do hear the
>> underlaying message: we need some better tools for this kind of
>> stuff, no?
>
>
> NO! There was really no intention. Just a "I must have been blind!"
>
Yeah, but I still think we could use some tools for simplifying it all.
Imagine an eclipse plugin that could automagically generate basic forms
and binding based on a bean you fed it.
/me wonders if s&n is listening ;)
> Joerg
>
Tony
Re: cvs commit: cocoon-2.1/src/blocks/woody/samples/forms form2_bind_xml.xml
Posted by Joerg Heinicke <jo...@gmx.de>.
On 15.01.2004 13:32, Marc Portier wrote:
>> When searching for the reason of the non-working I looked at
>> form2_xml.xml, line 95:
>>
>> <wd:repeater id="contacts">
>> <wd:widgets>
>> <wd:output id="id">
>> <wd:datatype base="long"/>
>> </wd:output>
>>
>> and that's long and I didn't understand why it did not work but after
>> the change in form_bind_xml.xml. Comparing 2 strings like contacts and
>> number can be so difficult :) Yes, now I also understand the reason.
>>
>
> yeah, well, I don't know if it is intended or not, but I do hear the
> underlaying message: we need some better tools for this kind of stuff, no?
NO! There was really no intention. Just a "I must have been blind!"
Joerg
Re: cvs commit: cocoon-2.1/src/blocks/woody/samples/forms form2_bind_xml.xml
Posted by Marc Portier <mp...@outerthought.org>.
Joerg Heinicke wrote:
> On 15.01.2004 09:46, Marc Portier wrote:
>
>>> Modified: src/blocks/woody/samples/forms form2_bind_xml.xml
>>> Log:
>>> fixes problem with binding sample:
>>> http://marc.theaimsgroup.com/?t=107411789000009&r=1&w=2
>>> Can somebody explain why?
>>
>>
>> sorry my mistake:
>> http://cvs.apache.org/viewcvs.cgi/cocoon-2.1/src/blocks/woody/samples/forms/form2_model.xml?r1=1.11&r2=1.12&diff_format=h
>>
>>
>> when I recently changed the sample to fix the problem with the
>> bean-binding I overlooked the effect on the xml-binding...
>
>
> When searching for the reason of the non-working I looked at
> form2_xml.xml, line 95:
>
> <wd:repeater id="contacts">
> <wd:widgets>
> <wd:output id="id">
> <wd:datatype base="long"/>
> </wd:output>
>
> and that's long and I didn't understand why it did not work but after
> the change in form_bind_xml.xml. Comparing 2 strings like contacts and
> number can be so difficult :) Yes, now I also understand the reason.
>
yeah, well, I don't know if it is intended or not, but I do hear the
underlaying message: we need some better tools for this kind of stuff, no?
maybe on relative short term some 'validator' could be made that checks
if id's and datatypes are in sync between woody definition, binding and
template files? That could give upfront some more in depth warnings
then the runtime environment allows...
in any case, it's just an idea, not a promise I'll start making that :-)
regards,
-marc=
--
Marc Portier http://outerthought.org/
Outerthought - Open Source, Java & XML Competence Support Center
Read my weblog at http://blogs.cocoondev.org/mpo/
mpo@outerthought.org mpo@apache.org
Re: cvs commit: cocoon-2.1/src/blocks/woody/samples/forms form2_bind_xml.xml
Posted by Joerg Heinicke <jo...@gmx.de>.
On 15.01.2004 09:46, Marc Portier wrote:
>> Modified: src/blocks/woody/samples/forms form2_bind_xml.xml
>> Log:
>> fixes problem with binding sample:
>> http://marc.theaimsgroup.com/?t=107411789000009&r=1&w=2
>> Can somebody explain why?
>
> sorry my mistake:
> http://cvs.apache.org/viewcvs.cgi/cocoon-2.1/src/blocks/woody/samples/forms/form2_model.xml?r1=1.11&r2=1.12&diff_format=h
>
>
> when I recently changed the sample to fix the problem with the
> bean-binding I overlooked the effect on the xml-binding...
When searching for the reason of the non-working I looked at
form2_xml.xml, line 95:
<wd:repeater id="contacts">
<wd:widgets>
<wd:output id="id">
<wd:datatype base="long"/>
</wd:output>
and that's long and I didn't understand why it did not work but after
the change in form_bind_xml.xml. Comparing 2 strings like contacts and
number can be so difficult :) Yes, now I also understand the reason.
Joerg
Re: cvs commit: cocoon-2.1/src/blocks/woody/samples/forms form2_bind_xml.xml
Posted by Marc Portier <mp...@outerthought.org>.
joerg@apache.org wrote:
> joerg 2004/01/14 16:21:26
>
> Modified: src/blocks/woody/samples/forms form2_bind_xml.xml
> Log:
> fixes problem with binding sample:
> http://marc.theaimsgroup.com/?t=107411789000009&r=1&w=2
> Can somebody explain why?
>
sorry my mistake:
http://cvs.apache.org/viewcvs.cgi/cocoon-2.1/src/blocks/woody/samples/forms/form2_model.xml?r1=1.11&r2=1.12&diff_format=h
when I recently changed the sample to fix the problem with the
bean-binding I overlooked the effect on the xml-binding...
thx for fixing,
regards
-marc=
> Revision Changes Path
> 1.7 +1 -1 cocoon-2.1/src/blocks/woody/samples/forms/form2_bind_xml.xml
>
> Index: form2_bind_xml.xml
> ===================================================================
> RCS file: /home/cvs/cocoon-2.1/src/blocks/woody/samples/forms/form2_bind_xml.xml,v
> retrieving revision 1.6
> retrieving revision 1.7
> diff -u -r1.6 -r1.7
> --- form2_bind_xml.xml 18 Dec 2003 07:43:16 -0000 1.6
> +++ form2_bind_xml.xml 15 Jan 2004 00:21:26 -0000 1.7
> @@ -18,7 +18,7 @@
> <!-- for non-string datatypes, a convertor must be specified. These are
> the same convertors as can be used in form definitions, but require an
> extra datatype attribute. Here we use the default convertor for longs. -->
> - <wd:convertor datatype="long"/>
> + <wd:convertor datatype="integer"/>
> </wb:value>
>
> <wb:value id="choose" path="choose/@value">
>
>
>
--
Marc Portier http://outerthought.org/
Outerthought - Open Source, Java & XML Competence Support Center
Read my weblog at http://blogs.cocoondev.org/mpo/
mpo@outerthought.org mpo@apache.org