You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by gi...@apache.org on 2013/12/31 07:35:49 UTC

git commit: updated refs/heads/4.3 to 3b3adbf

Updated Branches:
  refs/heads/4.3 57cb023eb -> 3b3adbf71


CLOUDSTACK-5637: Detach volume before migrating


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/3b3adbf7
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/3b3adbf7
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/3b3adbf7

Branch: refs/heads/4.3
Commit: 3b3adbf71268fea526e91a94e7d64fe511daf840
Parents: 57cb023
Author: Girish Shilamkar <gi...@clogeny.com>
Authored: Tue Dec 31 11:34:16 2013 +0530
Committer: Girish Shilamkar <gi...@clogeny.com>
Committed: Mon Dec 30 18:47:52 2013 -0500

----------------------------------------------------------------------
 test/integration/component/test_stopped_vm.py | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/3b3adbf7/test/integration/component/test_stopped_vm.py
----------------------------------------------------------------------
diff --git a/test/integration/component/test_stopped_vm.py b/test/integration/component/test_stopped_vm.py
index e700c46..e8a90b7 100644
--- a/test/integration/component/test_stopped_vm.py
+++ b/test/integration/component/test_stopped_vm.py
@@ -891,6 +891,8 @@ class TestDeployVM(cloudstackTestCase):
                             "Running",
                             "VM should be in Running state after deployment"
                         )
+        
+                
         self.debug("Stopping instance: %s" % self.virtual_machine.name)
         self.virtual_machine.stop(self.apiclient)
         self.debug("Instance is stopped!")
@@ -939,6 +941,11 @@ class TestDeployVM(cloudstackTestCase):
                 self.storage_id = spool.id
                 self.storage_name = spool.name
                 break
+        
+        self.debug("Detaching volume %s from vm %s" % (vol_response.id, self.virtual_machine.id))
+
+        self.virtual_machine.detach_volume(self.apiclient, vol_response)
+        
         self.debug("Migrating volume to storage pool: %s" % self.storage_name)
         Volume.migrate(
                        self.apiclient,
@@ -947,14 +954,14 @@ class TestDeployVM(cloudstackTestCase):
                        )
         volume = Volume.list(
                               self.apiclient,
-                              virtualmachineid=self.virtual_machine.id,
-                              type='ROOT',
-                              listall=True
+                              virtualmachineid=self.virtual_machine.id,                      
+                              type="ROOT",
+                              listall=True,
                               )
         self.assertEqual(
                          volume[0].storage,
                          self.storage_name,
-                         "Check volume migration response")
+                         "Check volume migration response vol.storage %s self.storage_name %s" % (volume[0].storage, self.storage_name))
         
         return