You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/03/17 17:56:45 UTC
[GitHub] [helix] alirezazamani opened a new pull request #900: Fix the
targeted task reassignment
alirezazamani opened a new pull request #900: Fix the targeted task reassignment
URL: https://github.com/apache/helix/pull/900
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR title:
Fixes #461 .
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
This commit specifically targets the scenario where task is running on an instance and suddenly the targeted partition moves to a new instance. There has been cases where mastership happens for specific partition and controller keeps assigning and dropping the task to the wrong instance.
This commit fixes this scenario by checking if target partition is existed on the instance.
Test has been added accordingly.
### Tests
- [x] The following tests are written for this issue:
TestTargetedTaskParticipantDisconnect
- [x] The following is the result of the "mvn test" command on the appropriate module:
Test Result 1: mvn test
Failed tests:
org.apache.helix.integration.rebalancer.CrushRebalancers.TestCrushAutoRebalanceNonRack.testLackEnoughInstances(org.apache.helix.integration.rebalancer.CrushRebalancers.TestCrushAutoRebalanceNonRack)
Run 1: PASS
Run 2: TestCrushAutoRebalanceNonRack.testLackEnoughInstances:250 ยป ZkClient Failed to...
TestHelixTaskExecutor.testNoRetry:661 expected:<4> but was:<2>
Tests run: 1091, Failures: 2, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:13 h
[INFO] Finished at: 2020-03-17T10:16:46-07:00
[INFO] ------------------------------------------------------------------------
mvn test -Dtest="TestCrushAutoRebalanceNonRack,TestHelixTaskExecutor"
Tests run: 20, Failures: 0, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:47 min
[INFO] Finished at: 2020-03-17T10:50:03-07:00
[INFO] ------------------------------------------------------------------------
### Commits
- [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- [x] My diff has been formatted using helix-style.xml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] alirezazamani closed pull request #900: Fix the targeted
task reassignment
Posted by GitBox <gi...@apache.org>.
alirezazamani closed pull request #900: Fix the targeted task reassignment
URL: https://github.com/apache/helix/pull/900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] alirezazamani commented on issue #900: Fix the targeted
task reassignment
Posted by GitBox <gi...@apache.org>.
alirezazamani commented on issue #900: Fix the targeted task reassignment
URL: https://github.com/apache/helix/pull/900#issuecomment-600245156
Since we will move to current state in future completely, I will close the ticket for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org