You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/12/15 10:30:52 UTC
[GitHub] [incubator-uniffle] xianjingfeng commented on a diff in pull request #428: [Bug] Fix potential negative preAllocatedSize variable
xianjingfeng commented on code in PR #428:
URL: https://github.com/apache/incubator-uniffle/pull/428#discussion_r1049472012
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerGrpcService.java:
##########
@@ -256,6 +251,9 @@ public void sendShuffleData(SendShuffleDataRequest req,
break;
}
}
+ // since the required buffer id is only used once, the shuffle client would try to require another buffer.
+ // we should remove this require buffer whether the cache shuffle data succeeded or not
+ manager.removeRequireBufferId(requireBufferId);
Review Comment:
We can't remove it after all blocks cached.
https://github.com/apache/incubator-uniffle/blob/c8f8292ce03d4a0f481759d79e404a3324869612/server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java#L497-L514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org