[jira] [Comment Edited] (ARIA-174) Refactor instantiation phase

["Tal Liron (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARIA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100320#comment-16100320 ] 

Tal Liron edited comment on ARIA-174 at 7/25/17 4:43 PM:
---------------------------------------------------------

As reported by Vaishnavi K. R., we currently have a regression in matching reqs-and-caps whereby requirements are not matched unless a node is specified. Rather than creating a new issue and then refactoring it for this JIRA, I suggest solving it as part of the refactor.

Here is a test case:

{code}
tosca_definitions_version: tosca_simple_yaml_1_0

capability_types:
  Socket:
    derived_from: tosca.capabilities.Root

node_types:
  Socket:
    derived_from: tosca.nodes.Root
    capabilities:
      socket: Socket

  Plug:
    derived_from: tosca.nodes.Root
    requirements:
      - plug: 
          capability: Socket
#          node: Socket

topology_template:
  node_templates:
    socket:
      type: Socket

    plug:
      type: Plug
{code}

Note the commented-out line: if you uncomment it, the service will instantiate correctly. However, it *should* work even without that line.


was (Author: emblemparade):
As reported by Vaishnavi K. R., we currently have a regression in matching reqs-and-caps whereby requirements are not matched unless a node is specified. Rather than creating a new issue and then refactoring it for this JIRA, I suggest solving it as part of the refactor.

Here is an test case:

{code}
tosca_definitions_version: tosca_simple_yaml_1_0

capability_types:
  Socket:
    derived_from: tosca.capabilities.Root

node_types:
  Socket:
    derived_from: tosca.nodes.Root
    capabilities:
      socket: Socket

  Plug:
    derived_from: tosca.nodes.Root
    requirements:
      - plug: 
          capability: Socket
#          node: Socket

topology_template:
  node_templates:
    socket:
      type: Socket

    plug:
      type: Plug
{code}

Note the commented-out line: if you uncomment it, the service will instantiate correctly. However, it *should* work even without that line.

> Refactor instantiation phase
> ----------------------------
>
>                 Key: ARIA-174
>                 URL: https://issues.apache.org/jira/browse/ARIA-174
>             Project: AriaTosca
>          Issue Type: Task
>            Reporter: Ran Ziv
>            Assignee: Maxim Orlov
>
> The code for instantiation phase currently resides inside the models themselves ({{instantiate}}, {{coerce}}, {{validate}}, {{dump}} methods)
> It needs to be refactored to a separate module/package.
> The {{dump}} methods should not output to {{stdout}} directly, and their output should take the CLI configuration into consideration.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)