You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Xuefu Zhang <xz...@cloudera.com> on 2013/10/31 06:43:46 UTC
Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF
implementations
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15113/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVe-5356
https://issues.apache.org/jira/browse/HIVe-5356
Repository: hive-git
Description
-------
Replace plus, minus, and so on 6 old UDFs with generic UDF implementations.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 898b6a5
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 120095a
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java 1e74fce
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java da01934
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java 0996231
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0942ac3
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 07c1957
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java cfe7b2b
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 0da7eae
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java 4aeb4e6
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 90ab983
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java 4c2e722
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java 2a301bc
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java PRE-CREATION
Diff: https://reviews.apache.org/r/15113/diff/
Testing
-------
Full set of unit tests is to be run. Old testcases are also migrated.
Thanks,
Xuefu Zhang
Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF
implementations
Posted by Jason Dere <jd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15113/#review28201
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java
<https://reviews.apache.org/r/15113/#comment54882>
Rather than creating getNumericTypePriority(), can you use FunctionRegistry.getCommonType(), which already uses the same logic for numeric types? I think it would be better not to publicly expose the implementation details about numericTypePriority and how numeric types are resolved.
- Jason Dere
On Nov. 3, 2013, 7:26 p.m., Xuefu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15113/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2013, 7:26 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVe-5356
> https://issues.apache.org/jira/browse/HIVe-5356
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Replace plus, minus, and so on 6 old UDFs with generic UDF implementations.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 898b6a5
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java dd8d7dd
> ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 47d7995
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java 1e74fce
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java da01934
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java 0996231
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0942ac3
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 07c1957
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java cfe7b2b
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 0da7eae
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java 4aeb4e6
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 1e49a2e
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java 4c2e722
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java 2a301bc
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMinus.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPlus.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java PRE-CREATION
> ql/src/test/queries/clientpositive/ctas_hadoop20.q 4961b97
> ql/src/test/results/clientpositive/ctas_hadoop20.q.out 885e985
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java 22e5ec5
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java c19f5aa
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantByteObjectInspector.java 0915562
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveDecimalObjectInspector.java a9ca7bd
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantIntObjectInspector.java 942a178
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantLongObjectInspector.java ad3a063
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantShortObjectInspector.java 6b67dac
> serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java 420509c
>
> Diff: https://reviews.apache.org/r/15113/diff/
>
>
> Testing
> -------
>
> Full set of unit tests is to be run. Old testcases are also migrated.
>
>
> Thanks,
>
> Xuefu Zhang
>
>
Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF
implementations
Posted by Jason Dere <jd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15113/#review28128
-----------------------------------------------------------
Couple of minor comments.
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java
<https://reviews.apache.org/r/15113/#comment54719>
Just a nit, but maybe consider throwing exception here rather than returning null? I don't think these base implementations are meant to be used, so maybe better bring this to user/dev attention by raising exception.
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java
<https://reviews.apache.org/r/15113/#comment54713>
This comment is no longer true, since double has been changed to return precision 15.
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java
<https://reviews.apache.org/r/15113/#comment54714>
Same as previous comment.
- Jason Dere
On Nov. 3, 2013, 7:26 p.m., Xuefu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15113/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2013, 7:26 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVe-5356
> https://issues.apache.org/jira/browse/HIVe-5356
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Replace plus, minus, and so on 6 old UDFs with generic UDF implementations.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 898b6a5
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java dd8d7dd
> ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 47d7995
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java 1e74fce
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java da01934
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java 0996231
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0942ac3
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 07c1957
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java cfe7b2b
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 0da7eae
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java 4aeb4e6
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 1e49a2e
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java 4c2e722
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java 2a301bc
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMinus.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPlus.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java PRE-CREATION
> ql/src/test/queries/clientpositive/ctas_hadoop20.q 4961b97
> ql/src/test/results/clientpositive/ctas_hadoop20.q.out 885e985
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java 22e5ec5
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java c19f5aa
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantByteObjectInspector.java 0915562
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveDecimalObjectInspector.java a9ca7bd
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantIntObjectInspector.java 942a178
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantLongObjectInspector.java ad3a063
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantShortObjectInspector.java 6b67dac
> serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java 420509c
>
> Diff: https://reviews.apache.org/r/15113/diff/
>
>
> Testing
> -------
>
> Full set of unit tests is to be run. Old testcases are also migrated.
>
>
> Thanks,
>
> Xuefu Zhang
>
>
Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF
implementations
Posted by Xuefu Zhang <xz...@cloudera.com>.
> On Nov. 15, 2013, 6:13 p.m., Brock Noland wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java, line 65
> > <https://reviews.apache.org/r/15113/diff/9/?file=384876#file384876line65>
> >
> > I assume these aren't final due to serialization. If so, it might be worth a comment indicating so.
Actually this was copied from its non-UDF counterpart. It can be finaly, but personally I don't think it's a big dea.
> On Nov. 15, 2013, 6:13 p.m., Brock Noland wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java, line 148
> > <https://reviews.apache.org/r/15113/diff/9/?file=384876#file384876line148>
> >
> > It looks like all these methods are going to be overridden by each sub-class? If that is true then they should be abstract with no body.
Actually, GenericUDFOPDivide only overrides two of them.
> On Nov. 15, 2013, 6:13 p.m., Brock Noland wrote:
> > serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java, line 76
> > <https://reviews.apache.org/r/15113/diff/9/?file=384935#file384935line76>
> >
> > Should these be constants in common or some shared location so jdbc and serde would share the same value?
Created followup JIRA HIVE-5838.
- Xuefu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15113/#review28976
-----------------------------------------------------------
On Nov. 14, 2013, 10:11 p.m., Xuefu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15113/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2013, 10:11 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVe-5356
> https://issues.apache.org/jira/browse/HIVe-5356
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Replace plus, minus, and so on 6 old UDFs with generic UDF implementations.
>
>
> Diffs
> -----
>
> common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java e3a1620
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 5eb321c
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 7c1ab0d
> ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 7838547
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java 1e74fce
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java b892b84
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java 0996231
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0942ac3
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 07c1957
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java cfe7b2b
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 0da7eae
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java 4aeb4e6
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 3f3e67f
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPDivide.java 659d65f
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java 4c2e722
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java 2a301bc
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMinus.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPlus.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java PRE-CREATION
> ql/src/test/results/clientnegative/invalid_arithmetic_type.q.out c4e93ac
> ql/src/test/results/clientnegative/udf_assert_true2.q.out 699c4f3
> ql/src/test/results/clientpositive/auto_join13.q.out 95a4f13
> ql/src/test/results/clientpositive/auto_join2.q.out 1651f0d
> ql/src/test/results/clientpositive/bucketmapjoin_negative3.q.out e55f429
> ql/src/test/results/clientpositive/decimal_6.q.out 043321f
> ql/src/test/results/clientpositive/decimal_udf.q.out 1bc0db9
> ql/src/test/results/clientpositive/input8.q.out 7c036e1
> ql/src/test/results/clientpositive/num_op_type_conv.q.out 87feb59
> ql/src/test/results/clientpositive/orc_createas1.q.out 3b43e5a
> ql/src/test/results/clientpositive/ppd_constant_expr.q.out 9598110
> ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out 4463387
> ql/src/test/results/clientpositive/rcfile_createas1.q.out 0cbc2d2
> ql/src/test/results/clientpositive/rcfile_merge1.q.out 7e7eed5
> ql/src/test/results/clientpositive/rcfile_merge2.q.out a108309
> ql/src/test/results/clientpositive/skewjoin.q.out c5d57da
> ql/src/test/results/clientpositive/udf_pmod.q.out 0c77243
> ql/src/test/results/clientpositive/vectorization_15.q.out 717a3cb
> ql/src/test/results/clientpositive/vectorization_5.q.out 914a626
> ql/src/test/results/clientpositive/vectorization_short_regress.q.out 637a008
> ql/src/test/results/clientpositive/vectorized_math_funcs.q.out c684df1
> ql/src/test/results/clientpositive/windowing_expressions.q.out ce3d943
> ql/src/test/results/compiler/plan/cast1.q.xml 1d31be1
> ql/src/test/results/compiler/plan/input20.q.xml 346ed48
> ql/src/test/results/compiler/plan/input8.q.xml 5c07a5c
> ql/src/test/results/compiler/plan/join2.q.xml c769ea3
> ql/src/test/results/compiler/plan/sample1.q.xml 77aec1c
> ql/src/test/results/compiler/plan/sample2.q.xml 8f5e16f
> ql/src/test/results/compiler/plan/sample3.q.xml cd9a6fb
> ql/src/test/results/compiler/plan/sample4.q.xml 8f5e16f
> ql/src/test/results/compiler/plan/sample5.q.xml a10b8a5
> ql/src/test/results/compiler/plan/sample6.q.xml aaf60b9
> ql/src/test/results/compiler/plan/sample7.q.xml a82bbce
> ql/src/test/results/compiler/plan/udf4.q.xml 4346478
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java da5416a
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java c19f5aa
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantByteObjectInspector.java 0915562
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveDecimalObjectInspector.java a9ca7bd
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantIntObjectInspector.java 942a178
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantLongObjectInspector.java ad3a063
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantShortObjectInspector.java 6b67dac
> serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java 420509c
> serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 2982cf6
>
> Diff: https://reviews.apache.org/r/15113/diff/
>
>
> Testing
> -------
>
> Full set of unit tests is to be run. Old testcases are also migrated.
>
>
> Thanks,
>
> Xuefu Zhang
>
>
Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF
implementations
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15113/#review28976
-----------------------------------------------------------
Nice!! Looks good to me and it appears there are new unit tests! Some minor questions and comments below as well as two minor issues.
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
<https://reviews.apache.org/r/15113/#comment56029>
I see there are utilities in here prior to this patch so no work to do here but Function Registry doesn't feel like the right place to have these utilities.
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java
<https://reviews.apache.org/r/15113/#comment56031>
I assume these aren't final due to serialization. If so, it might be worth a comment indicating so.
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java
<https://reviews.apache.org/r/15113/#comment56030>
It looks like all these methods are going to be overridden by each sub-class? If that is true then they should be abstract with no body.
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java
<https://reviews.apache.org/r/15113/#comment56035>
Should these be constants in common or some shared location so jdbc and serde would share the same value?
- Brock Noland
On Nov. 14, 2013, 10:11 p.m., Xuefu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15113/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2013, 10:11 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVe-5356
> https://issues.apache.org/jira/browse/HIVe-5356
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Replace plus, minus, and so on 6 old UDFs with generic UDF implementations.
>
>
> Diffs
> -----
>
> common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java e3a1620
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 5eb321c
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 7c1ab0d
> ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 7838547
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java 1e74fce
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java b892b84
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java 0996231
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0942ac3
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 07c1957
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java cfe7b2b
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 0da7eae
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java 4aeb4e6
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 3f3e67f
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPDivide.java 659d65f
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java 4c2e722
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java 2a301bc
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMinus.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPlus.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java PRE-CREATION
> ql/src/test/results/clientnegative/invalid_arithmetic_type.q.out c4e93ac
> ql/src/test/results/clientnegative/udf_assert_true2.q.out 699c4f3
> ql/src/test/results/clientpositive/auto_join13.q.out 95a4f13
> ql/src/test/results/clientpositive/auto_join2.q.out 1651f0d
> ql/src/test/results/clientpositive/bucketmapjoin_negative3.q.out e55f429
> ql/src/test/results/clientpositive/decimal_6.q.out 043321f
> ql/src/test/results/clientpositive/decimal_udf.q.out 1bc0db9
> ql/src/test/results/clientpositive/input8.q.out 7c036e1
> ql/src/test/results/clientpositive/num_op_type_conv.q.out 87feb59
> ql/src/test/results/clientpositive/orc_createas1.q.out 3b43e5a
> ql/src/test/results/clientpositive/ppd_constant_expr.q.out 9598110
> ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out 4463387
> ql/src/test/results/clientpositive/rcfile_createas1.q.out 0cbc2d2
> ql/src/test/results/clientpositive/rcfile_merge1.q.out 7e7eed5
> ql/src/test/results/clientpositive/rcfile_merge2.q.out a108309
> ql/src/test/results/clientpositive/skewjoin.q.out c5d57da
> ql/src/test/results/clientpositive/udf_pmod.q.out 0c77243
> ql/src/test/results/clientpositive/vectorization_15.q.out 717a3cb
> ql/src/test/results/clientpositive/vectorization_5.q.out 914a626
> ql/src/test/results/clientpositive/vectorization_short_regress.q.out 637a008
> ql/src/test/results/clientpositive/vectorized_math_funcs.q.out c684df1
> ql/src/test/results/clientpositive/windowing_expressions.q.out ce3d943
> ql/src/test/results/compiler/plan/cast1.q.xml 1d31be1
> ql/src/test/results/compiler/plan/input20.q.xml 346ed48
> ql/src/test/results/compiler/plan/input8.q.xml 5c07a5c
> ql/src/test/results/compiler/plan/join2.q.xml c769ea3
> ql/src/test/results/compiler/plan/sample1.q.xml 77aec1c
> ql/src/test/results/compiler/plan/sample2.q.xml 8f5e16f
> ql/src/test/results/compiler/plan/sample3.q.xml cd9a6fb
> ql/src/test/results/compiler/plan/sample4.q.xml 8f5e16f
> ql/src/test/results/compiler/plan/sample5.q.xml a10b8a5
> ql/src/test/results/compiler/plan/sample6.q.xml aaf60b9
> ql/src/test/results/compiler/plan/sample7.q.xml a82bbce
> ql/src/test/results/compiler/plan/udf4.q.xml 4346478
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java da5416a
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java c19f5aa
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantByteObjectInspector.java 0915562
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveDecimalObjectInspector.java a9ca7bd
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantIntObjectInspector.java 942a178
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantLongObjectInspector.java ad3a063
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantShortObjectInspector.java 6b67dac
> serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java 420509c
> serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 2982cf6
>
> Diff: https://reviews.apache.org/r/15113/diff/
>
>
> Testing
> -------
>
> Full set of unit tests is to be run. Old testcases are also migrated.
>
>
> Thanks,
>
> Xuefu Zhang
>
>
Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF
implementations
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15113/
-----------------------------------------------------------
(Updated Nov. 14, 2013, 10:11 p.m.)
Review request for hive.
Bugs: HIVe-5356
https://issues.apache.org/jira/browse/HIVe-5356
Repository: hive-git
Description
-------
Replace plus, minus, and so on 6 old UDFs with generic UDF implementations.
Diffs (updated)
-----
common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java e3a1620
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 5eb321c
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 7c1ab0d
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 7838547
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java 1e74fce
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java b892b84
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java 0996231
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0942ac3
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 07c1957
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java cfe7b2b
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 0da7eae
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java 4aeb4e6
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 3f3e67f
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPDivide.java 659d65f
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java 4c2e722
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java 2a301bc
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMinus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPlus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java PRE-CREATION
ql/src/test/results/clientnegative/invalid_arithmetic_type.q.out c4e93ac
ql/src/test/results/clientnegative/udf_assert_true2.q.out 699c4f3
ql/src/test/results/clientpositive/auto_join13.q.out 95a4f13
ql/src/test/results/clientpositive/auto_join2.q.out 1651f0d
ql/src/test/results/clientpositive/bucketmapjoin_negative3.q.out e55f429
ql/src/test/results/clientpositive/decimal_6.q.out 043321f
ql/src/test/results/clientpositive/decimal_udf.q.out 1bc0db9
ql/src/test/results/clientpositive/input8.q.out 7c036e1
ql/src/test/results/clientpositive/num_op_type_conv.q.out 87feb59
ql/src/test/results/clientpositive/orc_createas1.q.out 3b43e5a
ql/src/test/results/clientpositive/ppd_constant_expr.q.out 9598110
ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out 4463387
ql/src/test/results/clientpositive/rcfile_createas1.q.out 0cbc2d2
ql/src/test/results/clientpositive/rcfile_merge1.q.out 7e7eed5
ql/src/test/results/clientpositive/rcfile_merge2.q.out a108309
ql/src/test/results/clientpositive/skewjoin.q.out c5d57da
ql/src/test/results/clientpositive/udf_pmod.q.out 0c77243
ql/src/test/results/clientpositive/vectorization_15.q.out 717a3cb
ql/src/test/results/clientpositive/vectorization_5.q.out 914a626
ql/src/test/results/clientpositive/vectorization_short_regress.q.out 637a008
ql/src/test/results/clientpositive/vectorized_math_funcs.q.out c684df1
ql/src/test/results/clientpositive/windowing_expressions.q.out ce3d943
ql/src/test/results/compiler/plan/cast1.q.xml 1d31be1
ql/src/test/results/compiler/plan/input20.q.xml 346ed48
ql/src/test/results/compiler/plan/input8.q.xml 5c07a5c
ql/src/test/results/compiler/plan/join2.q.xml c769ea3
ql/src/test/results/compiler/plan/sample1.q.xml 77aec1c
ql/src/test/results/compiler/plan/sample2.q.xml 8f5e16f
ql/src/test/results/compiler/plan/sample3.q.xml cd9a6fb
ql/src/test/results/compiler/plan/sample4.q.xml 8f5e16f
ql/src/test/results/compiler/plan/sample5.q.xml a10b8a5
ql/src/test/results/compiler/plan/sample6.q.xml aaf60b9
ql/src/test/results/compiler/plan/sample7.q.xml a82bbce
ql/src/test/results/compiler/plan/udf4.q.xml 4346478
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java da5416a
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java c19f5aa
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantByteObjectInspector.java 0915562
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveDecimalObjectInspector.java a9ca7bd
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantIntObjectInspector.java 942a178
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantLongObjectInspector.java ad3a063
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantShortObjectInspector.java 6b67dac
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java 420509c
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 2982cf6
Diff: https://reviews.apache.org/r/15113/diff/
Testing
-------
Full set of unit tests is to be run. Old testcases are also migrated.
Thanks,
Xuefu Zhang
Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF
implementations
Posted by Xuefu Zhang <xz...@cloudera.com>.
> On Nov. 14, 2013, 9:32 p.m., Jason Dere wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java, line 211
> > <https://reviews.apache.org/r/15113/diff/8/?file=384744#file384744line211>
> >
> > This part is still incorrect for decimal types, see the following result types below, add/sub/mult is wrong when the precision/scale match.
> >
> > expr: c1
> > type: decimal(10,2)
> > expr: c2
> > type: decimal(6,3)
> > expr: (c1 + c1)
> > type: decimal(10,2)
> > expr: (c1 + c2)
> > type: decimal(12,3)
> > expr: (c1 - c1)
> > type: decimal(10,2)
> > expr: (c1 - c2)
> > type: decimal(12,3)
> > expr: (c1 * c1)
> > type: decimal(10,2)
> > expr: (c1 * c2)
> > type: decimal(17,5)
> > expr: (c1 / c1)
> > type: decimal(23,13)
> > expr: (c1 / c2)
> > type: decimal(20,9)
> >
Got it. Thanks for pointing this out.
- Xuefu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15113/#review28904
-----------------------------------------------------------
On Nov. 14, 2013, 8:44 p.m., Xuefu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15113/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2013, 8:44 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVe-5356
> https://issues.apache.org/jira/browse/HIVe-5356
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Replace plus, minus, and so on 6 old UDFs with generic UDF implementations.
>
>
> Diffs
> -----
>
> common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java e3a1620
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 5eb321c
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 7c1ab0d
> ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 7838547
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java 1e74fce
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java b892b84
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java 0996231
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0942ac3
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 07c1957
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java cfe7b2b
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 0da7eae
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java 4aeb4e6
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 3f3e67f
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPDivide.java 659d65f
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java 4c2e722
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java 2a301bc
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMinus.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPlus.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java PRE-CREATION
> ql/src/test/results/clientnegative/invalid_arithmetic_type.q.out c4e93ac
> ql/src/test/results/clientnegative/udf_assert_true2.q.out 699c4f3
> ql/src/test/results/clientpositive/auto_join13.q.out 95a4f13
> ql/src/test/results/clientpositive/auto_join2.q.out 1651f0d
> ql/src/test/results/clientpositive/bucketmapjoin_negative3.q.out e55f429
> ql/src/test/results/clientpositive/decimal_6.q.out 043321f
> ql/src/test/results/clientpositive/decimal_udf.q.out 1bc0db9
> ql/src/test/results/clientpositive/input8.q.out 7c036e1
> ql/src/test/results/clientpositive/num_op_type_conv.q.out 87feb59
> ql/src/test/results/clientpositive/orc_createas1.q.out 3b43e5a
> ql/src/test/results/clientpositive/ppd_constant_expr.q.out 9598110
> ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out 4463387
> ql/src/test/results/clientpositive/rcfile_createas1.q.out 0cbc2d2
> ql/src/test/results/clientpositive/rcfile_merge1.q.out 7e7eed5
> ql/src/test/results/clientpositive/rcfile_merge2.q.out a108309
> ql/src/test/results/clientpositive/skewjoin.q.out c5d57da
> ql/src/test/results/clientpositive/udf_pmod.q.out 0c77243
> ql/src/test/results/clientpositive/vectorization_15.q.out 717a3cb
> ql/src/test/results/clientpositive/vectorization_5.q.out 914a626
> ql/src/test/results/clientpositive/vectorization_short_regress.q.out 637a008
> ql/src/test/results/clientpositive/vectorized_math_funcs.q.out c684df1
> ql/src/test/results/clientpositive/windowing_expressions.q.out ce3d943
> ql/src/test/results/compiler/plan/cast1.q.xml 1d31be1
> ql/src/test/results/compiler/plan/input20.q.xml 346ed48
> ql/src/test/results/compiler/plan/input8.q.xml 5c07a5c
> ql/src/test/results/compiler/plan/join2.q.xml c769ea3
> ql/src/test/results/compiler/plan/sample1.q.xml 77aec1c
> ql/src/test/results/compiler/plan/sample2.q.xml 8f5e16f
> ql/src/test/results/compiler/plan/sample3.q.xml cd9a6fb
> ql/src/test/results/compiler/plan/sample4.q.xml 8f5e16f
> ql/src/test/results/compiler/plan/sample5.q.xml a10b8a5
> ql/src/test/results/compiler/plan/sample6.q.xml aaf60b9
> ql/src/test/results/compiler/plan/sample7.q.xml a82bbce
> ql/src/test/results/compiler/plan/udf4.q.xml 4346478
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java da5416a
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java c19f5aa
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantByteObjectInspector.java 0915562
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveDecimalObjectInspector.java a9ca7bd
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantIntObjectInspector.java 942a178
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantLongObjectInspector.java ad3a063
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantShortObjectInspector.java 6b67dac
> serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java 420509c
> serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 2982cf6
>
> Diff: https://reviews.apache.org/r/15113/diff/
>
>
> Testing
> -------
>
> Full set of unit tests is to be run. Old testcases are also migrated.
>
>
> Thanks,
>
> Xuefu Zhang
>
>
Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF
implementations
Posted by Jason Dere <jd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15113/#review28904
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java
<https://reviews.apache.org/r/15113/#comment55971>
This part is still incorrect for decimal types, see the following result types below, add/sub/mult is wrong when the precision/scale match.
expr: c1
type: decimal(10,2)
expr: c2
type: decimal(6,3)
expr: (c1 + c1)
type: decimal(10,2)
expr: (c1 + c2)
type: decimal(12,3)
expr: (c1 - c1)
type: decimal(10,2)
expr: (c1 - c2)
type: decimal(12,3)
expr: (c1 * c1)
type: decimal(10,2)
expr: (c1 * c2)
type: decimal(17,5)
expr: (c1 / c1)
type: decimal(23,13)
expr: (c1 / c2)
type: decimal(20,9)
This is looking good, just the one issue about result precision/scale when both left/right operands are the same.
- Jason Dere
On Nov. 14, 2013, 8:44 p.m., Xuefu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15113/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2013, 8:44 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVe-5356
> https://issues.apache.org/jira/browse/HIVe-5356
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Replace plus, minus, and so on 6 old UDFs with generic UDF implementations.
>
>
> Diffs
> -----
>
> common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java e3a1620
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 5eb321c
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 7c1ab0d
> ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 7838547
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java 1e74fce
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java b892b84
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java 0996231
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0942ac3
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 07c1957
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java cfe7b2b
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 0da7eae
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java 4aeb4e6
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 3f3e67f
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPDivide.java 659d65f
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java 4c2e722
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java 2a301bc
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMinus.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPlus.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java PRE-CREATION
> ql/src/test/results/clientnegative/invalid_arithmetic_type.q.out c4e93ac
> ql/src/test/results/clientnegative/udf_assert_true2.q.out 699c4f3
> ql/src/test/results/clientpositive/auto_join13.q.out 95a4f13
> ql/src/test/results/clientpositive/auto_join2.q.out 1651f0d
> ql/src/test/results/clientpositive/bucketmapjoin_negative3.q.out e55f429
> ql/src/test/results/clientpositive/decimal_6.q.out 043321f
> ql/src/test/results/clientpositive/decimal_udf.q.out 1bc0db9
> ql/src/test/results/clientpositive/input8.q.out 7c036e1
> ql/src/test/results/clientpositive/num_op_type_conv.q.out 87feb59
> ql/src/test/results/clientpositive/orc_createas1.q.out 3b43e5a
> ql/src/test/results/clientpositive/ppd_constant_expr.q.out 9598110
> ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out 4463387
> ql/src/test/results/clientpositive/rcfile_createas1.q.out 0cbc2d2
> ql/src/test/results/clientpositive/rcfile_merge1.q.out 7e7eed5
> ql/src/test/results/clientpositive/rcfile_merge2.q.out a108309
> ql/src/test/results/clientpositive/skewjoin.q.out c5d57da
> ql/src/test/results/clientpositive/udf_pmod.q.out 0c77243
> ql/src/test/results/clientpositive/vectorization_15.q.out 717a3cb
> ql/src/test/results/clientpositive/vectorization_5.q.out 914a626
> ql/src/test/results/clientpositive/vectorization_short_regress.q.out 637a008
> ql/src/test/results/clientpositive/vectorized_math_funcs.q.out c684df1
> ql/src/test/results/clientpositive/windowing_expressions.q.out ce3d943
> ql/src/test/results/compiler/plan/cast1.q.xml 1d31be1
> ql/src/test/results/compiler/plan/input20.q.xml 346ed48
> ql/src/test/results/compiler/plan/input8.q.xml 5c07a5c
> ql/src/test/results/compiler/plan/join2.q.xml c769ea3
> ql/src/test/results/compiler/plan/sample1.q.xml 77aec1c
> ql/src/test/results/compiler/plan/sample2.q.xml 8f5e16f
> ql/src/test/results/compiler/plan/sample3.q.xml cd9a6fb
> ql/src/test/results/compiler/plan/sample4.q.xml 8f5e16f
> ql/src/test/results/compiler/plan/sample5.q.xml a10b8a5
> ql/src/test/results/compiler/plan/sample6.q.xml aaf60b9
> ql/src/test/results/compiler/plan/sample7.q.xml a82bbce
> ql/src/test/results/compiler/plan/udf4.q.xml 4346478
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java da5416a
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java c19f5aa
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantByteObjectInspector.java 0915562
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveDecimalObjectInspector.java a9ca7bd
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantIntObjectInspector.java 942a178
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantLongObjectInspector.java ad3a063
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantShortObjectInspector.java 6b67dac
> serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java 420509c
> serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 2982cf6
>
> Diff: https://reviews.apache.org/r/15113/diff/
>
>
> Testing
> -------
>
> Full set of unit tests is to be run. Old testcases are also migrated.
>
>
> Thanks,
>
> Xuefu Zhang
>
>
Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF
implementations
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15113/
-----------------------------------------------------------
(Updated Nov. 14, 2013, 8:44 p.m.)
Review request for hive.
Bugs: HIVe-5356
https://issues.apache.org/jira/browse/HIVe-5356
Repository: hive-git
Description
-------
Replace plus, minus, and so on 6 old UDFs with generic UDF implementations.
Diffs (updated)
-----
common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java e3a1620
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 5eb321c
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 7c1ab0d
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 7838547
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java 1e74fce
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java b892b84
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java 0996231
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0942ac3
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 07c1957
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java cfe7b2b
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 0da7eae
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java 4aeb4e6
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 3f3e67f
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPDivide.java 659d65f
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java 4c2e722
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java 2a301bc
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMinus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPlus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java PRE-CREATION
ql/src/test/results/clientnegative/invalid_arithmetic_type.q.out c4e93ac
ql/src/test/results/clientnegative/udf_assert_true2.q.out 699c4f3
ql/src/test/results/clientpositive/auto_join13.q.out 95a4f13
ql/src/test/results/clientpositive/auto_join2.q.out 1651f0d
ql/src/test/results/clientpositive/bucketmapjoin_negative3.q.out e55f429
ql/src/test/results/clientpositive/decimal_6.q.out 043321f
ql/src/test/results/clientpositive/decimal_udf.q.out 1bc0db9
ql/src/test/results/clientpositive/input8.q.out 7c036e1
ql/src/test/results/clientpositive/num_op_type_conv.q.out 87feb59
ql/src/test/results/clientpositive/orc_createas1.q.out 3b43e5a
ql/src/test/results/clientpositive/ppd_constant_expr.q.out 9598110
ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out 4463387
ql/src/test/results/clientpositive/rcfile_createas1.q.out 0cbc2d2
ql/src/test/results/clientpositive/rcfile_merge1.q.out 7e7eed5
ql/src/test/results/clientpositive/rcfile_merge2.q.out a108309
ql/src/test/results/clientpositive/skewjoin.q.out c5d57da
ql/src/test/results/clientpositive/udf_pmod.q.out 0c77243
ql/src/test/results/clientpositive/vectorization_15.q.out 717a3cb
ql/src/test/results/clientpositive/vectorization_5.q.out 914a626
ql/src/test/results/clientpositive/vectorization_short_regress.q.out 637a008
ql/src/test/results/clientpositive/vectorized_math_funcs.q.out c684df1
ql/src/test/results/clientpositive/windowing_expressions.q.out ce3d943
ql/src/test/results/compiler/plan/cast1.q.xml 1d31be1
ql/src/test/results/compiler/plan/input20.q.xml 346ed48
ql/src/test/results/compiler/plan/input8.q.xml 5c07a5c
ql/src/test/results/compiler/plan/join2.q.xml c769ea3
ql/src/test/results/compiler/plan/sample1.q.xml 77aec1c
ql/src/test/results/compiler/plan/sample2.q.xml 8f5e16f
ql/src/test/results/compiler/plan/sample3.q.xml cd9a6fb
ql/src/test/results/compiler/plan/sample4.q.xml 8f5e16f
ql/src/test/results/compiler/plan/sample5.q.xml a10b8a5
ql/src/test/results/compiler/plan/sample6.q.xml aaf60b9
ql/src/test/results/compiler/plan/sample7.q.xml a82bbce
ql/src/test/results/compiler/plan/udf4.q.xml 4346478
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java da5416a
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java c19f5aa
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantByteObjectInspector.java 0915562
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveDecimalObjectInspector.java a9ca7bd
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantIntObjectInspector.java 942a178
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantLongObjectInspector.java ad3a063
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantShortObjectInspector.java 6b67dac
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java 420509c
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 2982cf6
Diff: https://reviews.apache.org/r/15113/diff/
Testing
-------
Full set of unit tests is to be run. Old testcases are also migrated.
Thanks,
Xuefu Zhang
Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF
implementations
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15113/
-----------------------------------------------------------
(Updated Nov. 13, 2013, 3:36 p.m.)
Review request for hive.
Bugs: HIVe-5356
https://issues.apache.org/jira/browse/HIVe-5356
Repository: hive-git
Description
-------
Replace plus, minus, and so on 6 old UDFs with generic UDF implementations.
Diffs
-----
common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java e3a1620
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 5eb321c
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 7c1ab0d
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 7838547
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java 1e74fce
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java b892b84
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java 0996231
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0942ac3
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 07c1957
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java cfe7b2b
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 0da7eae
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java 4aeb4e6
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 3f3e67f
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPDivide.java 659d65f
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java 4c2e722
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java 2a301bc
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMinus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPlus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java PRE-CREATION
ql/src/test/results/clientnegative/invalid_arithmetic_type.q.out c4e93ac
ql/src/test/results/clientnegative/udf_assert_true2.q.out 699c4f3
ql/src/test/results/clientpositive/auto_join13.q.out 95a4f13
ql/src/test/results/clientpositive/auto_join2.q.out 1651f0d
ql/src/test/results/clientpositive/bucketmapjoin_negative3.q.out e55f429
ql/src/test/results/clientpositive/decimal_6.q.out 043321f
ql/src/test/results/clientpositive/decimal_udf.q.out 1bc0db9
ql/src/test/results/clientpositive/input8.q.out 7c036e1
ql/src/test/results/clientpositive/num_op_type_conv.q.out 87feb59
ql/src/test/results/clientpositive/orc_createas1.q.out 3b43e5a
ql/src/test/results/clientpositive/ppd_constant_expr.q.out 9598110
ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out 4463387
ql/src/test/results/clientpositive/rcfile_createas1.q.out 0cbc2d2
ql/src/test/results/clientpositive/rcfile_merge1.q.out 7e7eed5
ql/src/test/results/clientpositive/rcfile_merge2.q.out a108309
ql/src/test/results/clientpositive/skewjoin.q.out c5d57da
ql/src/test/results/clientpositive/udf_pmod.q.out 0c77243
ql/src/test/results/clientpositive/vectorization_15.q.out 717a3cb
ql/src/test/results/clientpositive/vectorization_5.q.out 914a626
ql/src/test/results/clientpositive/vectorization_short_regress.q.out 637a008
ql/src/test/results/clientpositive/vectorized_math_funcs.q.out c684df1
ql/src/test/results/clientpositive/windowing_expressions.q.out ce3d943
ql/src/test/results/compiler/plan/cast1.q.xml 1d31be1
ql/src/test/results/compiler/plan/input20.q.xml 346ed48
ql/src/test/results/compiler/plan/input8.q.xml 5c07a5c
ql/src/test/results/compiler/plan/join2.q.xml c769ea3
ql/src/test/results/compiler/plan/sample1.q.xml 77aec1c
ql/src/test/results/compiler/plan/sample2.q.xml 8f5e16f
ql/src/test/results/compiler/plan/sample3.q.xml cd9a6fb
ql/src/test/results/compiler/plan/sample4.q.xml 8f5e16f
ql/src/test/results/compiler/plan/sample5.q.xml a10b8a5
ql/src/test/results/compiler/plan/sample6.q.xml aaf60b9
ql/src/test/results/compiler/plan/sample7.q.xml a82bbce
ql/src/test/results/compiler/plan/udf4.q.xml 4346478
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java da5416a
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java c19f5aa
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantByteObjectInspector.java 0915562
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveDecimalObjectInspector.java a9ca7bd
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantIntObjectInspector.java 942a178
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantLongObjectInspector.java ad3a063
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantShortObjectInspector.java 6b67dac
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java 420509c
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 2982cf6
Diff: https://reviews.apache.org/r/15113/diff/
Testing
-------
Full set of unit tests is to be run. Old testcases are also migrated.
Thanks,
Xuefu Zhang
Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF
implementations
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15113/
-----------------------------------------------------------
(Updated Nov. 13, 2013, 3:36 p.m.)
Review request for hive.
Bugs: HIVe-5356
https://issues.apache.org/jira/browse/HIVe-5356
Repository: hive-git
Description
-------
Replace plus, minus, and so on 6 old UDFs with generic UDF implementations.
Diffs (updated)
-----
common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java e3a1620
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 5eb321c
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 7c1ab0d
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 7838547
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java 1e74fce
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java b892b84
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java 0996231
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0942ac3
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 07c1957
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java cfe7b2b
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 0da7eae
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java 4aeb4e6
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 3f3e67f
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPDivide.java 659d65f
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java 4c2e722
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java 2a301bc
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMinus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPlus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java PRE-CREATION
ql/src/test/results/clientnegative/invalid_arithmetic_type.q.out c4e93ac
ql/src/test/results/clientnegative/udf_assert_true2.q.out 699c4f3
ql/src/test/results/clientpositive/auto_join13.q.out 95a4f13
ql/src/test/results/clientpositive/auto_join2.q.out 1651f0d
ql/src/test/results/clientpositive/bucketmapjoin_negative3.q.out e55f429
ql/src/test/results/clientpositive/decimal_6.q.out 043321f
ql/src/test/results/clientpositive/decimal_udf.q.out 1bc0db9
ql/src/test/results/clientpositive/input8.q.out 7c036e1
ql/src/test/results/clientpositive/num_op_type_conv.q.out 87feb59
ql/src/test/results/clientpositive/orc_createas1.q.out 3b43e5a
ql/src/test/results/clientpositive/ppd_constant_expr.q.out 9598110
ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out 4463387
ql/src/test/results/clientpositive/rcfile_createas1.q.out 0cbc2d2
ql/src/test/results/clientpositive/rcfile_merge1.q.out 7e7eed5
ql/src/test/results/clientpositive/rcfile_merge2.q.out a108309
ql/src/test/results/clientpositive/skewjoin.q.out c5d57da
ql/src/test/results/clientpositive/udf_pmod.q.out 0c77243
ql/src/test/results/clientpositive/vectorization_15.q.out 717a3cb
ql/src/test/results/clientpositive/vectorization_5.q.out 914a626
ql/src/test/results/clientpositive/vectorization_short_regress.q.out 637a008
ql/src/test/results/clientpositive/vectorized_math_funcs.q.out c684df1
ql/src/test/results/clientpositive/windowing_expressions.q.out ce3d943
ql/src/test/results/compiler/plan/cast1.q.xml 1d31be1
ql/src/test/results/compiler/plan/input20.q.xml 346ed48
ql/src/test/results/compiler/plan/input8.q.xml 5c07a5c
ql/src/test/results/compiler/plan/join2.q.xml c769ea3
ql/src/test/results/compiler/plan/sample1.q.xml 77aec1c
ql/src/test/results/compiler/plan/sample2.q.xml 8f5e16f
ql/src/test/results/compiler/plan/sample3.q.xml cd9a6fb
ql/src/test/results/compiler/plan/sample4.q.xml 8f5e16f
ql/src/test/results/compiler/plan/sample5.q.xml a10b8a5
ql/src/test/results/compiler/plan/sample6.q.xml aaf60b9
ql/src/test/results/compiler/plan/sample7.q.xml a82bbce
ql/src/test/results/compiler/plan/udf4.q.xml 4346478
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java da5416a
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java c19f5aa
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantByteObjectInspector.java 0915562
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveDecimalObjectInspector.java a9ca7bd
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantIntObjectInspector.java 942a178
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantLongObjectInspector.java ad3a063
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantShortObjectInspector.java 6b67dac
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java 420509c
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 2982cf6
Diff: https://reviews.apache.org/r/15113/diff/
Testing
-------
Full set of unit tests is to be run. Old testcases are also migrated.
Thanks,
Xuefu Zhang
Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF
implementations
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15113/
-----------------------------------------------------------
(Updated Nov. 13, 2013, 3:36 p.m.)
Review request for hive.
Bugs: HIVe-5356
https://issues.apache.org/jira/browse/HIVe-5356
Repository: hive-git
Description
-------
Replace plus, minus, and so on 6 old UDFs with generic UDF implementations.
Diffs
-----
common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java e3a1620
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 5eb321c
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 7c1ab0d
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 7838547
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java 1e74fce
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java b892b84
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java 0996231
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0942ac3
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 07c1957
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java cfe7b2b
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 0da7eae
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java 4aeb4e6
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 3f3e67f
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPDivide.java 659d65f
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java 4c2e722
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java 2a301bc
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMinus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPlus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java PRE-CREATION
ql/src/test/results/clientnegative/invalid_arithmetic_type.q.out c4e93ac
ql/src/test/results/clientnegative/udf_assert_true2.q.out 699c4f3
ql/src/test/results/clientpositive/auto_join13.q.out 95a4f13
ql/src/test/results/clientpositive/auto_join2.q.out 1651f0d
ql/src/test/results/clientpositive/bucketmapjoin_negative3.q.out e55f429
ql/src/test/results/clientpositive/decimal_6.q.out 043321f
ql/src/test/results/clientpositive/decimal_udf.q.out 1bc0db9
ql/src/test/results/clientpositive/input8.q.out 7c036e1
ql/src/test/results/clientpositive/num_op_type_conv.q.out 87feb59
ql/src/test/results/clientpositive/orc_createas1.q.out 3b43e5a
ql/src/test/results/clientpositive/ppd_constant_expr.q.out 9598110
ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out 4463387
ql/src/test/results/clientpositive/rcfile_createas1.q.out 0cbc2d2
ql/src/test/results/clientpositive/rcfile_merge1.q.out 7e7eed5
ql/src/test/results/clientpositive/rcfile_merge2.q.out a108309
ql/src/test/results/clientpositive/skewjoin.q.out c5d57da
ql/src/test/results/clientpositive/udf_pmod.q.out 0c77243
ql/src/test/results/clientpositive/vectorization_15.q.out 717a3cb
ql/src/test/results/clientpositive/vectorization_5.q.out 914a626
ql/src/test/results/clientpositive/vectorization_short_regress.q.out 637a008
ql/src/test/results/clientpositive/vectorized_math_funcs.q.out c684df1
ql/src/test/results/clientpositive/windowing_expressions.q.out ce3d943
ql/src/test/results/compiler/plan/cast1.q.xml 1d31be1
ql/src/test/results/compiler/plan/input20.q.xml 346ed48
ql/src/test/results/compiler/plan/input8.q.xml 5c07a5c
ql/src/test/results/compiler/plan/join2.q.xml c769ea3
ql/src/test/results/compiler/plan/sample1.q.xml 77aec1c
ql/src/test/results/compiler/plan/sample2.q.xml 8f5e16f
ql/src/test/results/compiler/plan/sample3.q.xml cd9a6fb
ql/src/test/results/compiler/plan/sample4.q.xml 8f5e16f
ql/src/test/results/compiler/plan/sample5.q.xml a10b8a5
ql/src/test/results/compiler/plan/sample6.q.xml aaf60b9
ql/src/test/results/compiler/plan/sample7.q.xml a82bbce
ql/src/test/results/compiler/plan/udf4.q.xml 4346478
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java da5416a
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java c19f5aa
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantByteObjectInspector.java 0915562
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveDecimalObjectInspector.java a9ca7bd
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantIntObjectInspector.java 942a178
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantLongObjectInspector.java ad3a063
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantShortObjectInspector.java 6b67dac
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java 420509c
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 2982cf6
Diff: https://reviews.apache.org/r/15113/diff/
Testing
-------
Full set of unit tests is to be run. Old testcases are also migrated.
Thanks,
Xuefu Zhang
Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF
implementations
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15113/
-----------------------------------------------------------
(Updated Nov. 13, 2013, 3:35 p.m.)
Review request for hive.
Bugs: HIVe-5356
https://issues.apache.org/jira/browse/HIVe-5356
Repository: hive-git
Description
-------
Replace plus, minus, and so on 6 old UDFs with generic UDF implementations.
Diffs
-----
common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java e3a1620
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 5eb321c
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 7c1ab0d
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 7838547
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java 1e74fce
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java b892b84
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java 0996231
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0942ac3
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 07c1957
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java cfe7b2b
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 0da7eae
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java 4aeb4e6
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 3f3e67f
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPDivide.java 659d65f
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java 4c2e722
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java 2a301bc
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMinus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPlus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java PRE-CREATION
ql/src/test/results/clientnegative/invalid_arithmetic_type.q.out c4e93ac
ql/src/test/results/clientnegative/udf_assert_true2.q.out 699c4f3
ql/src/test/results/clientpositive/auto_join13.q.out 95a4f13
ql/src/test/results/clientpositive/auto_join2.q.out 1651f0d
ql/src/test/results/clientpositive/bucketmapjoin_negative3.q.out e55f429
ql/src/test/results/clientpositive/decimal_6.q.out 043321f
ql/src/test/results/clientpositive/decimal_udf.q.out 1bc0db9
ql/src/test/results/clientpositive/input8.q.out 7c036e1
ql/src/test/results/clientpositive/num_op_type_conv.q.out 87feb59
ql/src/test/results/clientpositive/orc_createas1.q.out 3b43e5a
ql/src/test/results/clientpositive/ppd_constant_expr.q.out 9598110
ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out 4463387
ql/src/test/results/clientpositive/rcfile_createas1.q.out 0cbc2d2
ql/src/test/results/clientpositive/rcfile_merge1.q.out 7e7eed5
ql/src/test/results/clientpositive/rcfile_merge2.q.out a108309
ql/src/test/results/clientpositive/skewjoin.q.out c5d57da
ql/src/test/results/clientpositive/udf_pmod.q.out 0c77243
ql/src/test/results/clientpositive/vectorization_15.q.out 717a3cb
ql/src/test/results/clientpositive/vectorization_5.q.out 914a626
ql/src/test/results/clientpositive/vectorization_short_regress.q.out 637a008
ql/src/test/results/clientpositive/vectorized_math_funcs.q.out c684df1
ql/src/test/results/clientpositive/windowing_expressions.q.out ce3d943
ql/src/test/results/compiler/plan/cast1.q.xml 1d31be1
ql/src/test/results/compiler/plan/input20.q.xml 346ed48
ql/src/test/results/compiler/plan/input8.q.xml 5c07a5c
ql/src/test/results/compiler/plan/join2.q.xml c769ea3
ql/src/test/results/compiler/plan/sample1.q.xml 77aec1c
ql/src/test/results/compiler/plan/sample2.q.xml 8f5e16f
ql/src/test/results/compiler/plan/sample3.q.xml cd9a6fb
ql/src/test/results/compiler/plan/sample4.q.xml 8f5e16f
ql/src/test/results/compiler/plan/sample5.q.xml a10b8a5
ql/src/test/results/compiler/plan/sample6.q.xml aaf60b9
ql/src/test/results/compiler/plan/sample7.q.xml a82bbce
ql/src/test/results/compiler/plan/udf4.q.xml 4346478
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java da5416a
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java c19f5aa
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantByteObjectInspector.java 0915562
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveDecimalObjectInspector.java a9ca7bd
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantIntObjectInspector.java 942a178
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantLongObjectInspector.java ad3a063
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantShortObjectInspector.java 6b67dac
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java 420509c
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 2982cf6
Diff: https://reviews.apache.org/r/15113/diff/
Testing
-------
Full set of unit tests is to be run. Old testcases are also migrated.
Thanks,
Xuefu Zhang
Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF
implementations
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15113/
-----------------------------------------------------------
(Updated Nov. 13, 2013, 3:35 p.m.)
Review request for hive.
Bugs: HIVe-5356
https://issues.apache.org/jira/browse/HIVe-5356
Repository: hive-git
Description
-------
Replace plus, minus, and so on 6 old UDFs with generic UDF implementations.
Diffs
-----
common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java e3a1620
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 5eb321c
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 7c1ab0d
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 7838547
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java 1e74fce
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java b892b84
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java 0996231
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0942ac3
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 07c1957
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java cfe7b2b
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 0da7eae
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java 4aeb4e6
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 3f3e67f
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPDivide.java 659d65f
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java 4c2e722
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java 2a301bc
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMinus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPlus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java PRE-CREATION
ql/src/test/results/clientnegative/invalid_arithmetic_type.q.out c4e93ac
ql/src/test/results/clientnegative/udf_assert_true2.q.out 699c4f3
ql/src/test/results/clientpositive/auto_join13.q.out 95a4f13
ql/src/test/results/clientpositive/auto_join2.q.out 1651f0d
ql/src/test/results/clientpositive/bucketmapjoin_negative3.q.out e55f429
ql/src/test/results/clientpositive/decimal_6.q.out 043321f
ql/src/test/results/clientpositive/decimal_udf.q.out 1bc0db9
ql/src/test/results/clientpositive/input8.q.out 7c036e1
ql/src/test/results/clientpositive/num_op_type_conv.q.out 87feb59
ql/src/test/results/clientpositive/orc_createas1.q.out 3b43e5a
ql/src/test/results/clientpositive/ppd_constant_expr.q.out 9598110
ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out 4463387
ql/src/test/results/clientpositive/rcfile_createas1.q.out 0cbc2d2
ql/src/test/results/clientpositive/rcfile_merge1.q.out 7e7eed5
ql/src/test/results/clientpositive/rcfile_merge2.q.out a108309
ql/src/test/results/clientpositive/skewjoin.q.out c5d57da
ql/src/test/results/clientpositive/udf_pmod.q.out 0c77243
ql/src/test/results/clientpositive/vectorization_15.q.out 717a3cb
ql/src/test/results/clientpositive/vectorization_5.q.out 914a626
ql/src/test/results/clientpositive/vectorization_short_regress.q.out 637a008
ql/src/test/results/clientpositive/vectorized_math_funcs.q.out c684df1
ql/src/test/results/clientpositive/windowing_expressions.q.out ce3d943
ql/src/test/results/compiler/plan/cast1.q.xml 1d31be1
ql/src/test/results/compiler/plan/input20.q.xml 346ed48
ql/src/test/results/compiler/plan/input8.q.xml 5c07a5c
ql/src/test/results/compiler/plan/join2.q.xml c769ea3
ql/src/test/results/compiler/plan/sample1.q.xml 77aec1c
ql/src/test/results/compiler/plan/sample2.q.xml 8f5e16f
ql/src/test/results/compiler/plan/sample3.q.xml cd9a6fb
ql/src/test/results/compiler/plan/sample4.q.xml 8f5e16f
ql/src/test/results/compiler/plan/sample5.q.xml a10b8a5
ql/src/test/results/compiler/plan/sample6.q.xml aaf60b9
ql/src/test/results/compiler/plan/sample7.q.xml a82bbce
ql/src/test/results/compiler/plan/udf4.q.xml 4346478
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java da5416a
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java c19f5aa
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantByteObjectInspector.java 0915562
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveDecimalObjectInspector.java a9ca7bd
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantIntObjectInspector.java 942a178
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantLongObjectInspector.java ad3a063
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantShortObjectInspector.java 6b67dac
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java 420509c
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 2982cf6
Diff: https://reviews.apache.org/r/15113/diff/
Testing
-------
Full set of unit tests is to be run. Old testcases are also migrated.
Thanks,
Xuefu Zhang
Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF
implementations
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15113/
-----------------------------------------------------------
(Updated Nov. 13, 2013, 3:35 p.m.)
Review request for hive.
Bugs: HIVe-5356
https://issues.apache.org/jira/browse/HIVe-5356
Repository: hive-git
Description
-------
Replace plus, minus, and so on 6 old UDFs with generic UDF implementations.
Diffs (updated)
-----
common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java e3a1620
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 5eb321c
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 7c1ab0d
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 7838547
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java 1e74fce
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java b892b84
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java 0996231
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0942ac3
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 07c1957
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java cfe7b2b
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 0da7eae
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java 4aeb4e6
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 3f3e67f
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPDivide.java 659d65f
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java 4c2e722
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java 2a301bc
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMinus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPlus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java PRE-CREATION
ql/src/test/results/clientnegative/invalid_arithmetic_type.q.out c4e93ac
ql/src/test/results/clientnegative/udf_assert_true2.q.out 699c4f3
ql/src/test/results/clientpositive/auto_join13.q.out 95a4f13
ql/src/test/results/clientpositive/auto_join2.q.out 1651f0d
ql/src/test/results/clientpositive/bucketmapjoin_negative3.q.out e55f429
ql/src/test/results/clientpositive/decimal_6.q.out 043321f
ql/src/test/results/clientpositive/decimal_udf.q.out 1bc0db9
ql/src/test/results/clientpositive/input8.q.out 7c036e1
ql/src/test/results/clientpositive/num_op_type_conv.q.out 87feb59
ql/src/test/results/clientpositive/orc_createas1.q.out 3b43e5a
ql/src/test/results/clientpositive/ppd_constant_expr.q.out 9598110
ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out 4463387
ql/src/test/results/clientpositive/rcfile_createas1.q.out 0cbc2d2
ql/src/test/results/clientpositive/rcfile_merge1.q.out 7e7eed5
ql/src/test/results/clientpositive/rcfile_merge2.q.out a108309
ql/src/test/results/clientpositive/skewjoin.q.out c5d57da
ql/src/test/results/clientpositive/udf_pmod.q.out 0c77243
ql/src/test/results/clientpositive/vectorization_15.q.out 717a3cb
ql/src/test/results/clientpositive/vectorization_5.q.out 914a626
ql/src/test/results/clientpositive/vectorization_short_regress.q.out 637a008
ql/src/test/results/clientpositive/vectorized_math_funcs.q.out c684df1
ql/src/test/results/clientpositive/windowing_expressions.q.out ce3d943
ql/src/test/results/compiler/plan/cast1.q.xml 1d31be1
ql/src/test/results/compiler/plan/input20.q.xml 346ed48
ql/src/test/results/compiler/plan/input8.q.xml 5c07a5c
ql/src/test/results/compiler/plan/join2.q.xml c769ea3
ql/src/test/results/compiler/plan/sample1.q.xml 77aec1c
ql/src/test/results/compiler/plan/sample2.q.xml 8f5e16f
ql/src/test/results/compiler/plan/sample3.q.xml cd9a6fb
ql/src/test/results/compiler/plan/sample4.q.xml 8f5e16f
ql/src/test/results/compiler/plan/sample5.q.xml a10b8a5
ql/src/test/results/compiler/plan/sample6.q.xml aaf60b9
ql/src/test/results/compiler/plan/sample7.q.xml a82bbce
ql/src/test/results/compiler/plan/udf4.q.xml 4346478
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java da5416a
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java c19f5aa
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantByteObjectInspector.java 0915562
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveDecimalObjectInspector.java a9ca7bd
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantIntObjectInspector.java 942a178
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantLongObjectInspector.java ad3a063
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantShortObjectInspector.java 6b67dac
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java 420509c
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 2982cf6
Diff: https://reviews.apache.org/r/15113/diff/
Testing
-------
Full set of unit tests is to be run. Old testcases are also migrated.
Thanks,
Xuefu Zhang
Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF
implementations
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15113/
-----------------------------------------------------------
(Updated Nov. 13, 2013, 3:34 p.m.)
Review request for hive.
Bugs: HIVe-5356
https://issues.apache.org/jira/browse/HIVe-5356
Repository: hive-git
Description
-------
Replace plus, minus, and so on 6 old UDFs with generic UDF implementations.
Diffs
-----
common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java e3a1620
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 5eb321c
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 7c1ab0d
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 7838547
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java 1e74fce
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java b892b84
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java 0996231
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0942ac3
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 07c1957
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java cfe7b2b
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 0da7eae
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java 4aeb4e6
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 3f3e67f
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPDivide.java 659d65f
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java 4c2e722
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java 2a301bc
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMinus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPlus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java PRE-CREATION
ql/src/test/results/clientnegative/invalid_arithmetic_type.q.out c4e93ac
ql/src/test/results/clientnegative/udf_assert_true2.q.out 699c4f3
ql/src/test/results/clientpositive/auto_join13.q.out 95a4f13
ql/src/test/results/clientpositive/auto_join2.q.out 1651f0d
ql/src/test/results/clientpositive/bucketmapjoin_negative3.q.out e55f429
ql/src/test/results/clientpositive/decimal_6.q.out 043321f
ql/src/test/results/clientpositive/decimal_udf.q.out 1bc0db9
ql/src/test/results/clientpositive/input8.q.out 7c036e1
ql/src/test/results/clientpositive/num_op_type_conv.q.out 87feb59
ql/src/test/results/clientpositive/orc_createas1.q.out 3b43e5a
ql/src/test/results/clientpositive/ppd_constant_expr.q.out 9598110
ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out 4463387
ql/src/test/results/clientpositive/rcfile_createas1.q.out 0cbc2d2
ql/src/test/results/clientpositive/rcfile_merge1.q.out 7e7eed5
ql/src/test/results/clientpositive/rcfile_merge2.q.out a108309
ql/src/test/results/clientpositive/skewjoin.q.out c5d57da
ql/src/test/results/clientpositive/udf_pmod.q.out 0c77243
ql/src/test/results/clientpositive/vectorization_15.q.out 717a3cb
ql/src/test/results/clientpositive/vectorization_5.q.out 914a626
ql/src/test/results/clientpositive/vectorization_short_regress.q.out 637a008
ql/src/test/results/clientpositive/vectorized_math_funcs.q.out c684df1
ql/src/test/results/clientpositive/windowing_expressions.q.out ce3d943
ql/src/test/results/compiler/plan/cast1.q.xml 1d31be1
ql/src/test/results/compiler/plan/input20.q.xml 346ed48
ql/src/test/results/compiler/plan/input8.q.xml 5c07a5c
ql/src/test/results/compiler/plan/join2.q.xml c769ea3
ql/src/test/results/compiler/plan/sample1.q.xml 77aec1c
ql/src/test/results/compiler/plan/sample2.q.xml 8f5e16f
ql/src/test/results/compiler/plan/sample3.q.xml cd9a6fb
ql/src/test/results/compiler/plan/sample4.q.xml 8f5e16f
ql/src/test/results/compiler/plan/sample5.q.xml a10b8a5
ql/src/test/results/compiler/plan/sample6.q.xml aaf60b9
ql/src/test/results/compiler/plan/sample7.q.xml a82bbce
ql/src/test/results/compiler/plan/udf4.q.xml 4346478
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java da5416a
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java c19f5aa
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantByteObjectInspector.java 0915562
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveDecimalObjectInspector.java a9ca7bd
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantIntObjectInspector.java 942a178
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantLongObjectInspector.java ad3a063
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantShortObjectInspector.java 6b67dac
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java 420509c
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 2982cf6
Diff: https://reviews.apache.org/r/15113/diff/
Testing
-------
Full set of unit tests is to be run. Old testcases are also migrated.
Thanks,
Xuefu Zhang
Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF
implementations
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15113/
-----------------------------------------------------------
(Updated Nov. 13, 2013, 3:33 p.m.)
Review request for hive.
Bugs: HIVe-5356
https://issues.apache.org/jira/browse/HIVe-5356
Repository: hive-git
Description
-------
Replace plus, minus, and so on 6 old UDFs with generic UDF implementations.
Diffs
-----
common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java e3a1620
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 5eb321c
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 7c1ab0d
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 7838547
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java 1e74fce
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java b892b84
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java 0996231
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0942ac3
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 07c1957
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java cfe7b2b
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 0da7eae
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java 4aeb4e6
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 3f3e67f
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPDivide.java 659d65f
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java 4c2e722
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java 2a301bc
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMinus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPlus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java PRE-CREATION
ql/src/test/results/clientnegative/invalid_arithmetic_type.q.out c4e93ac
ql/src/test/results/clientnegative/udf_assert_true2.q.out 699c4f3
ql/src/test/results/clientpositive/auto_join13.q.out 95a4f13
ql/src/test/results/clientpositive/auto_join2.q.out 1651f0d
ql/src/test/results/clientpositive/bucketmapjoin_negative3.q.out e55f429
ql/src/test/results/clientpositive/decimal_6.q.out 043321f
ql/src/test/results/clientpositive/decimal_udf.q.out 1bc0db9
ql/src/test/results/clientpositive/input8.q.out 7c036e1
ql/src/test/results/clientpositive/num_op_type_conv.q.out 87feb59
ql/src/test/results/clientpositive/orc_createas1.q.out 3b43e5a
ql/src/test/results/clientpositive/ppd_constant_expr.q.out 9598110
ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out 4463387
ql/src/test/results/clientpositive/rcfile_createas1.q.out 0cbc2d2
ql/src/test/results/clientpositive/rcfile_merge1.q.out 7e7eed5
ql/src/test/results/clientpositive/rcfile_merge2.q.out a108309
ql/src/test/results/clientpositive/skewjoin.q.out c5d57da
ql/src/test/results/clientpositive/udf_pmod.q.out 0c77243
ql/src/test/results/clientpositive/vectorization_15.q.out 717a3cb
ql/src/test/results/clientpositive/vectorization_5.q.out 914a626
ql/src/test/results/clientpositive/vectorization_short_regress.q.out 637a008
ql/src/test/results/clientpositive/vectorized_math_funcs.q.out c684df1
ql/src/test/results/clientpositive/windowing_expressions.q.out ce3d943
ql/src/test/results/compiler/plan/cast1.q.xml 1d31be1
ql/src/test/results/compiler/plan/input20.q.xml 346ed48
ql/src/test/results/compiler/plan/input8.q.xml 5c07a5c
ql/src/test/results/compiler/plan/join2.q.xml c769ea3
ql/src/test/results/compiler/plan/sample1.q.xml 77aec1c
ql/src/test/results/compiler/plan/sample2.q.xml 8f5e16f
ql/src/test/results/compiler/plan/sample3.q.xml cd9a6fb
ql/src/test/results/compiler/plan/sample4.q.xml 8f5e16f
ql/src/test/results/compiler/plan/sample5.q.xml a10b8a5
ql/src/test/results/compiler/plan/sample6.q.xml aaf60b9
ql/src/test/results/compiler/plan/sample7.q.xml a82bbce
ql/src/test/results/compiler/plan/udf4.q.xml 4346478
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java da5416a
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java c19f5aa
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantByteObjectInspector.java 0915562
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveDecimalObjectInspector.java a9ca7bd
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantIntObjectInspector.java 942a178
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantLongObjectInspector.java ad3a063
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantShortObjectInspector.java 6b67dac
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java 420509c
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 2982cf6
Diff: https://reviews.apache.org/r/15113/diff/
Testing
-------
Full set of unit tests is to be run. Old testcases are also migrated.
Thanks,
Xuefu Zhang
Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF
implementations
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15113/
-----------------------------------------------------------
(Updated Nov. 13, 2013, 3:33 p.m.)
Review request for hive.
Bugs: HIVe-5356
https://issues.apache.org/jira/browse/HIVe-5356
Repository: hive-git
Description
-------
Replace plus, minus, and so on 6 old UDFs with generic UDF implementations.
Diffs
-----
common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java e3a1620
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 5eb321c
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 7c1ab0d
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 7838547
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java 1e74fce
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java b892b84
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java 0996231
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0942ac3
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 07c1957
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java cfe7b2b
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 0da7eae
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java 4aeb4e6
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 3f3e67f
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPDivide.java 659d65f
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java 4c2e722
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java 2a301bc
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMinus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPlus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java PRE-CREATION
ql/src/test/results/clientnegative/invalid_arithmetic_type.q.out c4e93ac
ql/src/test/results/clientnegative/udf_assert_true2.q.out 699c4f3
ql/src/test/results/clientpositive/auto_join13.q.out 95a4f13
ql/src/test/results/clientpositive/auto_join2.q.out 1651f0d
ql/src/test/results/clientpositive/bucketmapjoin_negative3.q.out e55f429
ql/src/test/results/clientpositive/decimal_6.q.out 043321f
ql/src/test/results/clientpositive/decimal_udf.q.out 1bc0db9
ql/src/test/results/clientpositive/input8.q.out 7c036e1
ql/src/test/results/clientpositive/num_op_type_conv.q.out 87feb59
ql/src/test/results/clientpositive/orc_createas1.q.out 3b43e5a
ql/src/test/results/clientpositive/ppd_constant_expr.q.out 9598110
ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out 4463387
ql/src/test/results/clientpositive/rcfile_createas1.q.out 0cbc2d2
ql/src/test/results/clientpositive/rcfile_merge1.q.out 7e7eed5
ql/src/test/results/clientpositive/rcfile_merge2.q.out a108309
ql/src/test/results/clientpositive/skewjoin.q.out c5d57da
ql/src/test/results/clientpositive/udf_pmod.q.out 0c77243
ql/src/test/results/clientpositive/vectorization_15.q.out 717a3cb
ql/src/test/results/clientpositive/vectorization_5.q.out 914a626
ql/src/test/results/clientpositive/vectorization_short_regress.q.out 637a008
ql/src/test/results/clientpositive/vectorized_math_funcs.q.out c684df1
ql/src/test/results/clientpositive/windowing_expressions.q.out ce3d943
ql/src/test/results/compiler/plan/cast1.q.xml 1d31be1
ql/src/test/results/compiler/plan/input20.q.xml 346ed48
ql/src/test/results/compiler/plan/input8.q.xml 5c07a5c
ql/src/test/results/compiler/plan/join2.q.xml c769ea3
ql/src/test/results/compiler/plan/sample1.q.xml 77aec1c
ql/src/test/results/compiler/plan/sample2.q.xml 8f5e16f
ql/src/test/results/compiler/plan/sample3.q.xml cd9a6fb
ql/src/test/results/compiler/plan/sample4.q.xml 8f5e16f
ql/src/test/results/compiler/plan/sample5.q.xml a10b8a5
ql/src/test/results/compiler/plan/sample6.q.xml aaf60b9
ql/src/test/results/compiler/plan/sample7.q.xml a82bbce
ql/src/test/results/compiler/plan/udf4.q.xml 4346478
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java da5416a
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java c19f5aa
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantByteObjectInspector.java 0915562
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveDecimalObjectInspector.java a9ca7bd
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantIntObjectInspector.java 942a178
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantLongObjectInspector.java ad3a063
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantShortObjectInspector.java 6b67dac
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java 420509c
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 2982cf6
Diff: https://reviews.apache.org/r/15113/diff/
Testing
-------
Full set of unit tests is to be run. Old testcases are also migrated.
Thanks,
Xuefu Zhang
Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF
implementations
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15113/
-----------------------------------------------------------
(Updated Nov. 13, 2013, 3:33 p.m.)
Review request for hive.
Bugs: HIVe-5356
https://issues.apache.org/jira/browse/HIVe-5356
Repository: hive-git
Description
-------
Replace plus, minus, and so on 6 old UDFs with generic UDF implementations.
Diffs (updated)
-----
common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java e3a1620
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 5eb321c
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 7c1ab0d
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 7838547
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java 1e74fce
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java b892b84
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java 0996231
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0942ac3
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 07c1957
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java cfe7b2b
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 0da7eae
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java 4aeb4e6
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 3f3e67f
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPDivide.java 659d65f
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java 4c2e722
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java 2a301bc
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMinus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPlus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java PRE-CREATION
ql/src/test/results/clientnegative/invalid_arithmetic_type.q.out c4e93ac
ql/src/test/results/clientnegative/udf_assert_true2.q.out 699c4f3
ql/src/test/results/clientpositive/auto_join13.q.out 95a4f13
ql/src/test/results/clientpositive/auto_join2.q.out 1651f0d
ql/src/test/results/clientpositive/bucketmapjoin_negative3.q.out e55f429
ql/src/test/results/clientpositive/decimal_6.q.out 043321f
ql/src/test/results/clientpositive/decimal_udf.q.out 1bc0db9
ql/src/test/results/clientpositive/input8.q.out 7c036e1
ql/src/test/results/clientpositive/num_op_type_conv.q.out 87feb59
ql/src/test/results/clientpositive/orc_createas1.q.out 3b43e5a
ql/src/test/results/clientpositive/ppd_constant_expr.q.out 9598110
ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out 4463387
ql/src/test/results/clientpositive/rcfile_createas1.q.out 0cbc2d2
ql/src/test/results/clientpositive/rcfile_merge1.q.out 7e7eed5
ql/src/test/results/clientpositive/rcfile_merge2.q.out a108309
ql/src/test/results/clientpositive/skewjoin.q.out c5d57da
ql/src/test/results/clientpositive/udf_pmod.q.out 0c77243
ql/src/test/results/clientpositive/vectorization_15.q.out 717a3cb
ql/src/test/results/clientpositive/vectorization_5.q.out 914a626
ql/src/test/results/clientpositive/vectorization_short_regress.q.out 637a008
ql/src/test/results/clientpositive/vectorized_math_funcs.q.out c684df1
ql/src/test/results/clientpositive/windowing_expressions.q.out ce3d943
ql/src/test/results/compiler/plan/cast1.q.xml 1d31be1
ql/src/test/results/compiler/plan/input20.q.xml 346ed48
ql/src/test/results/compiler/plan/input8.q.xml 5c07a5c
ql/src/test/results/compiler/plan/join2.q.xml c769ea3
ql/src/test/results/compiler/plan/sample1.q.xml 77aec1c
ql/src/test/results/compiler/plan/sample2.q.xml 8f5e16f
ql/src/test/results/compiler/plan/sample3.q.xml cd9a6fb
ql/src/test/results/compiler/plan/sample4.q.xml 8f5e16f
ql/src/test/results/compiler/plan/sample5.q.xml a10b8a5
ql/src/test/results/compiler/plan/sample6.q.xml aaf60b9
ql/src/test/results/compiler/plan/sample7.q.xml a82bbce
ql/src/test/results/compiler/plan/udf4.q.xml 4346478
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java da5416a
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java c19f5aa
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantByteObjectInspector.java 0915562
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveDecimalObjectInspector.java a9ca7bd
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantIntObjectInspector.java 942a178
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantLongObjectInspector.java ad3a063
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantShortObjectInspector.java 6b67dac
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java 420509c
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 2982cf6
Diff: https://reviews.apache.org/r/15113/diff/
Testing
-------
Full set of unit tests is to be run. Old testcases are also migrated.
Thanks,
Xuefu Zhang
Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF
implementations
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15113/
-----------------------------------------------------------
(Updated Nov. 13, 2013, 3:04 p.m.)
Review request for hive.
Bugs: HIVe-5356
https://issues.apache.org/jira/browse/HIVe-5356
Repository: hive-git
Description
-------
Replace plus, minus, and so on 6 old UDFs with generic UDF implementations.
Diffs
-----
common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java e3a1620
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 5eb321c
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 7c1ab0d
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 7838547
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java 1e74fce
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java b892b84
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java 0996231
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0942ac3
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 07c1957
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java cfe7b2b
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 0da7eae
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java 4aeb4e6
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 3f3e67f
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPDivide.java 659d65f
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java 4c2e722
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java 2a301bc
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMinus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPlus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java PRE-CREATION
ql/src/test/results/clientnegative/invalid_arithmetic_type.q.out c4e93ac
ql/src/test/results/clientnegative/udf_assert_true2.q.out 699c4f3
ql/src/test/results/clientpositive/auto_join13.q.out 95a4f13
ql/src/test/results/clientpositive/auto_join2.q.out 1651f0d
ql/src/test/results/clientpositive/bucketmapjoin_negative3.q.out e55f429
ql/src/test/results/clientpositive/decimal_6.q.out 043321f
ql/src/test/results/clientpositive/decimal_udf.q.out 1bc0db9
ql/src/test/results/clientpositive/input8.q.out 7c036e1
ql/src/test/results/clientpositive/num_op_type_conv.q.out 87feb59
ql/src/test/results/clientpositive/orc_createas1.q.out 3b43e5a
ql/src/test/results/clientpositive/ppd_constant_expr.q.out 9598110
ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out 4463387
ql/src/test/results/clientpositive/rcfile_createas1.q.out 0cbc2d2
ql/src/test/results/clientpositive/rcfile_merge1.q.out 7e7eed5
ql/src/test/results/clientpositive/rcfile_merge2.q.out a108309
ql/src/test/results/clientpositive/skewjoin.q.out c5d57da
ql/src/test/results/clientpositive/udf_pmod.q.out 0c77243
ql/src/test/results/clientpositive/vectorization_15.q.out 717a3cb
ql/src/test/results/clientpositive/vectorization_5.q.out 914a626
ql/src/test/results/clientpositive/vectorization_short_regress.q.out 637a008
ql/src/test/results/clientpositive/vectorized_math_funcs.q.out c684df1
ql/src/test/results/clientpositive/windowing_expressions.q.out ce3d943
ql/src/test/results/compiler/plan/cast1.q.xml 1d31be1
ql/src/test/results/compiler/plan/input20.q.xml 346ed48
ql/src/test/results/compiler/plan/input8.q.xml 5c07a5c
ql/src/test/results/compiler/plan/join2.q.xml c769ea3
ql/src/test/results/compiler/plan/sample1.q.xml 77aec1c
ql/src/test/results/compiler/plan/sample2.q.xml 8f5e16f
ql/src/test/results/compiler/plan/sample3.q.xml cd9a6fb
ql/src/test/results/compiler/plan/sample4.q.xml 8f5e16f
ql/src/test/results/compiler/plan/sample5.q.xml a10b8a5
ql/src/test/results/compiler/plan/sample6.q.xml aaf60b9
ql/src/test/results/compiler/plan/sample7.q.xml a82bbce
ql/src/test/results/compiler/plan/udf4.q.xml 4346478
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java da5416a
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java c19f5aa
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantByteObjectInspector.java 0915562
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveDecimalObjectInspector.java a9ca7bd
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantIntObjectInspector.java 942a178
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantLongObjectInspector.java ad3a063
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantShortObjectInspector.java 6b67dac
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java 420509c
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 2982cf6
Diff: https://reviews.apache.org/r/15113/diff/
Testing
-------
Full set of unit tests is to be run. Old testcases are also migrated.
Thanks,
Xuefu Zhang
Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF
implementations
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15113/
-----------------------------------------------------------
(Updated Nov. 13, 2013, 3:03 p.m.)
Review request for hive.
Bugs: HIVe-5356
https://issues.apache.org/jira/browse/HIVe-5356
Repository: hive-git
Description
-------
Replace plus, minus, and so on 6 old UDFs with generic UDF implementations.
Diffs (updated)
-----
common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java e3a1620
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 5eb321c
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 7c1ab0d
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 7838547
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java 1e74fce
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java b892b84
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java 0996231
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0942ac3
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 07c1957
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java cfe7b2b
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 0da7eae
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java 4aeb4e6
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 3f3e67f
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPDivide.java 659d65f
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java 4c2e722
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java 2a301bc
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMinus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPlus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java PRE-CREATION
ql/src/test/results/clientnegative/invalid_arithmetic_type.q.out c4e93ac
ql/src/test/results/clientnegative/udf_assert_true2.q.out 699c4f3
ql/src/test/results/clientpositive/auto_join13.q.out 95a4f13
ql/src/test/results/clientpositive/auto_join2.q.out 1651f0d
ql/src/test/results/clientpositive/bucketmapjoin_negative3.q.out e55f429
ql/src/test/results/clientpositive/decimal_6.q.out 043321f
ql/src/test/results/clientpositive/decimal_udf.q.out 1bc0db9
ql/src/test/results/clientpositive/input8.q.out 7c036e1
ql/src/test/results/clientpositive/num_op_type_conv.q.out 87feb59
ql/src/test/results/clientpositive/orc_createas1.q.out 3b43e5a
ql/src/test/results/clientpositive/ppd_constant_expr.q.out 9598110
ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out 4463387
ql/src/test/results/clientpositive/rcfile_createas1.q.out 0cbc2d2
ql/src/test/results/clientpositive/rcfile_merge1.q.out 7e7eed5
ql/src/test/results/clientpositive/rcfile_merge2.q.out a108309
ql/src/test/results/clientpositive/skewjoin.q.out c5d57da
ql/src/test/results/clientpositive/udf_pmod.q.out 0c77243
ql/src/test/results/clientpositive/vectorization_15.q.out 717a3cb
ql/src/test/results/clientpositive/vectorization_5.q.out 914a626
ql/src/test/results/clientpositive/vectorization_short_regress.q.out 637a008
ql/src/test/results/clientpositive/vectorized_math_funcs.q.out c684df1
ql/src/test/results/clientpositive/windowing_expressions.q.out ce3d943
ql/src/test/results/compiler/plan/cast1.q.xml 1d31be1
ql/src/test/results/compiler/plan/input20.q.xml 346ed48
ql/src/test/results/compiler/plan/input8.q.xml 5c07a5c
ql/src/test/results/compiler/plan/join2.q.xml c769ea3
ql/src/test/results/compiler/plan/sample1.q.xml 77aec1c
ql/src/test/results/compiler/plan/sample2.q.xml 8f5e16f
ql/src/test/results/compiler/plan/sample3.q.xml cd9a6fb
ql/src/test/results/compiler/plan/sample4.q.xml 8f5e16f
ql/src/test/results/compiler/plan/sample5.q.xml a10b8a5
ql/src/test/results/compiler/plan/sample6.q.xml aaf60b9
ql/src/test/results/compiler/plan/sample7.q.xml a82bbce
ql/src/test/results/compiler/plan/udf4.q.xml 4346478
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java da5416a
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java c19f5aa
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantByteObjectInspector.java 0915562
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveDecimalObjectInspector.java a9ca7bd
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantIntObjectInspector.java 942a178
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantLongObjectInspector.java ad3a063
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantShortObjectInspector.java 6b67dac
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java 420509c
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 2982cf6
Diff: https://reviews.apache.org/r/15113/diff/
Testing
-------
Full set of unit tests is to be run. Old testcases are also migrated.
Thanks,
Xuefu Zhang
Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF
implementations
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15113/
-----------------------------------------------------------
(Updated Nov. 3, 2013, 7:26 p.m.)
Review request for hive.
Bugs: HIVe-5356
https://issues.apache.org/jira/browse/HIVe-5356
Repository: hive-git
Description
-------
Replace plus, minus, and so on 6 old UDFs with generic UDF implementations.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 898b6a5
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java dd8d7dd
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 47d7995
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java 1e74fce
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java da01934
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java 0996231
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0942ac3
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 07c1957
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java cfe7b2b
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 0da7eae
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java 4aeb4e6
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 1e49a2e
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java 4c2e722
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java 2a301bc
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMinus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPlus.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java PRE-CREATION
ql/src/test/queries/clientpositive/ctas_hadoop20.q 4961b97
ql/src/test/results/clientpositive/ctas_hadoop20.q.out 885e985
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java 22e5ec5
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java c19f5aa
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantByteObjectInspector.java 0915562
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveDecimalObjectInspector.java a9ca7bd
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantIntObjectInspector.java 942a178
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantLongObjectInspector.java ad3a063
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantShortObjectInspector.java 6b67dac
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java 420509c
Diff: https://reviews.apache.org/r/15113/diff/
Testing
-------
Full set of unit tests is to be run. Old testcases are also migrated.
Thanks,
Xuefu Zhang
Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF
implementations
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15113/
-----------------------------------------------------------
(Updated Nov. 2, 2013, 3:43 a.m.)
Review request for hive.
Bugs: HIVe-5356
https://issues.apache.org/jira/browse/HIVe-5356
Repository: hive-git
Description
-------
Replace plus, minus, and so on 6 old UDFs with generic UDF implementations.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 898b6a5
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java dd8d7dd
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 47d7995
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java 1e74fce
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java da01934
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java 0996231
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0942ac3
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 07c1957
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java cfe7b2b
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 0da7eae
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java 4aeb4e6
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 1e49a2e
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java 4c2e722
ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java 2a301bc
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java PRE-CREATION
ql/src/test/queries/clientpositive/ctas_hadoop20.q 4961b97
ql/src/test/results/clientpositive/ctas_hadoop20.q.out 885e985
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java 22e5ec5
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java c19f5aa
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantByteObjectInspector.java 0915562
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveDecimalObjectInspector.java a9ca7bd
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantIntObjectInspector.java 942a178
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantLongObjectInspector.java ad3a063
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantShortObjectInspector.java 6b67dac
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java 420509c
Diff: https://reviews.apache.org/r/15113/diff/
Testing
-------
Full set of unit tests is to be run. Old testcases are also migrated.
Thanks,
Xuefu Zhang
Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF
implementations
Posted by Xuefu Zhang <xz...@cloudera.com>.
On Nov. 1, 2013, 1:45 a.m., Xuefu Zhang wrote:
> > Please also add tests to verify the result TypeInfo of the the arithmetic operations using various different types.
Thanks for the comments, Jason. I think the current patch is just a preview of what will be, as it's under going changes. (I wanted to start up a test run by submitting it.) Let's revisit those as the patch is in it's final form.
- Xuefu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15113/#review27928
-----------------------------------------------------------
On Oct. 31, 2013, 5:43 a.m., Xuefu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15113/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2013, 5:43 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVe-5356
> https://issues.apache.org/jira/browse/HIVe-5356
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Replace plus, minus, and so on 6 old UDFs with generic UDF implementations.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 898b6a5
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 120095a
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java 1e74fce
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java da01934
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java 0996231
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0942ac3
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 07c1957
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java cfe7b2b
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 0da7eae
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java 4aeb4e6
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 90ab983
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java 4c2e722
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java 2a301bc
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/15113/diff/
>
>
> Testing
> -------
>
> Full set of unit tests is to be run. Old testcases are also migrated.
>
>
> Thanks,
>
> Xuefu Zhang
>
>
Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF
implementations
Posted by Jason Dere <jd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15113/#review27928
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java
<https://reviews.apache.org/r/15113/#comment54449>
This early out is incorrect if it's 2 decimal TypeInfos that are the same. decimal(10,2) * decimal(10,2) != decimal(10,2)
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java
<https://reviews.apache.org/r/15113/#comment54450>
I think this logic may also be incorrect - decimal(10,2) * ??? would very likely be a result other than decimal(10,2). I think string here should be equivalent to double.
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java
<https://reviews.apache.org/r/15113/#comment54354>
Should an exception be thrown either here or by the caller?
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java
<https://reviews.apache.org/r/15113/#comment54452>
same as comments about about string type.
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java
<https://reviews.apache.org/r/15113/#comment54446>
I think you are over inspecting here :)
convert() can use the left variable directly, no need to inspect the value of left. Playing with this I got an error when I tried to add the 2 columns from a table. So all of these instances of convert() from all of these UDFs needs to be changed.
Please also add tests to verify the result TypeInfo of the the arithmetic operations using various different types.
- Jason Dere
On Oct. 31, 2013, 5:43 a.m., Xuefu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15113/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2013, 5:43 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVe-5356
> https://issues.apache.org/jira/browse/HIVe-5356
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Replace plus, minus, and so on 6 old UDFs with generic UDF implementations.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 898b6a5
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 120095a
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java 1e74fce
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java da01934
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java 0996231
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0942ac3
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 07c1957
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java cfe7b2b
> ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 0da7eae
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java 4aeb4e6
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 90ab983
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java 4c2e722
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java 2a301bc
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/15113/diff/
>
>
> Testing
> -------
>
> Full set of unit tests is to be run. Old testcases are also migrated.
>
>
> Thanks,
>
> Xuefu Zhang
>
>