[GitHub] [metron] nickwallen commented on a change in pull request #1519: METRON-2265: Update Kerberos settings

[GitBox <gi...@apache.org>]

nickwallen commented on a change in pull request #1519: METRON-2265: Update Kerberos settings
URL: https://github.com/apache/metron/pull/1519#discussion_r327707957
 
 

 ##########
 File path: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/config/KafkaConfig.java
 ##########
 @@ -76,7 +76,7 @@ public KafkaConfig(final Environment environment) {
     props.put(ConsumerConfig.KEY_DESERIALIZER_CLASS_CONFIG, "org.apache.kafka.common.serialization.StringDeserializer");
     props.put(ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG, "org.apache.kafka.common.serialization.StringDeserializer");
     if (environment.getProperty(MetronRestConstants.KERBEROS_ENABLED_SPRING_PROPERTY, Boolean.class, false)) {
-      props.put("security.protocol", KafkaUtils.INSTANCE.normalizeProtocol(environment.getProperty(MetronRestConstants.KAFKA_SECURITY_PROTOCOL_SPRING_PROPERTY)));
+      props.put("security.protocol", SecurityProtocol.SASL_PLAINTEXT.name());
 
 Review comment:
   There are a few other places in the code base that do something similar.  Do we need to update those also?
   * StormCLIWrapper.java:120
   * ParserTopologyBuilder:211
   * SimpleStormKafkaBuilder:209
   * KafkaWriter:222
   
   And if we then no longer need `KafkaUtils.normalizeProtocol`, we should remove that method completely.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services