[GitHub] graceguo-supercat closed pull request #3912: When checking if you should renderTriggered make sure controls[key] exists

[GitBox <gi...@apache.org>]

graceguo-supercat closed pull request #3912: When checking if you should renderTriggered make sure controls[key] exists
URL: https://github.com/apache/incubator-superset/pull/3912
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/assets/javascripts/explore/components/ExploreViewContainer.jsx b/superset/assets/javascripts/explore/components/ExploreViewContainer.jsx
index 43f6c012e6..835cc1a3be 100644
--- a/superset/assets/javascripts/explore/components/ExploreViewContainer.jsx
+++ b/superset/assets/javascripts/explore/components/ExploreViewContainer.jsx
@@ -53,6 +53,7 @@ class ExploreViewContainer extends React.Component {
     }
     // if any control value changed and it's an instant control
     if (Object.keys(np.controls).some(key => (np.controls[key].renderTrigger &&
+      typeof this.props.controls[key] !== 'undefined' &&
       !areObjectsEqual(np.controls[key].value, this.props.controls[key].value)))) {
       this.props.actions.renderTriggered(new Date().getTime(), this.props.chart.chartKey);
     }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services