You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Mirza Aliev (Jira)" <ji...@apache.org> on 2021/08/10 13:26:00 UTC
[jira] [Commented] (IGNITE-15264) DistributedConfigurationStorage
violates MetaStorageManager watch contract
[ https://issues.apache.org/jira/browse/IGNITE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17396681#comment-17396681 ]
Mirza Aliev commented on IGNITE-15264:
--------------------------------------
Hello [~ibessonov]! Changes look good to me!
> DistributedConfigurationStorage violates MetaStorageManager watch contract
> --------------------------------------------------------------------------
>
> Key: IGNITE-15264
> URL: https://issues.apache.org/jira/browse/IGNITE-15264
> Project: Ignite
> Issue Type: Bug
> Affects Versions: 3.0.0-alpha2
> Reporter: Ivan Bessonov
> Assignee: Ivan Bessonov
> Priority: Major
> Labels: iep-55, ignite-3
> Fix For: 3.0.0-alpha3
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> There are a few issues with the {{DistributedConfigurationStorage}} and related classes:
> * {{MetaStorageManager#DISTRIBUTED_PREFIX}} is located in the wrong class;
> * {{MetaStorageManager#APPLIED_REV}} constant should be changed;
> * {{DistributedConfigurationStorage#MASTER_KEY}} is confused with {{APPLIED_REV}} in some places, so {{DistributedConfigurationStorage#readAll}} returns god knows what;
> * watch callback in {{DistributedConfigurationStorage#registerConfigurationListener}} returns from {{onUpdate}} before notifications are processed. {{DistributedConfigurationStorage#notifyApplied}} doesn't work properly as well.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)