You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jonathan Hsieh (Created) (JIRA)" <ji...@apache.org> on 2012/03/16 00:48:39 UTC
[jira] [Created] (HBASE-5588) Deprecate/remove
AssignmentManager#clearRegionFromTransition
Deprecate/remove AssignmentManager#clearRegionFromTransition
------------------------------------------------------------
Key: HBASE-5588
URL: https://issues.apache.org/jira/browse/HBASE-5588
Project: HBase
Issue Type: Sub-task
Affects Versions: 0.92.0, 0.90.5, 0.94.0, 0.96.0
Reporter: Jonathan Hsieh
This method is essentially a dupe of Assignment#regionOffline. As suggested in early review of HBASE-5128 - deprecate up to 0.94 and remove from 0.96/trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5588) Deprecate/remove
AssignmentManager#clearRegionFromTransition
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231343#comment-13231343 ]
Jonathan Hsieh commented on HBASE-5588:
---------------------------------------
I submitted them all together so it seems hadoopqa has gotten confused. I'm running all the test against all the versions currently, will commit if the come back cleanly.
> Deprecate/remove AssignmentManager#clearRegionFromTransition
> ------------------------------------------------------------
>
> Key: HBASE-5588
> URL: https://issues.apache.org/jira/browse/HBASE-5588
> Project: HBase
> Issue Type: Sub-task
> Components: hbck
> Affects Versions: 0.90.5, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-5588-0.90.patch, hbase-5588-0.94.patch, hbase-5588.patch
>
>
> This method is essentially a dupe of Assignment#regionOffline. As suggested in early review of HBASE-5128 - deprecate up to 0.94 and remove from 0.96/trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5588) Deprecate/remove
AssignmentManager#clearRegionFromTransition
Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-5588:
----------------------------------
Attachment: hbase-5588-0.90.patch
hbase-5588-0.94.patch
hbase-5588.patch
hbase-5588.patch removes clearRegionFromTransition
hbase-5588-0.94.patch deprecates and is also applicable to 0.92
hbase-5588-0.90.patch deprecates.
> Deprecate/remove AssignmentManager#clearRegionFromTransition
> ------------------------------------------------------------
>
> Key: HBASE-5588
> URL: https://issues.apache.org/jira/browse/HBASE-5588
> Project: HBase
> Issue Type: Sub-task
> Components: hbck
> Affects Versions: 0.90.5, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-5588-0.90.patch, hbase-5588-0.94.patch, hbase-5588.patch
>
>
> This method is essentially a dupe of Assignment#regionOffline. As suggested in early review of HBASE-5128 - deprecate up to 0.94 and remove from 0.96/trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5588) Deprecate/remove
AssignmentManager#clearRegionFromTransition
Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-5588:
----------------------------------
Status: Patch Available (was: Open)
Suite against the four versions is running.
> Deprecate/remove AssignmentManager#clearRegionFromTransition
> ------------------------------------------------------------
>
> Key: HBASE-5588
> URL: https://issues.apache.org/jira/browse/HBASE-5588
> Project: HBase
> Issue Type: Sub-task
> Components: hbck
> Affects Versions: 0.92.0, 0.90.5, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-5588-0.90.patch, hbase-5588-0.94.patch, hbase-5588.patch
>
>
> This method is essentially a dupe of Assignment#regionOffline. As suggested in early review of HBASE-5128 - deprecate up to 0.94 and remove from 0.96/trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-5588) Deprecate/remove
AssignmentManager#clearRegionFromTransition
Posted by "Jonathan Hsieh (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh reassigned HBASE-5588:
-------------------------------------
Assignee: Jonathan Hsieh
> Deprecate/remove AssignmentManager#clearRegionFromTransition
> ------------------------------------------------------------
>
> Key: HBASE-5588
> URL: https://issues.apache.org/jira/browse/HBASE-5588
> Project: HBase
> Issue Type: Sub-task
> Components: hbck
> Affects Versions: 0.90.5, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
>
> This method is essentially a dupe of Assignment#regionOffline. As suggested in early review of HBASE-5128 - deprecate up to 0.94 and remove from 0.96/trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5588) Deprecate/remove
AssignmentManager#clearRegionFromTransition
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231896#comment-13231896 ]
Hudson commented on HBASE-5588:
-------------------------------
Integrated in HBase-0.94 #39 (See [https://builds.apache.org/job/HBase-0.94/39/])
HBASE-5588 Deprecate/remove AssignmentManager#clearRegionFromTransition (Revision 1301884)
Result = SUCCESS
jmhsieh :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
> Deprecate/remove AssignmentManager#clearRegionFromTransition
> ------------------------------------------------------------
>
> Key: HBASE-5588
> URL: https://issues.apache.org/jira/browse/HBASE-5588
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.90.5, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.90.7, 0.92.2, 0.94.0, 0.96.0
>
> Attachments: hbase-5588-0.90.patch, hbase-5588-0.94.patch, hbase-5588.patch
>
>
> This method is essentially a dupe of Assignment#regionOffline. As suggested in early review of HBASE-5128 - deprecate up to 0.94 and remove from 0.96/trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5588) Deprecate/remove
AssignmentManager#clearRegionFromTransition
Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-5588:
----------------------------------
Issue Type: Improvement (was: Sub-task)
Parent: (was: HBASE-5128)
> Deprecate/remove AssignmentManager#clearRegionFromTransition
> ------------------------------------------------------------
>
> Key: HBASE-5588
> URL: https://issues.apache.org/jira/browse/HBASE-5588
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.90.5, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.90.7, 0.92.2, 0.94.0, 0.96.0
>
> Attachments: hbase-5588-0.90.patch, hbase-5588-0.94.patch, hbase-5588.patch
>
>
> This method is essentially a dupe of Assignment#regionOffline. As suggested in early review of HBASE-5128 - deprecate up to 0.94 and remove from 0.96/trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5588) Deprecate/remove
AssignmentManager#clearRegionFromTransition
Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-5588:
----------------------------------
Resolution: Fixed
Fix Version/s: 0.96.0
0.94.0
0.92.2
0.90.7
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
> Deprecate/remove AssignmentManager#clearRegionFromTransition
> ------------------------------------------------------------
>
> Key: HBASE-5588
> URL: https://issues.apache.org/jira/browse/HBASE-5588
> Project: HBase
> Issue Type: Sub-task
> Components: hbck
> Affects Versions: 0.90.5, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.90.7, 0.92.2, 0.94.0, 0.96.0
>
> Attachments: hbase-5588-0.90.patch, hbase-5588-0.94.patch, hbase-5588.patch
>
>
> This method is essentially a dupe of Assignment#regionOffline. As suggested in early review of HBASE-5128 - deprecate up to 0.94 and remove from 0.96/trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5588) Deprecate/remove
AssignmentManager#clearRegionFromTransition
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231341#comment-13231341 ]
Zhihong Yu commented on HBASE-5588:
-----------------------------------
+1 on patches.
Hopefully Hadoop QA can pick up hbase-5588.patch
> Deprecate/remove AssignmentManager#clearRegionFromTransition
> ------------------------------------------------------------
>
> Key: HBASE-5588
> URL: https://issues.apache.org/jira/browse/HBASE-5588
> Project: HBase
> Issue Type: Sub-task
> Components: hbck
> Affects Versions: 0.90.5, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-5588-0.90.patch, hbase-5588-0.94.patch, hbase-5588.patch
>
>
> This method is essentially a dupe of Assignment#regionOffline. As suggested in early review of HBASE-5128 - deprecate up to 0.94 and remove from 0.96/trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5588) Deprecate/remove
AssignmentManager#clearRegionFromTransition
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231553#comment-13231553 ]
stack commented on HBASE-5588:
------------------------------
+1 on patch set
> Deprecate/remove AssignmentManager#clearRegionFromTransition
> ------------------------------------------------------------
>
> Key: HBASE-5588
> URL: https://issues.apache.org/jira/browse/HBASE-5588
> Project: HBase
> Issue Type: Sub-task
> Components: hbck
> Affects Versions: 0.90.5, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-5588-0.90.patch, hbase-5588-0.94.patch, hbase-5588.patch
>
>
> This method is essentially a dupe of Assignment#regionOffline. As suggested in early review of HBASE-5128 - deprecate up to 0.94 and remove from 0.96/trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5588) Deprecate/remove
AssignmentManager#clearRegionFromTransition
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231883#comment-13231883 ]
Jonathan Hsieh commented on HBASE-5588:
---------------------------------------
Tests came back clean (or tests that failed were run locally and passed). Committed to 0.90/0.92/0.94/0.96. Thanks for reviews stack + ted.
> Deprecate/remove AssignmentManager#clearRegionFromTransition
> ------------------------------------------------------------
>
> Key: HBASE-5588
> URL: https://issues.apache.org/jira/browse/HBASE-5588
> Project: HBase
> Issue Type: Sub-task
> Components: hbck
> Affects Versions: 0.90.5, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.90.7, 0.92.2, 0.94.0, 0.96.0
>
> Attachments: hbase-5588-0.90.patch, hbase-5588-0.94.patch, hbase-5588.patch
>
>
> This method is essentially a dupe of Assignment#regionOffline. As suggested in early review of HBASE-5128 - deprecate up to 0.94 and remove from 0.96/trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5588) Deprecate/remove
AssignmentManager#clearRegionFromTransition
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231339#comment-13231339 ]
Hadoop QA commented on HBASE-5588:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12518692/hbase-5588-0.90.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1205//console
This message is automatically generated.
> Deprecate/remove AssignmentManager#clearRegionFromTransition
> ------------------------------------------------------------
>
> Key: HBASE-5588
> URL: https://issues.apache.org/jira/browse/HBASE-5588
> Project: HBase
> Issue Type: Sub-task
> Components: hbck
> Affects Versions: 0.90.5, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-5588-0.90.patch, hbase-5588-0.94.patch, hbase-5588.patch
>
>
> This method is essentially a dupe of Assignment#regionOffline. As suggested in early review of HBASE-5128 - deprecate up to 0.94 and remove from 0.96/trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5588) Deprecate/remove
AssignmentManager#clearRegionFromTransition
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232185#comment-13232185 ]
Hudson commented on HBASE-5588:
-------------------------------
Integrated in HBase-TRUNK-security #141 (See [https://builds.apache.org/job/HBase-TRUNK-security/141/])
HBASE-5588 Deprecate/remove AssignmentManager#clearRegionFromTransition (Revision 1301885)
Result = FAILURE
jmhsieh :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
> Deprecate/remove AssignmentManager#clearRegionFromTransition
> ------------------------------------------------------------
>
> Key: HBASE-5588
> URL: https://issues.apache.org/jira/browse/HBASE-5588
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.90.5, 0.92.0, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.90.7, 0.92.2, 0.94.0, 0.96.0
>
> Attachments: hbase-5588-0.90.patch, hbase-5588-0.94.patch, hbase-5588.patch
>
>
> This method is essentially a dupe of Assignment#regionOffline. As suggested in early review of HBASE-5128 - deprecate up to 0.94 and remove from 0.96/trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira