You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jakarta.apache.org by se...@apache.org on 2010/06/22 22:14:59 UTC

svn commit: r957008 - in /jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers: RenderAsJSON.java RenderAsXML.java SamplerResultTab.java

Author: sebb
Date: Tue Jun 22 20:14:58 2010
New Revision: 957008

URL: http://svn.apache.org/viewvc?rev=957008&view=rev
Log:
StringBuffer => StringBuilder

Modified:
    jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsJSON.java
    jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsXML.java
    jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/SamplerResultTab.java

Modified: jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsJSON.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsJSON.java?rev=957008&r1=957007&r2=957008&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsJSON.java (original)
+++ jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsJSON.java Tue Jun 22 20:14:58 2010
@@ -56,10 +56,10 @@ public class RenderAsJSON extends Sample
     // It might be useful also to make this available in the 'Request' tab, for
     // when posting JSON.
     private static String prettyJSON(String json) {
-        StringBuffer pretty = new StringBuffer(json.length() * 2); // Educated guess
+        StringBuilder pretty = new StringBuilder(json.length() * 2); // Educated guess
 
         final String tab = ":   "; // $NON-NLS-1$
-        StringBuffer index = new StringBuffer();
+        StringBuilder index = new StringBuilder();
         String nl = ""; // $NON-NLS-1$
 
         Matcher valueOrPair = VALUE_OR_PAIR_PATTERN.matcher(json);

Modified: jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsXML.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsXML.java?rev=957008&r1=957007&r2=957008&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsXML.java (original)
+++ jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsXML.java Tue Jun 22 20:14:58 2010
@@ -172,7 +172,7 @@ public class RenderAsXML extends Sampler
              * @return
              */
             private String getHTML(String str, String separator, int maxChar) {
-                StringBuffer strBuf = new StringBuffer("<html><body bgcolor=\"yellow\"><b>"); // $NON-NLS-1$
+                StringBuilder strBuf = new StringBuilder("<html><body bgcolor=\"yellow\"><b>"); // $NON-NLS-1$
                 char[] chars = str.toCharArray();
                 for (int i = 0; i < chars.length; i++) {
 

Modified: jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/SamplerResultTab.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/SamplerResultTab.java?rev=957008&r1=957007&r2=957008&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/SamplerResultTab.java (original)
+++ jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/SamplerResultTab.java Tue Jun 22 20:14:58 2010
@@ -125,7 +125,7 @@ public abstract class SamplerResultTab i
                 if (sd != null) {
                     String rh = sampleResult.getRequestHeaders();
                     if (rh != null) {
-                        StringBuffer sb = new StringBuffer(sd.length() + rh.length() + 20);
+                        StringBuilder sb = new StringBuilder(sd.length() + rh.length() + 20);
                         sb.append(sd);
                         sb.append("\n"); //$NON-NLS-1$
                         sb.append(JMeterUtils.getResString("view_results_request_headers")); //$NON-NLS-1$
@@ -136,7 +136,7 @@ public abstract class SamplerResultTab i
                     sampleDataField.setText(sd);
                 }
 
-                StringBuffer statsBuff = new StringBuffer(200);
+                StringBuilder statsBuff = new StringBuilder(200);
                 statsBuff.append(JMeterUtils.getResString("view_results_thread_name")).append(sampleResult.getThreadName()).append(NL); //$NON-NLS-1$
                 String startTime = dateFormat.format(new Date(sampleResult.getStartTime()));
                 statsBuff.append(JMeterUtils.getResString("view_results_sample_start")).append(startTime).append(NL); //$NON-NLS-1$
@@ -146,7 +146,7 @@ public abstract class SamplerResultTab i
                 statsBuff.append(JMeterUtils.getResString("view_results_sample_count")).append(sampleResult.getSampleCount()).append(NL); //$NON-NLS-1$
                 statsBuff.append(JMeterUtils.getResString("view_results_error_count")).append(sampleResult.getErrorCount()).append(NL); //$NON-NLS-1$
                 statsDoc.insertString(statsDoc.getLength(), statsBuff.toString(), null);
-                statsBuff = new StringBuffer(); // reset for reuse
+                statsBuff.setLength(0); // reset for reuse
 
                 String responseCode = sampleResult.getResponseCode();
 
@@ -174,7 +174,7 @@ public abstract class SamplerResultTab i
 
                 statsBuff.append(JMeterUtils.getResString("view_results_response_code")).append(responseCode).append(NL); //$NON-NLS-1$
                 statsDoc.insertString(statsDoc.getLength(), statsBuff.toString(), style);
-                statsBuff = new StringBuffer(100); // reset for reuse
+                statsBuff.setLength(0); // reset for reuse
 
                 // response message label
                 String responseMsgStr = sampleResult.getResponseMessage();
@@ -203,12 +203,11 @@ public abstract class SamplerResultTab i
                 // We are displaying an AssertionResult
                 setupTabPaneForAssertionResult();
 
-                StringBuffer statsBuff = new StringBuffer(100);
+                StringBuilder statsBuff = new StringBuilder(100);
                 statsBuff.append(JMeterUtils.getResString("view_results_assertion_error")).append(assertionResult.isError()).append(NL); //$NON-NLS-1$
                 statsBuff.append(JMeterUtils.getResString("view_results_assertion_failure")).append(assertionResult.isFailure()).append(NL); //$NON-NLS-1$
                 statsBuff.append(JMeterUtils.getResString("view_results_assertion_failure_message")).append(assertionResult.getFailureMessage()).append(NL); //$NON-NLS-1$
                 statsDoc.insertString(statsDoc.getLength(), statsBuff.toString(), null);
-                statsBuff = null;
             }
         } catch (BadLocationException exc) {
             stats.setText(exc.getLocalizedMessage());



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org