You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Allen Wittenauer (JIRA)" <ji...@apache.org> on 2011/05/11 23:33:47 UTC
[jira] [Created] (MAPREDUCE-2484) divideAndCeil should not use
LOG.info or have a more meaningful message
divideAndCeil should not use LOG.info or have a more meaningful message
-----------------------------------------------------------------------
Key: MAPREDUCE-2484
URL: https://issues.apache.org/jira/browse/MAPREDUCE-2484
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: contrib/capacity-sched
Affects Versions: 0.20.203.0
Reporter: Allen Wittenauer
Priority: Trivial
divideAndCeil has
{code}
LOG.info("divideAndCeil called with a=" + a + " b=" + b);
{code}
which should either be a debug message or something more meaningful if it really needs to be LOG.info.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2484) divideAndCeil should not use
LOG.info or have a more meaningful message
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058886#comment-13058886 ]
Jakob Homan commented on MAPREDUCE-2484:
----------------------------------------
This patch came from a hackathon I helped out in Berlin. I missed it when I got back; sorry about that. I'm fine with removing the line entirely. It smells like a debugging-through-printf line that should have been removed. +1.
> divideAndCeil should not use LOG.info or have a more meaningful message
> -----------------------------------------------------------------------
>
> Key: MAPREDUCE-2484
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2484
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/capacity-sched
> Affects Versions: 0.20.203.0
> Reporter: Allen Wittenauer
> Priority: Trivial
> Attachments: 0001-removed-the-LOG.info-statement.patch, 0001-removed-the-LOG.info-statement_SVN.patch
>
>
> divideAndCeil has
> {code}
> LOG.info("divideAndCeil called with a=" + a + " b=" + b);
> {code}
> which should either be a debug message or something more meaningful if it really needs to be LOG.info.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2484) divideAndCeil should not use
LOG.info or have a more meaningful message
Posted by "Harsh J (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-2484:
-------------------------------
Resolution: Not A Problem
Status: Resolved (was: Patch Available)
This isn't a problem, nor does the statement exist in 0.23+.
> divideAndCeil should not use LOG.info or have a more meaningful message
> -----------------------------------------------------------------------
>
> Key: MAPREDUCE-2484
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2484
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/capacity-sched
> Affects Versions: 0.20.203.0
> Reporter: Allen Wittenauer
> Assignee: Stefan Hübner
> Priority: Trivial
> Attachments: 0001-removed-the-LOG.info-statement.patch, 0001-removed-the-LOG.info-statement_SVN.patch
>
>
> divideAndCeil has
> {code}
> LOG.info("divideAndCeil called with a=" + a + " b=" + b);
> {code}
> which should either be a debug message or something more meaningful if it really needs to be LOG.info.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2484) divideAndCeil should not use
LOG.info or have a more meaningful message
Posted by "Stefan Hübner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Hübner updated MAPREDUCE-2484:
-------------------------------------
Status: Patch Available (was: Open)
> divideAndCeil should not use LOG.info or have a more meaningful message
> -----------------------------------------------------------------------
>
> Key: MAPREDUCE-2484
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2484
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/capacity-sched
> Affects Versions: 0.20.203.0
> Reporter: Allen Wittenauer
> Priority: Trivial
> Attachments: 0001-removed-the-LOG.info-statement.patch
>
>
> divideAndCeil has
> {code}
> LOG.info("divideAndCeil called with a=" + a + " b=" + b);
> {code}
> which should either be a debug message or something more meaningful if it really needs to be LOG.info.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2484) divideAndCeil should not use
LOG.info or have a more meaningful message
Posted by "Stefan Hübner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Hübner updated MAPREDUCE-2484:
-------------------------------------
Attachment: 0001-removed-the-LOG.info-statement.patch
The patch removes the LOG statement.
> divideAndCeil should not use LOG.info or have a more meaningful message
> -----------------------------------------------------------------------
>
> Key: MAPREDUCE-2484
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2484
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/capacity-sched
> Affects Versions: 0.20.203.0
> Reporter: Allen Wittenauer
> Priority: Trivial
> Attachments: 0001-removed-the-LOG.info-statement.patch
>
>
> divideAndCeil has
> {code}
> LOG.info("divideAndCeil called with a=" + a + " b=" + b);
> {code}
> which should either be a debug message or something more meaningful if it really needs to be LOG.info.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2484) divideAndCeil should not use
LOG.info or have a more meaningful message
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058775#comment-13058775 ]
Harsh J commented on MAPREDUCE-2484:
------------------------------------
Stefan,
Could you instead make the LOG.info into a LOG.debug with a debug condition check block (like how other LOG.debugs are done)?
> divideAndCeil should not use LOG.info or have a more meaningful message
> -----------------------------------------------------------------------
>
> Key: MAPREDUCE-2484
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2484
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/capacity-sched
> Affects Versions: 0.20.203.0
> Reporter: Allen Wittenauer
> Priority: Trivial
> Attachments: 0001-removed-the-LOG.info-statement.patch, 0001-removed-the-LOG.info-statement_SVN.patch
>
>
> divideAndCeil has
> {code}
> LOG.info("divideAndCeil called with a=" + a + " b=" + b);
> {code}
> which should either be a debug message or something more meaningful if it really needs to be LOG.info.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2484) divideAndCeil should not use
LOG.info or have a more meaningful message
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097005#comment-13097005 ]
Harsh J commented on MAPREDUCE-2484:
------------------------------------
I believe not, I think it was more of a code-read discovery.
> divideAndCeil should not use LOG.info or have a more meaningful message
> -----------------------------------------------------------------------
>
> Key: MAPREDUCE-2484
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2484
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/capacity-sched
> Affects Versions: 0.20.203.0
> Reporter: Allen Wittenauer
> Assignee: Stefan Hübner
> Priority: Trivial
> Attachments: 0001-removed-the-LOG.info-statement.patch, 0001-removed-the-LOG.info-statement_SVN.patch
>
>
> divideAndCeil has
> {code}
> LOG.info("divideAndCeil called with a=" + a + " b=" + b);
> {code}
> which should either be a debug message or something more meaningful if it really needs to be LOG.info.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2484) divideAndCeil should not use
LOG.info or have a more meaningful message
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096999#comment-13096999 ]
Chris Douglas commented on MAPREDUCE-2484:
------------------------------------------
The log message should never appear. The message is more of an assert.
Has this been seen?
> divideAndCeil should not use LOG.info or have a more meaningful message
> -----------------------------------------------------------------------
>
> Key: MAPREDUCE-2484
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2484
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/capacity-sched
> Affects Versions: 0.20.203.0
> Reporter: Allen Wittenauer
> Assignee: Stefan Hübner
> Priority: Trivial
> Attachments: 0001-removed-the-LOG.info-statement.patch, 0001-removed-the-LOG.info-statement_SVN.patch
>
>
> divideAndCeil has
> {code}
> LOG.info("divideAndCeil called with a=" + a + " b=" + b);
> {code}
> which should either be a debug message or something more meaningful if it really needs to be LOG.info.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (MAPREDUCE-2484) divideAndCeil should not use
LOG.info or have a more meaningful message
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan reassigned MAPREDUCE-2484:
--------------------------------------
Assignee: Stefan Hübner
> divideAndCeil should not use LOG.info or have a more meaningful message
> -----------------------------------------------------------------------
>
> Key: MAPREDUCE-2484
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2484
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/capacity-sched
> Affects Versions: 0.20.203.0
> Reporter: Allen Wittenauer
> Assignee: Stefan Hübner
> Priority: Trivial
> Attachments: 0001-removed-the-LOG.info-statement.patch, 0001-removed-the-LOG.info-statement_SVN.patch
>
>
> divideAndCeil has
> {code}
> LOG.info("divideAndCeil called with a=" + a + " b=" + b);
> {code}
> which should either be a debug message or something more meaningful if it really needs to be LOG.info.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2484) divideAndCeil should not use
LOG.info or have a more meaningful message
Posted by "Stefan Hübner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Hübner updated MAPREDUCE-2484:
-------------------------------------
Attachment: 0001-removed-the-LOG.info-statement_SVN.patch
reformatting patch to work with SVN
> divideAndCeil should not use LOG.info or have a more meaningful message
> -----------------------------------------------------------------------
>
> Key: MAPREDUCE-2484
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2484
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/capacity-sched
> Affects Versions: 0.20.203.0
> Reporter: Allen Wittenauer
> Priority: Trivial
> Attachments: 0001-removed-the-LOG.info-statement.patch, 0001-removed-the-LOG.info-statement_SVN.patch
>
>
> divideAndCeil has
> {code}
> LOG.info("divideAndCeil called with a=" + a + " b=" + b);
> {code}
> which should either be a debug message or something more meaningful if it really needs to be LOG.info.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2484) divideAndCeil should not use
LOG.info or have a more meaningful message
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047086#comment-13047086 ]
Hadoop QA commented on MAPREDUCE-2484:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12482024/0001-removed-the-LOG.info-statement_SVN.patch
against trunk revision 1134180.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.cli.TestMRCLI
org.apache.hadoop.fs.TestFileSystem
org.apache.hadoop.mapred.TestNodeRefresh
-1 contrib tests. The patch failed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/373//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/373//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/373//console
This message is automatically generated.
> divideAndCeil should not use LOG.info or have a more meaningful message
> -----------------------------------------------------------------------
>
> Key: MAPREDUCE-2484
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2484
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/capacity-sched
> Affects Versions: 0.20.203.0
> Reporter: Allen Wittenauer
> Priority: Trivial
> Attachments: 0001-removed-the-LOG.info-statement.patch, 0001-removed-the-LOG.info-statement_SVN.patch
>
>
> divideAndCeil has
> {code}
> LOG.info("divideAndCeil called with a=" + a + " b=" + b);
> {code}
> which should either be a debug message or something more meaningful if it really needs to be LOG.info.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2484) divideAndCeil should not use
LOG.info or have a more meaningful message
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046591#comment-13046591 ]
Hadoop QA commented on MAPREDUCE-2484:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12481938/0001-removed-the-LOG.info-statement.patch
against trunk revision 1133226.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/370//console
This message is automatically generated.
> divideAndCeil should not use LOG.info or have a more meaningful message
> -----------------------------------------------------------------------
>
> Key: MAPREDUCE-2484
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2484
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/capacity-sched
> Affects Versions: 0.20.203.0
> Reporter: Allen Wittenauer
> Priority: Trivial
> Attachments: 0001-removed-the-LOG.info-statement.patch
>
>
> divideAndCeil has
> {code}
> LOG.info("divideAndCeil called with a=" + a + " b=" + b);
> {code}
> which should either be a debug message or something more meaningful if it really needs to be LOG.info.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira