[GitHub] zeppelin pull request #3052: [ZEPPELIN-3080] Removing duplicate Date header

[sjoerdmulder <gi...@git.apache.org>]

GitHub user sjoerdmulder opened a pull request:

    https://github.com/apache/zeppelin/pull/3052

    [ZEPPELIN-3080] Removing duplicate Date header

    ### What is this PR for?
    Removing the duplicate Date header that is also in the wrong format according to the RFC, currently every request contains the following headers (using `curl -I`)
    ```
    HTTP/1.1 200 OK
    Date: Monday, November 27, 2017 3:20:42 PM UTC
    Access-Control-Allow-Credentials: true
    Access-Control-Allow-Headers: authorization,Content-Type
    Access-Control-Allow-Methods: POST, GET, OPTIONS, PUT, HEAD, DELETE
    X-FRAME-OPTIONS: SAMEORIGIN
    X-XSS-Protection: 1
    Content-Type: application/octet-stream
    Date: Mon, 27 Nov 2017 15:20:42 GMT
    Content-Length: 59
    Server: Jetty(9.2.15.v20160210)
    ```
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    [ZEPPELIN-3080](https://issues.apache.org/jira/browse/ZEPPELIN-3080)
    
    ### Questions:
    * Does the licenses files need update?
    Nope
    * Is there breaking changes for older versions?
    Nope
    * Does this needs documentation?
    Nope


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sjoerdmulder/zeppelin patch-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/3052.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3052
    
----
commit 1ebd1ad71c49790d8c8d25f63df52d2f709ad02d
Author: Sjoerd Mulder <sj...@...>
Date:   2017-11-27T15:25:25Z

    Removing duplicate Date header

----


---

[GitHub] zeppelin issue #3052: [ZEPPELIN-3080] Removing duplicate Date header

[Leemoonsoo <gi...@git.apache.org>]

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/3052
  
    LGTM


---

[GitHub] zeppelin pull request #3052: [ZEPPELIN-3080] Removing duplicate Date header

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/3052


---

[GitHub] zeppelin issue #3052: [ZEPPELIN-3080] Removing duplicate Date header

[sjoerdmulder <gi...@git.apache.org>]

Github user sjoerdmulder commented on the issue:

    https://github.com/apache/zeppelin/pull/3052
  
    I figured it out because we have a server side process (Spray client) doing health-checks and giving warnings about it:
    ```
    Illegal response header: Illegal 'Date' header: Invalid input 'r', expected ", " or ' ' (line 1, pos 4):
    Thursday, July 5, 2018 7:50:52 AM UTC
       ^
    ```


---

[GitHub] zeppelin issue #3052: [ZEPPELIN-3080] Removing duplicate Date header

[sjoerdmulder <gi...@git.apache.org>]

Github user sjoerdmulder commented on the issue:

    https://github.com/apache/zeppelin/pull/3052
  
    @felixcheung finally got the build working :) 


---

[GitHub] zeppelin issue #3052: [ZEPPELIN-3080] Removing duplicate Date header

[jongyoul <gi...@git.apache.org>]

Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/3052
  
    LGTM. BTW, is there any issue for the front side?


---