You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/14 05:23:23 UTC
[GitHub] [airflow] kushsharma opened a new pull request #20282: Fix slow DAG deletion due to missing dag_id index for job table
kushsharma opened a new pull request #20282:
URL: https://github.com/apache/airflow/pull/20282
Fixes https://github.com/apache/airflow/issues/20249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kushsharma commented on pull request #20282: Fix slow DAG deletion due to missing dag_id index for job table
Posted by GitBox <gi...@apache.org>.
kushsharma commented on pull request #20282:
URL: https://github.com/apache/airflow/pull/20282#issuecomment-993307719
@uranusjr can you check what version I should use in the migration docs(I am not sure about it)? I am just using 2.3.0 for now as one of the tests requires me to update that file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20282: Fix slow DAG deletion due to missing dag_id index for job table
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20282:
URL: https://github.com/apache/airflow/pull/20282#issuecomment-993504695
Static checks need fixing and I think this change uses an old migration head (some change likely implemented hen you branched off?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20282: Fix slow DAG deletion due to missing dag_id index for job table
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20282:
URL: https://github.com/apache/airflow/pull/20282#issuecomment-993183920
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #20282: Fix slow DAG deletion due to missing dag_id index for job table
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #20282:
URL: https://github.com/apache/airflow/pull/20282#issuecomment-994582398
2.3.0 should work. But yeah you should change the `down_version` and the corresponding column in migration-ref to `786e3737b18f` instead. And fix the static check failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #20282: Fix slow DAG deletion due to missing dag_id index for job table
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #20282:
URL: https://github.com/apache/airflow/pull/20282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org