You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/06/10 13:12:19 UTC

[GitHub] [incubator-druid] leventov opened a new issue #7858: Turn ImmutableDruidDataSource into a data container

leventov opened a new issue #7858: Turn ImmutableDruidDataSource into a data container
URL: https://github.com/apache/incubator-druid/issues/7858
 
 
   `ImmutableDruidDataSource`'s `equals()` and `hashCode()` should throw `UnsupportedOperationException` as well as `DruidDataSource`'s methods do. `ImmutableDruidDataSource` should be considered a *container, not a data class*.
   
   The idea is the same as behind prohibiting/limiting `equals()` (and therefore usage as `HashSet`/`HashMap` keys) of `DataSegment`: see #6358. When somebody wants to deduplicate `ImmutableDruidDataSource` objects, they would need to put them into a `Map<String, ImmutableDruidDataSource>` and resolve conflicts by name manually.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org