You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by merrimanr <gi...@git.apache.org> on 2017/09/28 16:24:01 UTC
[GitHub] metron pull request #778: METRON-1208: MPack for Alerts UI
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/778
METRON-1208: MPack for Alerts UI
## Contributor Comments
The PR completes the MPack for Alerts UI. This can be verified in full dev by spinning up full dev and navigating to the Alerts UI through the Metron Quick Links in Ambari. The Alerts UI should be accessible (user/password) and function normally. You should also be able to start/stop/restart the Alerts UI through Ambari. Also, any changes to REST or Alerts UI config should prompt an Alerts UI restart in Ambari.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merrimanr/incubator-metron METRON-1208
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/778.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #778
----
commit a8437e86ac36806cc9b4ed2c031509af13ba478a
Author: merrimanr <me...@gmail.com>
Date: 2017-09-26T21:17:33Z
initial commit
commit 88e77f08d4fc4c096fb1081af813dd11b8d7f07b
Author: merrimanr <me...@gmail.com>
Date: 2017-09-26T21:33:31Z
initial commit
commit 6bc1809d855c4345fc0825c52e15772590bc2167
Author: merrimanr <me...@gmail.com>
Date: 2017-09-26T21:35:05Z
initial commit
commit cc2a8cd63a76e49c4c66b804f66b13a1cf965603
Author: merrimanr <me...@gmail.com>
Date: 2017-09-28T16:00:17Z
Merge remote-tracking branch 'mirror/master' into METRON-1208
commit c4c9aeccc11f97347c539e0e81fb92fb7645ea2d
Author: merrimanr <me...@gmail.com>
Date: 2017-09-28T16:20:34Z
removed commented code
----
---
[GitHub] metron issue #778: METRON-1208: MPack for Alerts UI
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/778
looks good, nice clean couple of PR's on this. Great job
---
[GitHub] metron issue #778: METRON-1208: MPack for Alerts UI
Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/778
No problem. Just added a commit that mentions the MPack in the README. Let me know if that works.
---
[GitHub] metron pull request #778: METRON-1208: MPack for Alerts UI
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/778
---
[GitHub] metron issue #778: METRON-1208: MPack for Alerts UI
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/778
@merrimanr, I think you should update the alerts-ui readme to reflect the installation.
I'm still +1 so you don't have to wait after you do that though
---
[GitHub] metron issue #778: METRON-1208: MPack for Alerts UI
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/778
+1 on review. Ran up in full dev, started normally, data in the ui. Also able to stop and start.
Nice work
---