[GitHub] incubator-eagle pull request: EAGLE-81 Notification Plugin Framewo...

[yonzhang <gi...@git.apache.org>]

Github user yonzhang commented on the pull request:

    https://github.com/apache/incubator-eagle/pull/77#issuecomment-178293138
  
    Multiple issues:
    1. Config object should be injected when topology is started from driver program. In AlertNotificationExecutor prepareConfig, we should save Config object and use that when this bolt is running
    2. In AlertDefinitionAPIEntity, we still can see "notificationType" as one of tags (although it does not generate any real impact, we should keep it consistent)
    
    for " Policy evaluation and notification are possibly in different physical machines ", I did not mean we should do sync up, but we should be aware that listOfNotifications may be null  because policy is deleted
                Set<String> listOfNotifications = policyNotificationMapping.get(entity.getTags().get(Constants.POLICY_ID));
    
    Also, how do I verify the plugin features? Do you have unit test or sample to trigger a notification plugin? Or I have to run an end-2-end program to verify plugin?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---