[GitHub] [spark] ulysses-you commented on a diff in pull request #30481: [SPARK-33526][SQL] Add config to control if cancel invoke interrupt task on thriftserver

["ulysses-you (via GitHub)" <gi...@apache.org>]

ulysses-you commented on code in PR #30481:
URL: https://github.com/apache/spark/pull/30481#discussion_r1184464259


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -926,13 +926,23 @@ object SQLConf {
       .booleanConf
       .createWithDefault(false)
 
+  val THRIFTSERVER_FORCE_CANCEL =
+    buildConf("spark.sql.thriftServer.interruptOnCancel")
+      .doc("When true, all running tasks will be interrupted if one cancels a query. " +
+        "When false, all running tasks will remain until finished.")
+      .version("3.2.0")
+      .booleanConf
+      .createWithDefault(false)

Review Comment:
   I'm fine to enable it by default. In fact, we have enabled it internally and have not seen any issue.  @HyukjinKwon what do you think ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org