You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/24 08:14:09 UTC
[GitHub] [shardingsphere] KoxAlen opened a new issue #5304: Call ComplexShardingStrategies even if no sharding conditions are present
KoxAlen opened a new issue #5304:
URL: https://github.com/apache/shardingsphere/issues/5304
## Feature Request
It would be good if ComplexShardingStrategies were able to decide the default behavior when no sharding conditions are present instead of defaulting to all shards.
We have a use case where we needed a mix of InlineShardingStrategy and HintShardingStrategy.
We were able to emulate it easily with a ComplexShardingStrategy but we needed it to also apply to queries without sharding columns.
I also think it makes a lot of sense from a design perspective that the ComplexShardingStrategy can decide its default behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kimmking commented on issue #5304: Call ComplexShardingStrategies even if no sharding conditions are present
Posted by GitBox <gi...@apache.org>.
kimmking commented on issue #5304:
URL: https://github.com/apache/shardingsphere/issues/5304#issuecomment-618883659
Hi, kox,
I guess you can put the default behavior into your custom ComplexShardingStrategy implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kimmking commented on issue #5304: Call ComplexShardingStrategies even if no sharding conditions are present
Posted by GitBox <gi...@apache.org>.
kimmking commented on issue #5304:
URL: https://github.com/apache/shardingsphere/issues/5304#issuecomment-618926909
It means that the current default strategy is to broadcast to all nodes, and you suggest users should config the defaut strategy instead of it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] KoxAlen commented on issue #5304: Call ComplexShardingStrategies even if no sharding conditions are present
Posted by GitBox <gi...@apache.org>.
KoxAlen commented on issue #5304:
URL: https://github.com/apache/shardingsphere/issues/5304#issuecomment-618886810
Sorry, maybe my message wasn't clear, I'll add an edit.
The problem is that currently the ComplexShardingStrategy is **not** called if there aren't any sharding condition in the query so I can't use it to decide the behavior of queries like "SELECT * FROM sharded". The Feature request is about allowing (at least) ComplexShardingStrategy to inflience those kind of queries
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] KoxAlen commented on issue #5304: Call ComplexShardingStrategies even if no sharding conditions are present
Posted by GitBox <gi...@apache.org>.
KoxAlen commented on issue #5304:
URL: https://github.com/apache/shardingsphere/issues/5304#issuecomment-619798208
Yes, the feature request is about being able to decide which nodes a query should hit if it doesn't have any sharding condition instead of always going to all nodes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] KoxAlen edited a comment on issue #5304: Call ComplexShardingStrategies even if no sharding conditions are present
Posted by GitBox <gi...@apache.org>.
KoxAlen edited a comment on issue #5304:
URL: https://github.com/apache/shardingsphere/issues/5304#issuecomment-618886810
Sorry, maybe my message wasn't clear, I'll add an edit.
The problem is that currently the ComplexShardingStrategy is **not** called if there aren't any sharding condition in the query so I can't use it to decide the behavior of queries like "SELECT * FROM sharded". The Feature request is about allowing (at least) ComplexShardingStrategy to influence those kind of queries
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #5304: Call ComplexShardingStrategies even if no sharding conditions are present
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #5304:
URL: https://github.com/apache/shardingsphere/issues/5304#issuecomment-643221726
Closed because of nobody interested about this issue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kimmking commented on issue #5304: Call ComplexShardingStrategies even if no sharding conditions are present
Posted by GitBox <gi...@apache.org>.
kimmking commented on issue #5304:
URL: https://github.com/apache/shardingsphere/issues/5304#issuecomment-619843641
Can you make a pr for it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu closed issue #5304: Call ComplexShardingStrategies even if no sharding conditions are present
Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #5304:
URL: https://github.com/apache/shardingsphere/issues/5304
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org