You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2023/01/02 14:42:32 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request, #7038: UI: user must specify the start of guest vlan range for advanced zone
weizhouapache opened a new pull request, #7038:
URL: https://github.com/apache/cloudstack/pull/7038
### Description
This PR fixes #6727
The start of guest vlan range is a must.
if end is not set, the vlan range is start-start
otherwise, the vlan range is start-end
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
Start and end are not set.
![image](https://user-images.githubusercontent.com/57355700/210246113-b7017385-7154-49be-8d86-7f08e51e8208.png)
Start is set
![image](https://user-images.githubusercontent.com/57355700/210246169-c11e6ba9-c61b-43a6-a892-e75991d5edcc.png)
wrong range
![image](https://user-images.githubusercontent.com/57355700/210246216-e05d558f-1dfc-48cf-a1a3-9e10847af89c.png)
correct range
![image](https://user-images.githubusercontent.com/57355700/210246244-25b0ef9d-434f-4fd6-8628-6c341dfd936f.png)
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7038: UI: user must specify the start of guest vlan range for advanced zone
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #7038:
URL: https://github.com/apache/cloudstack/pull/7038#issuecomment-1369077390
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7038](https://codecov.io/gh/apache/cloudstack/pull/7038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d8cdbde) into [4.17](https://codecov.io/gh/apache/cloudstack/commit/d5f010054169b29a2e20fc3d3ddba5c22959e2c2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d5f0100) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 4.17 #7038 +/- ##
=========================================
Coverage 10.36% 10.36%
- Complexity 6630 6631 +1
=========================================
Files 2453 2453
Lines 242386 242386
Branches 37928 37928
=========================================
+ Hits 25120 25129 +9
+ Misses 214158 214148 -10
- Partials 3108 3109 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/cloudstack/quota/QuotaStatementImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZnJhbWV3b3JrL3F1b3RhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3F1b3RhL1F1b3RhU3RhdGVtZW50SW1wbC5qYXZh) | `40.26% <0.00%> (+3.98%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7038: UI: user must specify the start of guest vlan range for advanced zone
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7038:
URL: https://github.com/apache/cloudstack/pull/7038#issuecomment-1369577888
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #7038: UI: user must specify the start of guest vlan range for advanced zone
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged PR #7038:
URL: https://github.com/apache/cloudstack/pull/7038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7038: UI: user must specify the start of guest vlan range for advanced zone
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7038:
URL: https://github.com/apache/cloudstack/pull/7038#issuecomment-1369584122
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7038 (QA-JID-24)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7038: UI: user must specify the start of guest vlan range for advanced zone
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7038:
URL: https://github.com/apache/cloudstack/pull/7038#issuecomment-1369576790
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org