[GitHub] [incubator-druid] FaxianZhao opened a new pull request #7304: enable lookup module for index_hadoop task

[GitBox <gi...@apache.org>]

FaxianZhao opened a new pull request #7304: enable lookup module for index_hadoop task
URL: https://github.com/apache/incubator-druid/pull/7304
 
 
   Work around fix #5727. 
   
   There are some issues need to declare:
   1. Mapreduce job is out of GuiceRunnable's control, so the lifecycle is not avaliable. I work around solve it in Mapper.setup() function.
   2. Refer the issue 1, I think o.a.d.initialization.Initialization#makeInjectorWithModules is too expensive, it's better to split modules in different scenario. I don't have enough knowledge to do. 
   3. Mapreduce job hasn't upload *.properties to MR classpath, and some lifecycle related modules need them.
   4. o.a.d.initialization.Initialization#makeInjectorWithModules always load extensions from filesystem, and MR job won't upload extensions to work dir. I work around fix it. 
   I think we could declare the impl classes in the configuration. If all of them are loaded from classloader, then ignore the filesystem part.
   5. It seems there are some performance issues, I have no idea yet.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org