[GitHub] access2rohit commented on a change in pull request #14031: Fix transposed convolution in CPU w/o MKLDNN.

[GitBox <gi...@apache.org>]

access2rohit commented on a change in pull request #14031: Fix transposed convolution in CPU w/o MKLDNN.
URL: https://github.com/apache/incubator-mxnet/pull/14031#discussion_r255203272
 
 

 ##########
 File path: src/operator/nn/deconvolution-inl.h
 ##########
 @@ -251,76 +254,57 @@ class DeconvolutionOp {
                param_.num_filter / param_.num_group * kernel_size);
     Tensor<xpu, 3, DType> wmat =
         in_data[deconv::kWeight].get_with_shape<xpu, 3, DType>(wmat_shape, s);
-#if defined(__CUDACC__)
-    CHECK_EQ(s->blas_handle_ownership_, Stream<xpu>::OwnHandle)
-        << "Must init CuBLAS handle in stream";
-#endif
     const index_t nbatch = data.size(0);
     Tensor<xpu, 1, DType> workspace =
         ctx.requested[deconv::kTempSpace].get_space_typed<xpu, 1, DType>(
             Shape1(this->InitTemp(out.shape_, data.shape_)), s);
-    for (index_t i = 0; i < nbatch; i += nstep_) {
 
 Review comment:
   Do you know what was "nstep_" doing earlier? It would help understand the problem with the earlier code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services