You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "James McCarthy (JIRA)" <de...@myfaces.apache.org> on 2006/07/07 03:53:29 UTC

[jira] Created: (TOMAHAWK-523) rowStyleClass does not resolve to an EL of var

rowStyleClass does not resolve to an EL of var
----------------------------------------------

         Key: TOMAHAWK-523
         URL: http://issues.apache.org/jira/browse/TOMAHAWK-523
     Project: MyFaces Tomahawk
        Type: Bug

  Components: Extended Datatable  
    Versions: 1.1.4-SNAPSHOT    
 Environment: Tomcat, Facelets
    Reporter: James McCarthy


The rowStyleClass does not resolve when the rowStyleClass references an EL item identified by var. var="item" rowStyleClass="#{item.status}".


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (TOMAHAWK-523) rowStyleClass does not resolve to an EL of var

Posted by "Jason Long (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/TOMAHAWK-523?page=comments#action_12422239 ] 
            
Jason Long commented on TOMAHAWK-523:
-------------------------------------

I am using facelets and have this problem.  I posted messages to both the myfaces users list and the facelets list, but have gotten no response.

Are you using facelets?

Does anyone know the status of this?  I am using the 1.1.4 smapshot as well?

Does it work with older versions?

The app I am porfting is full of dynamic row css.  I need this badlly to continue what I started efficiently.

> rowStyleClass does not resolve to an EL of var
> ----------------------------------------------
>
>                 Key: TOMAHAWK-523
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-523
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.4-SNAPSHOT
>         Environment: Tomcat, Facelets
>            Reporter: James McCarthy
>
> The rowStyleClass does not resolve when the rowStyleClass references an EL item identified by var. var="item" rowStyleClass="#{item.status}".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (TOMAHAWK-523) rowStyleClass does not resolve to an EL of var

Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/TOMAHAWK-523?page=comments#action_12425326 ] 
            
Mike Kienenberger commented on TOMAHAWK-523:
--------------------------------------------

It'll be fixed when someone who needs it badly enough submits a patch :-)  That's the open source way of doing things.

If it's a matter of changing the generic attribute to a Html class specific one, I'll be happy to review and apply such a patch.

> rowStyleClass does not resolve to an EL of var
> ----------------------------------------------
>
>                 Key: TOMAHAWK-523
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-523
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.4-SNAPSHOT
>         Environment: Tomcat, Facelets
>            Reporter: James McCarthy
>
> The rowStyleClass does not resolve when the rowStyleClass references an EL item identified by var. var="item" rowStyleClass="#{item.status}".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (TOMAHAWK-523) rowStyleClass does not resolve to an EL of var

Posted by "Ronald Müller (JIRA)" <de...@myfaces.apache.org>.
     [ http://issues.apache.org/jira/browse/TOMAHAWK-523?page=all ]

Ronald Müller updated TOMAHAWK-523:
-----------------------------------

    Status: Patch Available  (was: Open)

> rowStyleClass does not resolve to an EL of var
> ----------------------------------------------
>
>                 Key: TOMAHAWK-523
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-523
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.4-SNAPSHOT
>         Environment: Tomcat, Facelets
>            Reporter: James McCarthy
>
> The rowStyleClass does not resolve when the rowStyleClass references an EL item identified by var. var="item" rowStyleClass="#{item.status}".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Commented: (TOMAHAWK-523) rowStyleClass does not resolve to an EL of var

Posted by "Nándor Előd Fekete (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TOMAHAWK-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463496 ] 

Nándor Előd Fekete commented on TOMAHAWK-523:
---------------------------------------------

If you use org.apache.myfaces.dataTable.ROW_STYLECLASS instead of the original attribute name (rowStyleClass) it will work. So the problem is definitely with the values of the aforementioned constants in the class org.apache.myfaces.shared_tomahawk.renderkit.JSFAttr.

> rowStyleClass does not resolve to an EL of var
> ----------------------------------------------
>
>                 Key: TOMAHAWK-523
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-523
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.4-SNAPSHOT
>         Environment: Tomcat, Facelets
>            Reporter: James McCarthy
>
> The rowStyleClass does not resolve when the rowStyleClass references an EL item identified by var. var="item" rowStyleClass="#{item.status}".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Commented: (TOMAHAWK-523) rowStyleClass does not resolve to an EL of var

Posted by "Jason Long (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/TOMAHAWK-523?page=comments#action_12425071 ] 
            
Jason Long commented on TOMAHAWK-523:
-------------------------------------

Has anyone found a workaround for this?  Any estimate on when this will be fixed?:

> rowStyleClass does not resolve to an EL of var
> ----------------------------------------------
>
>                 Key: TOMAHAWK-523
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-523
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.4-SNAPSHOT
>         Environment: Tomcat, Facelets
>            Reporter: James McCarthy
>
> The rowStyleClass does not resolve when the rowStyleClass references an EL item identified by var. var="item" rowStyleClass="#{item.status}".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (TOMAHAWK-523) rowStyleClass does not resolve to an EL of var

Posted by "Ronald Müller (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/TOMAHAWK-523?page=comments#action_12425453 ] 
            
Ronald Müller commented on TOMAHAWK-523:
----------------------------------------

you' re mike. but the itention of this bug-report is to discuss and determine that 
1.) it is is definitly a bug (no misconfiguration or something like that)
2.) speeding up  finding this bug (appropriate classes, ...) with some (little) input from one
of the developers 

regards 

ronald

> rowStyleClass does not resolve to an EL of var
> ----------------------------------------------
>
>                 Key: TOMAHAWK-523
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-523
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.4-SNAPSHOT
>         Environment: Tomcat, Facelets
>            Reporter: James McCarthy
>
> The rowStyleClass does not resolve when the rowStyleClass references an EL item identified by var. var="item" rowStyleClass="#{item.status}".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Updated: (TOMAHAWK-523) rowStyleClass does not resolve to an EL of var

Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
     [ http://issues.apache.org/jira/browse/TOMAHAWK-523?page=all ]

Mike Kienenberger updated TOMAHAWK-523:
---------------------------------------

    Status: Open  (was: Patch Available)

> rowStyleClass does not resolve to an EL of var
> ----------------------------------------------
>
>                 Key: TOMAHAWK-523
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-523
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.4-SNAPSHOT
>         Environment: Tomcat, Facelets
>            Reporter: James McCarthy
>
> The rowStyleClass does not resolve when the rowStyleClass references an EL item identified by var. var="item" rowStyleClass="#{item.status}".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (TOMAHAWK-523) rowStyleClass does not resolve to an EL of var

Posted by "Jason Long (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/TOMAHAWK-523?page=comments#action_12422253 ] 
            
Jason Long commented on TOMAHAWK-523:
-------------------------------------

I forgot to mention that the EL is actually evaluated, but the result never makes it back .

> rowStyleClass does not resolve to an EL of var
> ----------------------------------------------
>
>                 Key: TOMAHAWK-523
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-523
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.4-SNAPSHOT
>         Environment: Tomcat, Facelets
>            Reporter: James McCarthy
>
> The rowStyleClass does not resolve when the rowStyleClass references an EL item identified by var. var="item" rowStyleClass="#{item.status}".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (TOMAHAWK-523) rowStyleClass does not resolve to an EL of var

Posted by "Ronald Müller (JIRA)" <de...@myfaces.apache.org>.
     [ http://issues.apache.org/jira/browse/TOMAHAWK-523?page=all ]

Ronald Müller updated TOMAHAWK-523:
-----------------------------------

    Status: Patch Available  (was: Open)

> rowStyleClass does not resolve to an EL of var
> ----------------------------------------------
>
>                 Key: TOMAHAWK-523
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-523
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.4-SNAPSHOT
>         Environment: Tomcat, Facelets
>            Reporter: James McCarthy
>
> The rowStyleClass does not resolve when the rowStyleClass references an EL item identified by var. var="item" rowStyleClass="#{item.status}".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Commented: (TOMAHAWK-523) rowStyleClass does not resolve to an EL of var

Posted by "Jason Long (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/TOMAHAWK-523?page=comments#action_12422250 ] 
            
Jason Long commented on TOMAHAWK-523:
-------------------------------------

                   
EL does not resolve, but property is rendered
rowStyleClass="#{listOfferPrice.rowColor}"  -->  <tr class="">

Not even text outside EL is rendered
rowStyleClass="tr#{listOfferPrice.rowColor}"  -->  <tr class="">

Static text is cause no property to be rendered
rowStyleClass="tr0"  -->  <tr>

I am looking at the code to try to determine what is going on.

If someone would point me in the right direction I might be able to provide a patch.

> rowStyleClass does not resolve to an EL of var
> ----------------------------------------------
>
>                 Key: TOMAHAWK-523
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-523
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.4-SNAPSHOT
>         Environment: Tomcat, Facelets
>            Reporter: James McCarthy
>
> The rowStyleClass does not resolve when the rowStyleClass references an EL item identified by var. var="item" rowStyleClass="#{item.status}".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (TOMAHAWK-523) rowStyleClass does not resolve to an EL of var

Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/TOMAHAWK-523?page=comments#action_12427535 ] 
            
Mike Kienenberger commented on TOMAHAWK-523:
--------------------------------------------

Ronald,

I appreciate the attempt, but there's more to fixing this issue than simply changing those attributes.   You also need to provide concrete (rather than generic) attribute handlers for the new names.   We'll also need to temporarily add backwards-compatibility support for people using the fully-qualified attribute names in older application code.

However, it's a step in the right direction for adding facelets support (and it is covered in another issue where we're working on adding native facelets support for Tomahawk components).

Let's wait for Steve's patches, as it sounds like he's tracked down the problems and knows how to fix them.


> rowStyleClass does not resolve to an EL of var
> ----------------------------------------------
>
>                 Key: TOMAHAWK-523
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-523
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.4-SNAPSHOT
>         Environment: Tomcat, Facelets
>            Reporter: James McCarthy
>
> The rowStyleClass does not resolve when the rowStyleClass references an EL item identified by var. var="item" rowStyleClass="#{item.status}".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (TOMAHAWK-523) rowStyleClass does not resolve to an EL of var

Posted by "darren ting (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/TOMAHAWK-523?page=comments#action_12448374 ] 
            
darren ting commented on TOMAHAWK-523:
--------------------------------------

Not yet solve in snapshot 1.1.5 as up to today

> rowStyleClass does not resolve to an EL of var
> ----------------------------------------------
>
>                 Key: TOMAHAWK-523
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-523
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.4-SNAPSHOT
>         Environment: Tomcat, Facelets
>            Reporter: James McCarthy
>
> The rowStyleClass does not resolve when the rowStyleClass references an EL item identified by var. var="item" rowStyleClass="#{item.status}".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (TOMAHAWK-523) rowStyleClass does not resolve to an EL of var

Posted by "Ronald Müller (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/TOMAHAWK-523?page=comments#action_12423634 ] 
            
Ronald Müller commented on TOMAHAWK-523:
----------------------------------------

hi,

i got the same trouble, but without facelets!
i think its not related to facelets. 

the behavior is much the same as described by Jason.
here are the facts :

-static values ends up in no attribute to <tr>

rowStyleClass="row0" --> <tr>

-dynamic values with EL-expression ends up in an empty attribute to <tr>

rowStyleClass="#{(index%2==0)?'row0':'row1'" --> <tr style="">

-multiple values (seperated by comma) behave like static (nothing)

rowStyleClass="row0, row1" --> <tr>

all the other attributes are working well.

as a workaround downgrade to myfaces-1.1.1 and use EL-expressions:

rowStyleClass="#{(index%2==0)?'row0':'row1'"

for me this works with 1.1.1. the static variants doesn't work as well !

regards

ronald

> rowStyleClass does not resolve to an EL of var
> ----------------------------------------------
>
>                 Key: TOMAHAWK-523
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-523
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.4-SNAPSHOT
>         Environment: Tomcat, Facelets
>            Reporter: James McCarthy
>
> The rowStyleClass does not resolve when the rowStyleClass references an EL item identified by var. var="item" rowStyleClass="#{item.status}".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Updated: (TOMAHAWK-523) rowStyleClass does not resolve to an EL of var

Posted by "Steven L (JIRA)" <de...@myfaces.apache.org>.
     [ http://issues.apache.org/jira/browse/TOMAHAWK-523?page=all ]

Steven L updated TOMAHAWK-523:
------------------------------

    Status: Patch Available  (was: Open)

> rowStyleClass does not resolve to an EL of var
> ----------------------------------------------
>
>                 Key: TOMAHAWK-523
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-523
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.4-SNAPSHOT
>         Environment: Tomcat, Facelets
>            Reporter: James McCarthy
>
> The rowStyleClass does not resolve when the rowStyleClass references an EL item identified by var. var="item" rowStyleClass="#{item.status}".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (TOMAHAWK-523) rowStyleClass does not resolve to an EL of var

Posted by "Jason Long (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/TOMAHAWK-523?page=comments#action_12423833 ] 
            
Jason Long commented on TOMAHAWK-523:
-------------------------------------

Quote from facelets list by Mike Kienenberger.

"Originally, there was a different opinion on how attributes should be
named.   At the time it seemed like using a fully-qualified name as a
generic attribute was preferred since you could leave rendering-only
attributes off of the base component.   As time has passed, that's
turned out to be a less desirable decision as it causes problems with non-JSP viewhandlers like facelets and Clay (and it's not quite as efficient either).

It's turned out to be better to create renderless base classes (like
UISomething) and then subclass it with an HtmlSomething class which adds on the renderer attribute supports."

Is this likely to be fixed any time soon?

As a workaround I set the css color on evey column, but that is a major hassel.

> rowStyleClass does not resolve to an EL of var
> ----------------------------------------------
>
>                 Key: TOMAHAWK-523
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-523
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.4-SNAPSHOT
>         Environment: Tomcat, Facelets
>            Reporter: James McCarthy
>
> The rowStyleClass does not resolve when the rowStyleClass references an EL item identified by var. var="item" rowStyleClass="#{item.status}".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (TOMAHAWK-523) rowStyleClass does not resolve to an EL of var

Posted by "Ronald Müller (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/TOMAHAWK-523?page=comments#action_12427848 ] 
            
Ronald Müller commented on TOMAHAWK-523:
----------------------------------------

hi to all,

for me its pretty diffcult to follow you. Its a pitty but i' ve found no single line of comment on general approachs  of  serveral classes, especially JSFAttr, and why some attributes are not mapped to their real attribute-names.
I'm not working with facelets and have no idea how this is related to facelets, but i know that it doesn't work also without using facelets.
I've got some basic knowledge on components-development, so i thought i could help finding this bug, giving back something to the community, but there is very little input.

I can't agree to Steve. For me it still doesn't work in the trunk.

regards 

ronald

 





> rowStyleClass does not resolve to an EL of var
> ----------------------------------------------
>
>                 Key: TOMAHAWK-523
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-523
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.4-SNAPSHOT
>         Environment: Tomcat, Facelets
>            Reporter: James McCarthy
>
> The rowStyleClass does not resolve when the rowStyleClass references an EL item identified by var. var="item" rowStyleClass="#{item.status}".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Commented: (TOMAHAWK-523) rowStyleClass does not resolve to an EL of var

Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/TOMAHAWK-523?page=comments#action_12425515 ] 
            
Mike Kienenberger commented on TOMAHAWK-523:
--------------------------------------------

> you' re mike. but the itention of this bug-report is to discuss and determine that 
> 1.) it is is definitly a bug (no misconfiguration or something like that)

Yes, I'd say it's a bug.

> 2.) speeding up finding this bug (appropriate classes, ...) with some (little) input from one of the developers 

Set a breakpoint on the code in UIComponent (and also in the JSP tag if you're not using facelets) that sets generic attributes on components.

Set a breakpoint on the code in the html renderer for the dataTable that reads the generic attribute and generates styling html attributes.

Trace through and see where it loses or corrupts the value.


Alternately, write concrete attributes on the Html subclass of dataTable (instance variable, getters and setters for the component and jsp tag) for rowStyleClass and replace the generic attribute references with this instead.

This needs to be done eventually anyway to provide transparent facelets support and to match up with best JSF design practices.


> rowStyleClass does not resolve to an EL of var
> ----------------------------------------------
>
>                 Key: TOMAHAWK-523
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-523
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.4-SNAPSHOT
>         Environment: Tomcat, Facelets
>            Reporter: James McCarthy
>
> The rowStyleClass does not resolve when the rowStyleClass references an EL item identified by var. var="item" rowStyleClass="#{item.status}".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (TOMAHAWK-523) rowStyleClass does not resolve to an EL of var

Posted by "Eivind Rønnevik (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/TOMAHAWK-523?page=comments#action_12423825 ] 
            
Eivind Rønnevik commented on TOMAHAWK-523:
------------------------------------------

I've encountered the same problem, and I also have the need of setting styles dynamically. I'm currently using the 1.1.3 of both myfaces and tomahawk.

Basically, i need to set different background-colors for each row depending on conditions. If condition is false, set color to either white or blue (alternate), if condition is true, set color to yellow.

What I did as a workaround was to use the rowClasses attribute, and instead of using an EL-expression I created a method in my bean that retrieves the value of the dataTable (the objects it contains), runs through them and test for the condition. Based upon the result I build a String of comma-separated values. So this string (which then is bound to rowClasses attribute) contains a reference to a style class for each row.

--------------.jsp---------------

<t:dataTable id="documentsTableView" 
                                value="#{documentModelFactory.documents}" 
	                        var="document"
	    			rowClasses="#{documentModelFactory.rowStyle}" >

------------- bean ---------------------

public String getRowStyle() 
{
		List<Document> contents= new ArrayList<Document>();
		contents =(ArrayList<Document>)htmlDataTable.getValue();
				
		String rowStyles = "";
		int count = 2;
		for (Document document : contents)
		{
			if (condition = true)
			{
			
				rowStyles += "yellow";
			}
			else
			{
				if (count % 2 == 0) //To alternate between to colors
				{
					
					rowStyles += "white";
				}
				else if (count % 2 == 1)
				{
					rowStyles += "blue";
				}
			}
			rowStyles+=",";
			count++;
		}
				
		if(rowStyles != ""	)
			rowStyles = rowStyles.substring(0,(rowStyles.length()-1)); //remove last comma
		
		return rowStyles;
}

This worked for me..

What I wanted to do was something like this:
 rowClasses="#{ test1 < test2 ? 'yellow':'white,blue'}" 

The EL expression is rendered correctly (true when it's supposed to be true), and even if yellow is set as rowClass for some rows, the html source have only <tr class="blue" and "white" tags... And I can't understand why it always uses the "false" result of the EL..

I don't know if you can make use of my suggestion but it's what I had to do to get around the problem. :)

Regards,

Eivind
  
	        
	        
	       

> rowStyleClass does not resolve to an EL of var
> ----------------------------------------------
>
>                 Key: TOMAHAWK-523
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-523
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.4-SNAPSHOT
>         Environment: Tomcat, Facelets
>            Reporter: James McCarthy
>
> The rowStyleClass does not resolve when the rowStyleClass references an EL item identified by var. var="item" rowStyleClass="#{item.status}".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Commented: (TOMAHAWK-523) rowStyleClass does not resolve to an EL of var

Posted by "Steve Rees (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/TOMAHAWK-523?page=comments#action_12427511 ] 
            
Steve Rees commented on TOMAHAWK-523:
-------------------------------------

I believe that there are two problems (at least in the 1.1.3 version of tomahawk) in the renderer for the extended data table. 

1. The renderer, in providing support for newspaper column rendering, does not set the row index before rendering the start of the row, this can cause the rendering of row styles containing EL expressions to fail or to lag the row for which they are being rendered.
2. The renderer does not use the rowStyleClass attribute when rendering the style class of the row, but instead mistakenly uses the rowStyle attribute (probably null in most cases where you are using a rowStyleClass) which is what renders the empty class attribute.

When I have time (probably this weekend) I will submit a patch that I believe fixes both these issues (at least for me)

> rowStyleClass does not resolve to an EL of var
> ----------------------------------------------
>
>                 Key: TOMAHAWK-523
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-523
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.4-SNAPSHOT
>         Environment: Tomcat, Facelets
>            Reporter: James McCarthy
>         Attachments: JSFAttr.class, JSFAttr.patch
>
>
> The rowStyleClass does not resolve when the rowStyleClass references an EL item identified by var. var="item" rowStyleClass="#{item.status}".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (TOMAHAWK-523) rowStyleClass does not resolve to an EL of var

Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TOMAHAWK-523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Kienenberger updated TOMAHAWK-523:
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1.6-SNAPSHOT
           Status: Resolved  (was: Patch Available)

This should now be fixed since Tomahawk-914 is fixed.

> rowStyleClass does not resolve to an EL of var
> ----------------------------------------------
>
>                 Key: TOMAHAWK-523
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-523
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.4-SNAPSHOT
>         Environment: Tomcat, Facelets
>            Reporter: James McCarthy
>             Fix For: 1.1.6-SNAPSHOT
>
>
> The rowStyleClass does not resolve when the rowStyleClass references an EL item identified by var. var="item" rowStyleClass="#{item.status}".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TOMAHAWK-523) rowStyleClass does not resolve to an EL of var

Posted by "Steve Rees (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/TOMAHAWK-523?page=comments#action_12427704 ] 
            
Steve Rees commented on TOMAHAWK-523:
-------------------------------------

It looks like both problems are fixed in the trunk. Is there any mechanism for back porting them to the current stable release, or do we just have to wait for the next release?

> rowStyleClass does not resolve to an EL of var
> ----------------------------------------------
>
>                 Key: TOMAHAWK-523
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-523
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.4-SNAPSHOT
>         Environment: Tomcat, Facelets
>            Reporter: James McCarthy
>
> The rowStyleClass does not resolve when the rowStyleClass references an EL item identified by var. var="item" rowStyleClass="#{item.status}".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (TOMAHAWK-523) rowStyleClass does not resolve to an EL of var

Posted by "Eivind Rønnevik (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/TOMAHAWK-523?page=comments#action_12423827 ] 
            
Eivind Rønnevik commented on TOMAHAWK-523:
------------------------------------------

I forgot to mention:

If I try to use the var attribute of the dataTable in an EL-expression for rowClasses, i get a DEBUG message from org.apache.myfaces saying the var could not be resolved.

<t:dataTable id="myView"
var="test"
rowClasses="#{test.something < myBean.something ? 'row1':'row2'}"  >

 

2006-07-27 14:33:36,912 DEBUG
 [org.apache.myfaces.el.VariableResolverImpl]
  *** Variable 'test' could not be resolved.



> rowStyleClass does not resolve to an EL of var
> ----------------------------------------------
>
>                 Key: TOMAHAWK-523
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-523
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.4-SNAPSHOT
>         Environment: Tomcat, Facelets
>            Reporter: James McCarthy
>
> The rowStyleClass does not resolve when the rowStyleClass references an EL item identified by var. var="item" rowStyleClass="#{item.status}".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Commented: (TOMAHAWK-523) rowStyleClass does not resolve to an EL of var

Posted by "Ronald Müller (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/TOMAHAWK-523?page=comments#action_12427515 ] 
            
Ronald Müller commented on TOMAHAWK-523:
----------------------------------------

no success on older releases :(

its quit complicated to run the sources, especially  the old versions. there is no 'mvn install'-rule in the tags or branches. only the the trunk works from the scratch. so i only took a look into the current trunk (what is currently 1.1.5). 

i also working with the latest stable 1.1.3 and have no success with my provided class-file.

regards

ronald


> rowStyleClass does not resolve to an EL of var
> ----------------------------------------------
>
>                 Key: TOMAHAWK-523
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-523
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.4-SNAPSHOT
>         Environment: Tomcat, Facelets
>            Reporter: James McCarthy
>         Attachments: JSFAttr.class, JSFAttr.patch
>
>
> The rowStyleClass does not resolve when the rowStyleClass references an EL item identified by var. var="item" rowStyleClass="#{item.status}".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Updated: (TOMAHAWK-523) rowStyleClass does not resolve to an EL of var

Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
     [ http://issues.apache.org/jira/browse/TOMAHAWK-523?page=all ]

Mike Kienenberger updated TOMAHAWK-523:
---------------------------------------

    Status: Open  (was: Patch Available)

> rowStyleClass does not resolve to an EL of var
> ----------------------------------------------
>
>                 Key: TOMAHAWK-523
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-523
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.4-SNAPSHOT
>         Environment: Tomcat, Facelets
>            Reporter: James McCarthy
>
> The rowStyleClass does not resolve when the rowStyleClass references an EL item identified by var. var="item" rowStyleClass="#{item.status}".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (TOMAHAWK-523) rowStyleClass does not resolve to an EL of var

Posted by "Ronald Müller (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/TOMAHAWK-523?page=comments#action_12427264 ] 
            
Ronald Müller commented on TOMAHAWK-523:
----------------------------------------

ok guys,

here are some results of my investigation so far :

the interface 'org.apache.myfaces.shared_tomahawk.renderkit.JSFAttr'

defines variables for some common tag-attributes as follows :

 // UIData attributes
    String ROWS_ATTR                   = "rows";
    String VAR_ATTR                    = "var";
    String FIRST_ATTR                  = "first";

    // dataTable (extended) attributes
    String ROW_ID                      = "org.apache.myfaces.dataTable.ROW_ID";
    String ROW_STYLECLASS_ATTR         = "org.apache.myfaces.dataTable.ROW_STYLECLASS";
    String ROW_STYLE_ATTR              = "org.apache.myfaces.dataTable.ROW_STYLE";

for some reason (i see no obvious), the attributes for row-style etc. are not mapped to their real attributes (see 2nd section from above). 
This causes ValueBinding-class getting troubles (maybe as is can't find corresponding attributes in the component-class).
Consequently their exists no value-binding (is null) and so the attribute is not rendered.
If remove using this Interfaces, using fixed values instead ("rowStyleClass") everything works well and as expected !!

More on this topic - tomorrow.

regards 

Ronald


> rowStyleClass does not resolve to an EL of var
> ----------------------------------------------
>
>                 Key: TOMAHAWK-523
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-523
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.4-SNAPSHOT
>         Environment: Tomcat, Facelets
>            Reporter: James McCarthy
>
> The rowStyleClass does not resolve when the rowStyleClass references an EL item identified by var. var="item" rowStyleClass="#{item.status}".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Commented: (TOMAHAWK-523) rowStyleClass does not resolve to an EL of var

Posted by "Ronald Müller (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/TOMAHAWK-523?page=comments#action_12423642 ] 
            
Ronald Müller commented on TOMAHAWK-523:
----------------------------------------

of cause, its the missing 'class' attribute , not 'style' as i mentioned above

> rowStyleClass does not resolve to an EL of var
> ----------------------------------------------
>
>                 Key: TOMAHAWK-523
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-523
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended Datatable
>    Affects Versions: 1.1.4-SNAPSHOT
>         Environment: Tomcat, Facelets
>            Reporter: James McCarthy
>
> The rowStyleClass does not resolve when the rowStyleClass references an EL item identified by var. var="item" rowStyleClass="#{item.status}".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira