[GitHub] [httpcomponents-client] rschmitt commented on issue #181: Add reactive test coverage

[GitBox <gi...@apache.org>]

rschmitt commented on issue #181: Add reactive test coverage
URL: https://github.com/apache/httpcomponents-client/pull/181#issuecomment-564183531
 
 
   I think the `@Ignore` annotation makes the most sense here, especially since these tests should only be disabled in the short-term. (As I mentioned, I've already fixed some of them.) I'm afraid that keeping them on a separate branch will cause bitrot and compilation failures after we rename everything again. I also don't see how assumptions make sense here, since you normally use them to check some sort of precondition about the test *environment* (e.g. the JVM version, availability of credentials for integration tests, the operating system), not about the code being tested and whether it is buggy. (Determining whether the code is buggy is why we have the tests!)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org