[PR] Fix byte comparisons for subsequences with nonzero offsets [accumulo-fluo]

["dajiaohuang (via GitHub)" <gi...@apache.org>]

dajiaohuang opened a new pull request, #1141:
URL: https://github.com/apache/accumulo-fluo/pull/1141

   `Bytes.compareToUnchecked()` stops its comparison loop at `minLen`, even though its index starts at the backing-array offset. For nonzero-offset subsequences this compares too few bytes, potentially treating different values as equal and producing inconsistent ordering.
   
   Include the offset in the loop end bound so all overlapping bytes are compared. Add regression coverage for ordering in both directions, equality, and byte-array comparisons with and without an offset.
   
   Validation:
   - Original `BytesTest`: 22 tests, one regression failure. Fixed: all 22 pass.
   - Attempted `mvn verify` as requested by CONTRIBUTING.md. With task-local Java 21, API (89 tests), Accumulo (47 tests), and Core (20 tests) passed. The build stopped in Command: seven errors caused by `InvalidPathException` on resource paths beginning `/D:/...` on Windows. Mini/integration tests were not reached.
   - An earlier Java 26 attempt stopped at SpotBugs because it does not support class-file major version 70.
   - Formatting and `git diff --check` pass.
   
   AI-assisted with OpenAI Codex (GPT-6.1-sol).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org