You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by vinayakumarb <gi...@git.apache.org> on 2018/01/31 06:18:50 UTC
[GitHub] carbondata pull request #1892: [CARBONDATA-2106] Update product document wit...
GitHub user vinayakumarb opened a pull request:
https://github.com/apache/carbondata/pull/1892
[CARBONDATA-2106] Update product document with page level reader property
Updated the document.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vinayakumarb/carbondata bugs/CARBONDATA-2106
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1892.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1892
----
commit 53beaa67b07811db89aed6bb02268f8242a57e1a
Author: Vinayakumar B <vi...@...>
Date: 2018-01-31T06:12:22Z
[CARBONDATA-2106] Documentation for Page level reader property
----
---
[GitHub] carbondata pull request #1892: [CARBONDATA-2106] Update product document wit...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1892#discussion_r164961498
--- Diff: docs/configuration-parameters.md ---
@@ -119,6 +119,7 @@ This section provides the details of all the configurations required for CarbonD
| carbon.numberof.preserve.segments | 0 | If the user wants to preserve some number of segments from being compacted then he can set this property. Example: carbon.numberof.preserve.segments = 2 then 2 latest segments will always be excluded from the compaction. No segments will be preserved by default. |
| carbon.allowed.compaction.days | 0 | Compaction will merge the segments which are loaded with in the specific number of days configured. Example: If the configuration is 2, then the segments which are loaded in the time frame of 2 days only will get merged. Segments which are loaded 2 days apart will not be merged. This is disabled by default. |
| carbon.enable.auto.load.merge | false | To enable compaction while data loading. |
+|carbon.enable.page.level.reader.in.compaction|true|Enabling page level reader for compaction reduces the memory usage while compacting more number of segments. It allows reading only page by page instead of reaing whole blocklet to memory.|
--- End diff --
typo `reading` not `reaing`
---
[GitHub] carbondata issue #1892: [CARBONDATA-2106] Update product document with page ...
Posted by sgururajshetty <gi...@git.apache.org>.
Github user sgururajshetty commented on the issue:
https://github.com/apache/carbondata/pull/1892
LGTM
---
[GitHub] carbondata issue #1892: [CARBONDATA-2106] Update product document with page ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1892
Can one of the admins verify this patch?
---
[GitHub] carbondata pull request #1892: [CARBONDATA-2106] Update product document wit...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1892
---
[GitHub] carbondata pull request #1892: [CARBONDATA-2106] Update product document wit...
Posted by vinayakumarb <gi...@git.apache.org>.
Github user vinayakumarb commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1892#discussion_r164963276
--- Diff: docs/configuration-parameters.md ---
@@ -119,6 +119,7 @@ This section provides the details of all the configurations required for CarbonD
| carbon.numberof.preserve.segments | 0 | If the user wants to preserve some number of segments from being compacted then he can set this property. Example: carbon.numberof.preserve.segments = 2 then 2 latest segments will always be excluded from the compaction. No segments will be preserved by default. |
| carbon.allowed.compaction.days | 0 | Compaction will merge the segments which are loaded with in the specific number of days configured. Example: If the configuration is 2, then the segments which are loaded in the time frame of 2 days only will get merged. Segments which are loaded 2 days apart will not be merged. This is disabled by default. |
| carbon.enable.auto.load.merge | false | To enable compaction while data loading. |
+|carbon.enable.page.level.reader.in.compaction|true|Enabling page level reader for compaction reduces the memory usage while compacting more number of segments. It allows reading only page by page instead of reaing whole blocklet to memory.|
--- End diff --
Fixed
---
[GitHub] carbondata issue #1892: [CARBONDATA-2106] Update product document with page ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1892
LGTM
---