You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by achristianson <gi...@git.apache.org> on 2018/04/18 16:27:40 UTC
[GitHub] nifi-minifi-cpp pull request #301: MINIFICPP-459 Include FLexLexer.h in thir...
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/301
MINIFICPP-459 Include FLexLexer.h in thirdparty so that generated sou…
…rces for EL can be built without having to install flex
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-459
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/301.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #301
----
commit a89e979d19109f621bd9ca57e6331e5babe6f58e
Author: Andrew I. Christianson <an...@...>
Date: 2018-03-22T19:49:50Z
MINIFICPP-459 Include FLexLexer.h in thirdparty so that generated sources for EL can be built without having to install flex
----
---
[GitHub] nifi-minifi-cpp issue #301: MINIFICPP-459 Include FLexLexer.h in thirdparty ...
Posted by minifirocks <gi...@git.apache.org>.
Github user minifirocks commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/301
looks good
---
[GitHub] nifi-minifi-cpp pull request #301: MINIFICPP-459 Include FLexLexer.h in thir...
Posted by achristianson <gi...@git.apache.org>.
Github user achristianson closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/301
---
[GitHub] nifi-minifi-cpp issue #301: MINIFICPP-459 Include FLexLexer.h in thirdparty ...
Posted by achristianson <gi...@git.apache.org>.
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/301
Going to close this PR as invalid. FlexLexer.h appears to be incompatible between common versions. Flex/bison are build requirements when EL code is generated. This ticket made it possible to build when system headers were not in the include path (e.g. Android builds); this remains a requirement, but a different solution needs to be applied.
---
[GitHub] nifi-minifi-cpp issue #301: MINIFICPP-459 Include FLexLexer.h in thirdparty ...
Posted by achristianson <gi...@git.apache.org>.
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/301
Looks like Mac OS build has an issue. Will look into it.
---