[GitHub] [commons-crypto] ecki commented on a change in pull request #128: Minor Performances Improvement:

[GitBox <gi...@apache.org>]

ecki commented on a change in pull request #128:
URL: https://github.com/apache/commons-crypto/pull/128#discussion_r553372929



##########
File path: src/main/java/org/apache/commons/crypto/NativeCodeLoader.java
##########
@@ -171,7 +171,7 @@ private static File extractLibraryFile(final String libFolderForCurrentOS, final
             // Check whether the contents are properly copied from the resource
             // folder
             try (InputStream nativeInputStream = NativeCodeLoader.class.getResourceAsStream(nativeLibraryFilePath)) {
-                try (InputStream extractedLibIn = new FileInputStream(extractedLibFile)) {
+                try (InputStream extractedLibIn = Files.newInputStream(Paths.get(extractedLibFile.getPath()))) {

Review comment:
       Do you habe tested this for speed? I saw (and I don’t know why) performance regressions with the stream of Files.newInputStream compared to FileInputStream. Maybe that should be a separate change to introduce Path/NIO?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org