You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2022/07/25 06:47:47 UTC

[GitHub] [avro] martin-g commented on a diff in pull request #1778: AVRO-3585: Add support for encoding Value::String as Schema::Uuid

martin-g commented on code in PR #1778:
URL: https://github.com/apache/avro/pull/1778#discussion_r928521943


##########
lang/rust/avro/src/encode.rs:
##########
@@ -134,6 +134,9 @@ pub(crate) fn encode_internal<S: Borrow<Schema>>(
                     return Err(Error::GetEnumSymbol(s.clone()));
                 }
             }
+            Schema::Uuid => {

Review Comment:
   Agreed!
   @RikHeijdens Please update the PR with @jklamer's suggestion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org