You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jun Rao <ju...@gmail.com> on 2014/11/06 18:34:39 UTC
Review Request 27690: Patch for kafka-1738
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27690/
-----------------------------------------------------------
Review request for kafka.
Bugs: kafka-1738
https://issues.apache.org/jira/browse/kafka-1738
Repository: kafka
Description
-------
try/catch should include channel.receive()
Diffs
-----
core/src/main/scala/kafka/controller/ControllerChannelManager.scala ecbfa0f328ba6a652a758ab20cacef324a8b2fb8
Diff: https://reviews.apache.org/r/27690/diff/
Testing
-------
Thanks,
Jun Rao
Re: Review Request 27690: Patch for kafka-1738
Posted by Neha Narkhede <ne...@gmail.com>.
> On Nov. 6, 2014, 7:20 p.m., Neha Narkhede wrote:
> > Ship It!
Minor nit: Could you change fails to failed?
- Neha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27690/#review60215
-----------------------------------------------------------
On Nov. 6, 2014, 5:34 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27690/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 5:34 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: kafka-1738
> https://issues.apache.org/jira/browse/kafka-1738
>
>
> Repository: kafka
>
>
> Description
> -------
>
> try/catch should include channel.receive()
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/controller/ControllerChannelManager.scala ecbfa0f328ba6a652a758ab20cacef324a8b2fb8
>
> Diff: https://reviews.apache.org/r/27690/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 27690: Patch for kafka-1738
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27690/#review60215
-----------------------------------------------------------
Ship it!
Ship It!
- Neha Narkhede
On Nov. 6, 2014, 5:34 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27690/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 5:34 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: kafka-1738
> https://issues.apache.org/jira/browse/kafka-1738
>
>
> Repository: kafka
>
>
> Description
> -------
>
> try/catch should include channel.receive()
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/controller/ControllerChannelManager.scala ecbfa0f328ba6a652a758ab20cacef324a8b2fb8
>
> Diff: https://reviews.apache.org/r/27690/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>