[GitHub] [incubator-pinot] chenboat edited a comment on issue #5027: Do not derive host/port from instance id in HelixServerStarter

[GitBox <gi...@apache.org>]

chenboat edited a comment on issue #5027: Do not derive host/port from instance id in HelixServerStarter
URL: https://github.com/apache/incubator-pinot/pull/5027#issuecomment-580388696
 
 
   @Jackie-Jiang I do agree currently the Server id/hostname configs are too convoluted than necessary. Some comments inline about this proposal
   
   > Currently host/port can be derived from instance id, and instance id
   > can also be derived from host/port, which makes ServerConf hard to
   > config.
   > 
   > Instead, with the change:
   > 
   > * Host is always from config or generated by NetUtil
   > * Port is always from config or using default (8098)
   > * Instance id is always from config or of format 'Server__'
   
   I am not sure i understand this. In particular, what will happen if Instance Id is not in config? Will it be derived from the hostname and port?
   
   > * Host will no longer have the 'Server_' prefix in InstanceConfig
   > 
   > BACKWARD-INCOMPATIBLE CHANGE:
   > 
   > * Host/port will no longer be derived from the instance id configuration
   > * Host will no longer have the 'Server_' prefix in InstanceConfig
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org