You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/01/27 19:55:53 UTC

[GitHub] [hudi] pratyakshsharma commented on a change in pull request #1650: [HUDI-541]: replaced dataFile/df with baseFile/bf throughout code base

pratyakshsharma commented on a change in pull request #1650:
URL: https://github.com/apache/hudi/pull/1650#discussion_r565592884



##########
File path: hudi-common/src/main/avro/HoodieCompactionOperation.avsc
##########
@@ -41,7 +41,7 @@
                      "default": null
                   },
                   {
-                     "name":"dataFilePath",
+                     "name":"baseFilePath",

Review comment:
       @bvaradar We are basically adding a new adding a new field in TestHoodieCommitMetadata class and then testing compatibility. However in this PR, I am not sure of how an avro record with field "baseFilePath" will be converted to a POJO with field dataFilePath while deserializing. I have removed the alias for now. If you can guide me here, that would be useful. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org