You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/01/10 07:13:36 UTC
[GitHub] [rocketmq-client-cpp] codecov-io commented on issue #223:
fix(protocol): delete string print in header decode and open test cases.
codecov-io commented on issue #223: fix(protocol): delete string print in header decode and open test cases.
URL: https://github.com/apache/rocketmq-client-cpp/pull/223#issuecomment-572904617
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223?src=pr&el=h1) Report
> Merging [#223](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-cpp/commit/b5b3b35f0a047799c4be1e11b8956cf00959f984?src=pr&el=desc) will **increase** coverage by `1.82%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #223 +/- ##
==========================================
+ Coverage 47.82% 49.64% +1.82%
==========================================
Files 173 173
Lines 10441 10607 +166
==========================================
+ Hits 4993 5266 +273
+ Misses 5448 5341 -107
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [test/src/producer/StringIdMakerTest.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223/diff?src=pr&el=tree#diff-dGVzdC9zcmMvcHJvZHVjZXIvU3RyaW5nSWRNYWtlclRlc3QuY3Bw) | `100% <ø> (ø)` | |
| [src/protocol/CommandHeader.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL0NvbW1hbmRIZWFkZXIuY3Bw) | `73.04% <100%> (+26.14%)` | :arrow_up: |
| [test/src/protocol/CommandHeaderTest.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223/diff?src=pr&el=tree#diff-dGVzdC9zcmMvcHJvdG9jb2wvQ29tbWFuZEhlYWRlclRlc3QuY3Bw) | `100% <100%> (ø)` | :arrow_up: |
| [src/protocol/CommandHeader.h](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL0NvbW1hbmRIZWFkZXIuaA==) | `66.15% <0%> (+16.94%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223?src=pr&el=footer). Last update [b5b3b35...5a6c640](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services