You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/07/31 12:40:42 UTC
Review Request 13107: CLOUDSTACK-2717: Adding optional parameter accuntid to
listCapabilities API
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13107/
-----------------------------------------------------------
Review request for cloudstack and Nitin Mehta.
Bugs: CLOUDSTACK-2717
Repository: cloudstack-git
Description
-------
CLOUDSTACK-2717: Adding optional parameter accuntid to listCapabilities API
This is to fix allow.public.user.templates configuration parameter to get the value at account level.
Diffs
-----
api/src/org/apache/cloudstack/api/command/user/config/ListCapabilitiesCmd.java a30e26c
api/src/org/apache/cloudstack/api/response/CapabilitiesResponse.java c2996f0
server/src/com/cloud/server/ManagementServerImpl.java 26efa10
Diff: https://reviews.apache.org/r/13107/diff/
Testing
-------
Tested locally by firing listcapabilities API call for Admin/user
Thanks,
Harikrishna Patnala
Re: Review Request 13107: CLOUDSTACK-2717: Adding optional parameter
accuntid to listCapabilities API
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13107/#review24343
-----------------------------------------------------------
Commit 3d9fc3dbc0e5c19635392593caa61776da02b2b6 in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3d9fc3d ]
CLOUDSTACK-2717: listCapabilities API to return
allow.public.user.templates configuration parameter value
defined at account level.
Signed by - Nitin Mehta<ni...@citrix.com>
- ASF Subversion and Git Services
On July 31, 2013, 11:19 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13107/
> -----------------------------------------------------------
>
> (Updated July 31, 2013, 11:19 a.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-2717
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2717: Adding optional parameter accuntid to listCapabilities API
>
> This is to fix allow.public.user.templates configuration parameter to get the value at account level.
>
>
> Diffs
> -----
>
> server/src/com/cloud/server/ManagementServerImpl.java 26efa10
>
> Diff: https://reviews.apache.org/r/13107/diff/
>
>
> Testing
> -------
>
> Tested locally by firing listcapabilities API call for Admin/user
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 13107: CLOUDSTACK-2717: Adding optional parameter
accuntid to listCapabilities API
Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13107/#review24344
-----------------------------------------------------------
Review 13107 PASSED the build test
The url of build cloudstack-master-with-patch #92 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/92/
- Jenkins Cloudstack.org
On July 31, 2013, 11:19 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13107/
> -----------------------------------------------------------
>
> (Updated July 31, 2013, 11:19 a.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-2717
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2717: Adding optional parameter accuntid to listCapabilities API
>
> This is to fix allow.public.user.templates configuration parameter to get the value at account level.
>
>
> Diffs
> -----
>
> server/src/com/cloud/server/ManagementServerImpl.java 26efa10
>
> Diff: https://reviews.apache.org/r/13107/diff/
>
>
> Testing
> -------
>
> Tested locally by firing listcapabilities API call for Admin/user
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 13107: CLOUDSTACK-2717: Adding optional parameter
accuntid to listCapabilities API
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13107/#review24342
-----------------------------------------------------------
Commit 798c507c7d9a0241fbaaddb3348eaa3313b4f9a3 in branch refs/heads/4.2 from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=798c507 ]
CLOUDSTACK-2717: listCapabilities API to return
allow.public.user.templates configuration parameter value
defined at account level.
Signed by - Nitin Mehta<ni...@citrix.com>
- ASF Subversion and Git Services
On July 31, 2013, 11:19 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13107/
> -----------------------------------------------------------
>
> (Updated July 31, 2013, 11:19 a.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-2717
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2717: Adding optional parameter accuntid to listCapabilities API
>
> This is to fix allow.public.user.templates configuration parameter to get the value at account level.
>
>
> Diffs
> -----
>
> server/src/com/cloud/server/ManagementServerImpl.java 26efa10
>
> Diff: https://reviews.apache.org/r/13107/diff/
>
>
> Testing
> -------
>
> Tested locally by firing listcapabilities API call for Admin/user
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 13107: CLOUDSTACK-2717: Adding optional parameter
accuntid to listCapabilities API
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13107/#review24341
-----------------------------------------------------------
Ship it!
Ship It!
- Nitin Mehta
On July 31, 2013, 11:19 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13107/
> -----------------------------------------------------------
>
> (Updated July 31, 2013, 11:19 a.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-2717
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2717: Adding optional parameter accuntid to listCapabilities API
>
> This is to fix allow.public.user.templates configuration parameter to get the value at account level.
>
>
> Diffs
> -----
>
> server/src/com/cloud/server/ManagementServerImpl.java 26efa10
>
> Diff: https://reviews.apache.org/r/13107/diff/
>
>
> Testing
> -------
>
> Tested locally by firing listcapabilities API call for Admin/user
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 13107: CLOUDSTACK-2717: Adding optional parameter
accuntid to listCapabilities API
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13107/
-----------------------------------------------------------
(Updated July 31, 2013, 11:19 a.m.)
Review request for cloudstack and Nitin Mehta.
Changes
-------
updated patch
Bugs: CLOUDSTACK-2717
Repository: cloudstack-git
Description
-------
CLOUDSTACK-2717: Adding optional parameter accuntid to listCapabilities API
This is to fix allow.public.user.templates configuration parameter to get the value at account level.
Diffs (updated)
-----
server/src/com/cloud/server/ManagementServerImpl.java 26efa10
Diff: https://reviews.apache.org/r/13107/diff/
Testing
-------
Tested locally by firing listcapabilities API call for Admin/user
Thanks,
Harikrishna Patnala
Re: Review Request 13107: CLOUDSTACK-2717: Adding optional parameter
accuntid to listCapabilities API
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13107/#review24340
-----------------------------------------------------------
api/src/org/apache/cloudstack/api/command/user/config/ListCapabilitiesCmd.java
<https://reviews.apache.org/r/13107/#comment48195>
no need for account id, user context should have that. We dont follow this convention.
- Nitin Mehta
On July 31, 2013, 10:40 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13107/
> -----------------------------------------------------------
>
> (Updated July 31, 2013, 10:40 a.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-2717
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2717: Adding optional parameter accuntid to listCapabilities API
>
> This is to fix allow.public.user.templates configuration parameter to get the value at account level.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/config/ListCapabilitiesCmd.java a30e26c
> api/src/org/apache/cloudstack/api/response/CapabilitiesResponse.java c2996f0
> server/src/com/cloud/server/ManagementServerImpl.java 26efa10
>
> Diff: https://reviews.apache.org/r/13107/diff/
>
>
> Testing
> -------
>
> Tested locally by firing listcapabilities API call for Admin/user
>
>
> Thanks,
>
> Harikrishna Patnala
>
>