Re: svn commit: rev 3186 - trunk/subversion/bindings/swig

[Greg Stein <gs...@lyra.org>]

On Wed, Sep 18, 2002 at 11:49:14AM -0500, cmpilato@tigris.org wrote:
> Author: cmpilato
> Date: 2002-09-18 11:49:07 -0500 (Wed, 18 Sep 2002)
> New Revision: 3186
> 
> Modified:
>    trunk/subversion/bindings/swig/swigutil_py.c
>    trunk/subversion/bindings/swig/swigutil_py.h
> Log:
> * subversion/bindings/swig/swigutil_py.h
>   Oops.  #include "svn_repos.h", too.
> 
> * subversion/bindings/swig/swigutil_py.c
>   (svn_swig_py_strings_to_array): Dup the string into the array's
>     pool.  Also, set the array's 'nelts' member to the right things,
>     since our APR_ARRAY_IDX macro won't do that.

Why the dup? Presumably, these Python strings are an *input* parameter. As
such, they are guaranteed to stick around for the life of the function
invocation. Thus, there shouldn't be a need to copy them...

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org