You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/02/28 12:20:04 UTC
[GitHub] [incubator-pekko-grpc] mdedetrich opened a new pull request, #36: Use Pekko Paradox sbt plugin
mdedetrich opened a new pull request, #36:
URL: https://github.com/apache/incubator-pekko-grpc/pull/36
tbd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] jrudolph commented on pull request #36: Use Pekko Paradox sbt plugin
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #36:
URL: https://github.com/apache/incubator-pekko-grpc/pull/36#issuecomment-1448281487
Hmm, that's unfortunate, not sure if forking makes sense because there's is so much work to be done to update it to all the latest versions... Maybe we can try making a low-effort attempt to get a new version rolling. Or, we try to work around the issue with circe which might be possible without forking (all code). Or, we abandon the theme for now and go back to the generic template until we have time later to figure out a better solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich merged pull request #36: Use Pekko Paradox sbt plugin
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #36:
URL: https://github.com/apache/incubator-pekko-grpc/pull/36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] jrudolph commented on pull request #36: Use Pekko Paradox sbt plugin
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #36:
URL: https://github.com/apache/incubator-pekko-grpc/pull/36#issuecomment-1449822544
> From my side the bigger priority is to have the pekko projects generate docs that don't look like from the 80's.
Yes, true but let's not strive for perfection for the first release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on pull request #36: Use Pekko Paradox sbt plugin
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #36:
URL: https://github.com/apache/incubator-pekko-grpc/pull/36#issuecomment-1448318789
From my side the bigger priority is to have the pekko projects generate docs that don't look like from the 80's. I mean at some point we may not even be using the material theme, but at least until release I don't see us needing to change to much to the material theme (if anything).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on pull request #36: Use Pekko Paradox sbt plugin
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #36:
URL: https://github.com/apache/incubator-pekko-grpc/pull/36#issuecomment-1448137032
So I found the conflict, its conflicting with sbt-authors which happens to use circe `0.9.x` which is ancient. I have created an upstream PR at https://github.com/jonas/paradox-material-theme/pull/35 but it seems it hasn't been updated in ages.
Pinging @jrudolph so you are aware.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on pull request #36: Use Pekko Paradox sbt plugin
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #36:
URL: https://github.com/apache/incubator-pekko-grpc/pull/36#issuecomment-1448284927
> Hmm, that's unfortunate, not sure if forking makes sense because there's is so much work to be done to update it to all the latest versions... Maybe we can try making a low-effort attempt to get a new version rolling. Or, we try to work around the issue with circe which might be possible without forking (all code). Or, we abandon the theme for now and go back to the generic template until we have time later to figure out a better solution.
There already is a PR to update the the project to the latest versions (see https://github.com/jonas/paradox-material-theme/pull/34 and https://github.com/apache/incubator-pekko-sbt-paradox/issues/34), so I don't think forking is too much effort. I can look into it later on in the week if no one else picks it up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] jrudolph commented on pull request #36: Use Pekko Paradox sbt plugin
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #36:
URL: https://github.com/apache/incubator-pekko-grpc/pull/36#issuecomment-1448314295
It's not about the immediate work but about what it will mean later on when we need changes. An ad-hoc single use fork should be the last resort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on pull request #36: Use Pekko Paradox sbt plugin
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #36:
URL: https://github.com/apache/incubator-pekko-grpc/pull/36#issuecomment-1448114987
So there seems to be an issue with circe, specifically sbt plugins bringing in different versions of circe. `sbt-paradox-material-theme` brings in version 0.9.0, need to track down what other sbt plugin is bringing in a different version of circe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on pull request #36: Use Pekko Paradox sbt plugin
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #36:
URL: https://github.com/apache/incubator-pekko-grpc/pull/36#issuecomment-1449860514
What I meant is that without sbt-paradox the docs don't even render correctly, so by priority I meant using pekko-sbt-paradox at all so we have something thats usable.
Its not an issue now anyways, problem has been solved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org