[jira] [Commented] (TAP5-2230) AjaxFormLoop Add Row Broken

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-2230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13882417#comment-13882417 ] 

ASF subversion and git services commented on TAP5-2230:
-------------------------------------------------------

Commit 875927fd2c651604dfaae30f52b986e7b503adee in branch refs/heads/master from [~thiagohp]
[ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=875927f ]

Fixes TAP5-2230: AjaxFormLoop Add Row Broken

> AjaxFormLoop Add Row Broken
> ---------------------------
>
>                 Key: TAP5-2230
>                 URL: https://issues.apache.org/jira/browse/TAP5-2230
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.4
>            Reporter: Peter H
>            Assignee: Thiago H. de Paula Figueiredo
>
> We're using 5.4.26 but have seen this in 5.4.25 too so assume it's a fairly long-standing issue in the alphas.
> Use ajaxformloop, click add row, check your browser's console, see client-side error as follows:
> Uncaught TypeError: Object <DIV class="trowandloadsmoremarkupbesidesthatistheentirecontentsofyourajaxformloop</DIV> has no method 'trigger' 
> Look at ajaxformloop.js, see lines 42-44.
> newElement = "<" + insertionPoint.element.tagName + " class=\"" + insertionPoint.element.className + "\"\n  data-container-type=\"" + FRAGMENT_TYPE + "\">\n  " + content + "\n  </" + insertionPoint.element.tagName + ">";
>           insertionPoint.insertBefore(newElement);
>           return newElement.trigger(events.zone.didUpdate);
> Change them to the following:
> {code}
> newElement = "<" + insertionPoint.element.tagName + " class=\"" + insertionPoint.element.className + "\"\n  data-container-type=\"" + FRAGMENT_TYPE + "\">\n  " + content + "\n  </" + insertionPoint.element.tagName + ">";
> newElement = insertionPoint.insertBefore(newElement);
>           return newElement.trigger(events.zone.didUpdate);
> {code}
> Note the missing assignment of the newElement after its insertion. We are calling trigger on a string. And all is fixed. :D



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)