[GitHub] [storm] kishorvpatil commented on a change in pull request #3297: STORM-3662: Use Pacemaker if cluster has set up uses it

[GitBox <gi...@apache.org>]

kishorvpatil commented on a change in pull request #3297:
URL: https://github.com/apache/storm/pull/3297#discussion_r447163184



##########
File path: storm-client/src/jvm/org/apache/storm/cluster/IStormClusterState.java
##########
@@ -74,6 +74,13 @@
      */
     boolean isAssignmentsBackendSynchronized();
 
+    /**
+     * Flag to indicate if the Pacameker is backup store.

Review comment:
       Addressed

##########
File path: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
##########
@@ -361,7 +364,11 @@ public void doHeartBeat() throws IOException {
         state.setWorkerHeartBeat(lsWorkerHeartbeat);
         state.cleanup(60); // this is just in case supervisor is down so that disk doesn't fill up.
         // it shouldn't take supervisor 120 seconds between listing dir and reading it
-        heartbeatToMasterIfLocalbeatFail(lsWorkerHeartbeat);
+
+        if (!workerState.stormClusterState.isPacemakerStateStore()) {
+            LOG.debug("If pacemaker is not used, send supervisor");

Review comment:
       Addressed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org