You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "beliefer (via GitHub)" <gi...@apache.org> on 2023/06/17 09:26:44 UTC

[GitHub] [spark] beliefer opened a new pull request, #41640: [SPARK-43928][SQL][PYTHON][CONNECT][FOLLOWUP] Update excludedSqlFunctions of DataFrameFunctionsSuite

beliefer opened a new pull request, #41640:
URL: https://github.com/apache/spark/pull/41640

   ### What changes were proposed in this pull request?
   https://github.com/apache/spark/pull/41608 add bit operations to Scala, Python and Connect API, but missing the test for `DataFrameFunctionsSuite`.
   
   
   ### Why are the changes needed?
   Fix missing tests
   
   
   ### Does this PR introduce _any_ user-facing change?
   'No'.
   New feature.
   
   
   ### How was this patch tested?
   N/A
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #41640: [SPARK-43928][SQL][PYTHON][CONNECT][FOLLOWUP] Update excludedSqlFunctions of DataFrameFunctionsSuite

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #41640:
URL: https://github.com/apache/spark/pull/41640#issuecomment-1595690760

   ping @zhengruifeng cc @LuciferYang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #41640: [SPARK-43928][SQL][PYTHON][CONNECT][FOLLOWUP] Update excludedSqlFunctions of DataFrameFunctionsSuite

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #41640:
URL: https://github.com/apache/spark/pull/41640#issuecomment-1595690932

   OK, let me close https://github.com/apache/spark/pull/41639


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng commented on pull request #41640: [SPARK-43928][SQL][PYTHON][CONNECT][FOLLOWUP] Update `excludedSqlFunctions` of `DataFrameFunctionsSuite`

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #41640:
URL: https://github.com/apache/spark/pull/41640#issuecomment-1595734473

   I manually check this fix in my local env
   
   merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng closed pull request #41640: [SPARK-43928][SQL][PYTHON][CONNECT][FOLLOWUP] Update `excludedSqlFunctions` of `DataFrameFunctionsSuite`

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #41640: [SPARK-43928][SQL][PYTHON][CONNECT][FOLLOWUP] Update `excludedSqlFunctions` of `DataFrameFunctionsSuite`
URL: https://github.com/apache/spark/pull/41640


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng commented on pull request #41640: [SPARK-43928][SQL][PYTHON][CONNECT][FOLLOWUP] Update `excludedSqlFunctions` of `DataFrameFunctionsSuite`

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #41640:
URL: https://github.com/apache/spark/pull/41640#issuecomment-1595734636

   maybe we should move `DataFrameFunctionsSuite ` outside of `sql - other` to avoid similar mistake, I will give a try


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #41640: [SPARK-43928][SQL][PYTHON][CONNECT][FOLLOWUP] Update `excludedSqlFunctions` of `DataFrameFunctionsSuite`

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #41640:
URL: https://github.com/apache/spark/pull/41640#issuecomment-1595945657

   Thank you, @beliefer and all!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] panbingkun commented on pull request #41640: [SPARK-43928][SQL][PYTHON][CONNECT][FOLLOWUP] Update `excludedSqlFunctions` of `DataFrameFunctionsSuite`

Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #41640:
URL: https://github.com/apache/spark/pull/41640#issuecomment-1595723352

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #41640: [SPARK-43928][SQL][PYTHON][CONNECT][FOLLOWUP] Update `excludedSqlFunctions` of `DataFrameFunctionsSuite`

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #41640:
URL: https://github.com/apache/spark/pull/41640#issuecomment-1595922804

   > maybe we should move `DataFrameFunctionsSuite ` outside of `sql - other` to avoid similar mistake, I will give a try
   
   Yeah. The `sql - other` test always failed and let us confused.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #41640: [SPARK-43928][SQL][PYTHON][CONNECT][FOLLOWUP] Update excludedSqlFunctions of DataFrameFunctionsSuite

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #41640:
URL: https://github.com/apache/spark/pull/41640#issuecomment-1595691001

   @LuciferYang Because the issue is my fault. Let me fix it. Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org