[ https://issues.apache.org/jira/browse/FLINK-9406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16484720#comment-16484720 ]
ASF GitHub Bot commented on FLINK-9406:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6057
[FLINK-9406] Use equals in JobMaster#requestPartitionState
## What is the purpose of the change
Use equals instead of referential equality in JobMaster#requestPartitionState
when comparing the producerExecution attempt id with the result partition
producer id.
## Verifying this change
- Added `JobMasterTest#testRequestPartitionState`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixPartitionLookup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6057.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6057
----
commit 92c3f286188857b662b1edd3a80fb471d4478975
Author: Till Rohrmann <tr...@...>
Date: 2018-05-22T13:53:38Z
[FLINK-9408] Let JM try to reconnect to RM
This commit changes the behaviour of the JM to always try to reconnect to the latest known RM address.
commit ac3233099ca7f9783adf2150fb35d703a8a86ea7
Author: Till Rohrmann <tr...@...>
Date: 2018-05-22T22:47:45Z
[FLINK-9406] Use equals in JobMaster#requestPartitionState
Use equals instead of referential equality in JobMaster#requestPartitionState
when comparing the producerExecution attempt id with the result partition
producer id.
----
> Request finished partition state fails due to referential equality comparison
> -----------------------------------------------------------------------------
>
> Key: FLINK-9406
> URL: https://issues.apache.org/jira/browse/FLINK-9406
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination
> Affects Versions: 1.5.0, 1.6.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Blocker
> Fix For: 1.5.0
>
>
> The execution of batch jobs can fail because in some cases we cannot retrieve the partition state. The problem seems to be that we use referential equality in {{JobMaster.java:619}} when requesting the state of a finished result partition. This, of course, always fails with a {{PartitionProducerDisposedException}} because we should use the proper {{equals}} method for the comparison of the {{ResultPartitionID}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)