[GitHub] [incubator-paimon] lincoln-lil commented on a diff in pull request #940: [WIP] Support Async lookup for Paimon-flink

["lincoln-lil (via GitHub)" <gi...@apache.org>]

lincoln-lil commented on code in PR #940:
URL: https://github.com/apache/incubator-paimon/pull/940#discussion_r1226022921


##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/FlinkConnectorOptions.java:
##########
@@ -181,6 +181,12 @@ public class FlinkConnectorOptions {
                             "How many splits should assign to subtask per batch in StaticFileStoreSplitEnumerator "
                                     + "to avoid exceed `akka.framesize` limit.");
 
+    public static final ConfigOption<Boolean> LOOKUP_ASYNC =

Review Comment:
   @Myasuka @JingsongLi  sorry for the late response. For flink planner, it does prefer the async lookup and will check what kind of lookup function does the backend source can provide 
   ```
   // prefer (not require) by default
   boolean preferAsync = preferAsync(lookupHint);
   // check lookup function provider ...
   return preferAsync ? asyncFound : !syncFound;
   ```
   so, if the connector can have both sync and async lookup capabilities, it‘s better to implement both providers
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org