You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "JingsongLi (via GitHub)" <gi...@apache.org> on 2023/04/12 02:28:00 UTC
[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #865: [core][bug] BoundedChecker may check non-existing snapshot at fully read phase
JingsongLi commented on code in PR #865:
URL: https://github.com/apache/incubator-paimon/pull/865#discussion_r1163505545
##########
paimon-core/src/main/java/org/apache/paimon/table/source/snapshot/StartingScanner.java:
##########
@@ -22,38 +22,74 @@
import org.apache.paimon.table.source.TableScan;
import org.apache.paimon.utils.SnapshotManager;
-import javax.annotation.Nullable;
-
import java.util.Collections;
import java.util.List;
/** Helper class for the first planning of {@link TableScan}. */
public interface StartingScanner {
- @Nullable
Result scan(SnapshotManager snapshotManager, SnapshotSplitReader snapshotSplitReader);
/** Scan result of {@link #scan}. */
- class Result {
+ interface Result {
+ long snapshotId();
+
+ List<DataSplit> splits();
+ }
+
+ /** A null Result. */
+ class NullResult implements Result {
Review Comment:
`NoSnapshot`, and add comment: Currently, there is no snapshot, need to wait for the snapshot to be generated.
##########
paimon-core/src/main/java/org/apache/paimon/table/source/snapshot/StartingScanner.java:
##########
@@ -22,38 +22,74 @@
import org.apache.paimon.table.source.TableScan;
import org.apache.paimon.utils.SnapshotManager;
-import javax.annotation.Nullable;
-
import java.util.Collections;
import java.util.List;
/** Helper class for the first planning of {@link TableScan}. */
public interface StartingScanner {
- @Nullable
Result scan(SnapshotManager snapshotManager, SnapshotSplitReader snapshotSplitReader);
/** Scan result of {@link #scan}. */
- class Result {
+ interface Result {
+ long snapshotId();
+
+ List<DataSplit> splits();
+ }
+
+ /** A null Result. */
+ class NullResult implements Result {
+ @Override
+ public long snapshotId() {
+ throw new UnsupportedOperationException();
+ }
+
+ @Override
+ public List<DataSplit> splits() {
+ throw new UnsupportedOperationException();
+ }
+ }
+ /** A non null Result. */
+ abstract class NonNullResult implements Result {
Review Comment:
No need to have this class.
##########
paimon-core/src/main/java/org/apache/paimon/table/source/snapshot/StartingScanner.java:
##########
@@ -22,38 +22,74 @@
import org.apache.paimon.table.source.TableScan;
import org.apache.paimon.utils.SnapshotManager;
-import javax.annotation.Nullable;
-
import java.util.Collections;
import java.util.List;
/** Helper class for the first planning of {@link TableScan}. */
public interface StartingScanner {
- @Nullable
Result scan(SnapshotManager snapshotManager, SnapshotSplitReader snapshotSplitReader);
/** Scan result of {@link #scan}. */
- class Result {
+ interface Result {
+ long snapshotId();
+
+ List<DataSplit> splits();
+ }
+
+ /** A null Result. */
+ class NullResult implements Result {
+ @Override
+ public long snapshotId() {
+ throw new UnsupportedOperationException();
+ }
+
+ @Override
+ public List<DataSplit> splits() {
+ throw new UnsupportedOperationException();
+ }
+ }
+ /** A non null Result. */
+ abstract class NonNullResult implements Result {
private final long snapshotId;
private final List<DataSplit> splits;
- public Result(long snapshotId) {
+ public NonNullResult(long snapshotId) {
this(snapshotId, Collections.emptyList());
}
- public Result(long snapshotId, List<DataSplit> splits) {
+ public NonNullResult(long snapshotId, List<DataSplit> splits) {
this.snapshotId = snapshotId;
this.splits = splits;
}
+ @Override
public long snapshotId() {
return snapshotId;
}
+ @Override
public List<DataSplit> splits() {
return splits;
}
}
+
+ /** Contains an existing snapshot. */
+ class ExistingSnapshotResult extends NonNullResult {
Review Comment:
`ScannedResult`: Result with scanned snapshot. Next snapshot should be current snapshot plus 1.
##########
paimon-core/src/main/java/org/apache/paimon/table/source/snapshot/StartingScanner.java:
##########
@@ -22,38 +22,74 @@
import org.apache.paimon.table.source.TableScan;
import org.apache.paimon.utils.SnapshotManager;
-import javax.annotation.Nullable;
-
import java.util.Collections;
import java.util.List;
/** Helper class for the first planning of {@link TableScan}. */
public interface StartingScanner {
- @Nullable
Result scan(SnapshotManager snapshotManager, SnapshotSplitReader snapshotSplitReader);
/** Scan result of {@link #scan}. */
- class Result {
+ interface Result {
+ long snapshotId();
+
+ List<DataSplit> splits();
+ }
+
+ /** A null Result. */
+ class NullResult implements Result {
+ @Override
+ public long snapshotId() {
+ throw new UnsupportedOperationException();
+ }
+
+ @Override
+ public List<DataSplit> splits() {
+ throw new UnsupportedOperationException();
+ }
+ }
+ /** A non null Result. */
+ abstract class NonNullResult implements Result {
private final long snapshotId;
private final List<DataSplit> splits;
- public Result(long snapshotId) {
+ public NonNullResult(long snapshotId) {
this(snapshotId, Collections.emptyList());
}
- public Result(long snapshotId, List<DataSplit> splits) {
+ public NonNullResult(long snapshotId, List<DataSplit> splits) {
this.snapshotId = snapshotId;
this.splits = splits;
}
+ @Override
public long snapshotId() {
return snapshotId;
}
+ @Override
public List<DataSplit> splits() {
return splits;
}
}
+
+ /** Contains an existing snapshot. */
+ class ExistingSnapshotResult extends NonNullResult {
Review Comment:
```
private final long currentSnapshotId;
private final List<DataSplit> splits;
```
##########
paimon-core/src/main/java/org/apache/paimon/table/source/snapshot/StartingScanner.java:
##########
@@ -22,38 +22,74 @@
import org.apache.paimon.table.source.TableScan;
import org.apache.paimon.utils.SnapshotManager;
-import javax.annotation.Nullable;
-
import java.util.Collections;
import java.util.List;
/** Helper class for the first planning of {@link TableScan}. */
public interface StartingScanner {
- @Nullable
Result scan(SnapshotManager snapshotManager, SnapshotSplitReader snapshotSplitReader);
/** Scan result of {@link #scan}. */
- class Result {
+ interface Result {
+ long snapshotId();
+
+ List<DataSplit> splits();
+ }
+
+ /** A null Result. */
+ class NullResult implements Result {
+ @Override
+ public long snapshotId() {
+ throw new UnsupportedOperationException();
+ }
+
+ @Override
+ public List<DataSplit> splits() {
+ throw new UnsupportedOperationException();
+ }
+ }
+ /** A non null Result. */
+ abstract class NonNullResult implements Result {
private final long snapshotId;
private final List<DataSplit> splits;
- public Result(long snapshotId) {
+ public NonNullResult(long snapshotId) {
this(snapshotId, Collections.emptyList());
}
- public Result(long snapshotId, List<DataSplit> splits) {
+ public NonNullResult(long snapshotId, List<DataSplit> splits) {
this.snapshotId = snapshotId;
this.splits = splits;
}
+ @Override
public long snapshotId() {
return snapshotId;
}
+ @Override
public List<DataSplit> splits() {
return splits;
}
}
+
+ /** Contains an existing snapshot. */
+ class ExistingSnapshotResult extends NonNullResult {
+ public ExistingSnapshotResult(long snapshotId) {
+ super(snapshotId);
+ }
+
+ public ExistingSnapshotResult(long snapshotId, List<DataSplit> splits) {
+ super(snapshotId, splits);
+ }
+ }
+
+ /** Contains a non-existing snapshot. */
+ class NonExistingSnapshotResult extends NonNullResult {
Review Comment:
`NextSnapshot`: add some comments.
```
private final long nextSnapshotId;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org