You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by wu...@apache.org on 2018/06/14 12:20:07 UTC

[incubator-servicecomb-java-chassis] branch master updated (8d77264 -> 84a482c)

This is an automated email from the ASF dual-hosted git repository.

wujimin pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-servicecomb-java-chassis.git.


    from 8d77264  [SCB-669] add extra hashcode into CtTypeJavaType to avoid deserialization problem
     new 48edd8e  [SCB-661]logs give more information and remove unnecessary log for each invocation
     new 84a482c  [SCB-661]add schema logs to check compatible problem

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../servicecomb/core/definition/schema/ConsumerSchemaFactory.java   | 1 +
 .../java/org/apache/servicecomb/bizkeeper/BizkeeperCommand.java     | 6 ++++--
 .../java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java | 6 ++++--
 .../authentication/provider/RSAProviderTokenManager.java            | 1 -
 4 files changed, 9 insertions(+), 5 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
wujimin@apache.org.

[incubator-servicecomb-java-chassis] 02/02: [SCB-661]add schema logs to check compatible problem

Posted by wu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

wujimin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-servicecomb-java-chassis.git

commit 84a482c8b05c728e870135a307f913ee41b52800
Author: liubao <ba...@huawei.com>
AuthorDate: Wed Jun 13 17:21:04 2018 +0800

    [SCB-661]add schema logs to check compatible problem
---
 .../apache/servicecomb/core/definition/schema/ConsumerSchemaFactory.java | 1 +
 1 file changed, 1 insertion(+)

diff --git a/core/src/main/java/org/apache/servicecomb/core/definition/schema/ConsumerSchemaFactory.java b/core/src/main/java/org/apache/servicecomb/core/definition/schema/ConsumerSchemaFactory.java
index 2dd7755..a3dbbdb 100644
--- a/core/src/main/java/org/apache/servicecomb/core/definition/schema/ConsumerSchemaFactory.java
+++ b/core/src/main/java/org/apache/servicecomb/core/definition/schema/ConsumerSchemaFactory.java
@@ -72,6 +72,7 @@ public class ConsumerSchemaFactory extends AbstractSchemaFactory<ConsumerSchemaC
         context.getMicroservice().getVersion(),
         context.getSchemaId(),
         !StringUtils.isEmpty(schemaContent));
+    LOGGER.debug(schemaContent);
     if (schemaContent != null) {
       return SchemaUtils.parseSwagger(schemaContent);
     }

-- 
To stop receiving notification emails like this one, please contact
wujimin@apache.org.

[incubator-servicecomb-java-chassis] 01/02: [SCB-661]logs give more information and remove unnecessary log for each invocation

Posted by wu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

wujimin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-servicecomb-java-chassis.git

commit 48edd8e89d2f6c0e47e1c056db164dd066cd7c04
Author: liubao <ba...@huawei.com>
AuthorDate: Tue Jun 12 20:31:17 2018 +0800

    [SCB-661]logs give more information and remove unnecessary log for each invocation
---
 .../java/org/apache/servicecomb/bizkeeper/BizkeeperCommand.java     | 6 ++++--
 .../java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java | 6 ++++--
 .../authentication/provider/RSAProviderTokenManager.java            | 1 -
 3 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/BizkeeperCommand.java b/handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/BizkeeperCommand.java
index aad3893..a582041 100644
--- a/handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/BizkeeperCommand.java
+++ b/handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/BizkeeperCommand.java
@@ -79,7 +79,8 @@ public abstract class BizkeeperCommand extends HystrixObservableCommand<Response
         invocation.next(resp -> {
           if (isFailedResponse(resp)) {
             // e should implements toString
-            LOG.warn("bizkeeper command failed due to:" + resp.getResult());
+            LOG.warn("bizkeeper command {} failed due to {}", invocation.getInvocationQualifiedName(),
+                resp.getResult());
             f.onError(resp.getResult());
             FallbackPolicyManager.record(type, invocation, resp, false);
           } else {
@@ -89,7 +90,8 @@ public abstract class BizkeeperCommand extends HystrixObservableCommand<Response
           }
         });
       } catch (Exception e) {
-        LOG.warn("bizkeeper command execute failed due to:" + e.getClass().getName());
+        LOG.warn("bizkeeper command {} execute failed due to {}", invocation.getInvocationQualifiedName(),
+            e.getClass().getName());
         f.onError(e);
       }
     });
diff --git a/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java b/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java
index 723abef..06ffb9b 100644
--- a/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java
+++ b/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java
@@ -223,7 +223,8 @@ public class LoadbalanceHandler implements Handler {
       @Override
       public void onExceptionWithServer(ExecutionContext<Invocation> context, Throwable exception,
           ExecutionInfo info) {
-        LOGGER.error("onExceptionWithServer msg {}; server {}",
+        LOGGER.error("onExceptionWithServer operation {}; msg {}; server {}",
+            context.getRequest().getInvocationQualifiedName(),
             exception.getMessage(),
             context.getRequest().getEndpoint());
       }
@@ -274,7 +275,8 @@ public class LoadbalanceHandler implements Handler {
             invocation.setEndpoint(((CseServer) s).getEndpoint());
             invocation.next(resp -> {
               if (isFailedResponse(resp)) {
-                LOGGER.error("service call error, msg is {}, server is {} ",
+                LOGGER.error("service {}, call error, msg is {}, server is {} ",
+                    invocation.getInvocationQualifiedName(),
                     ((Throwable) resp.getResult()).getMessage(),
                     s);
                 chosenLB.getLoadBalancerStats().incrementSuccessiveConnectionFailureCount(s);
diff --git a/handlers/handler-publickey-auth/src/main/java/org/apache/servicecomb/authentication/provider/RSAProviderTokenManager.java b/handlers/handler-publickey-auth/src/main/java/org/apache/servicecomb/authentication/provider/RSAProviderTokenManager.java
index aaffa3f..9c379a9 100644
--- a/handlers/handler-publickey-auth/src/main/java/org/apache/servicecomb/authentication/provider/RSAProviderTokenManager.java
+++ b/handlers/handler-publickey-auth/src/main/java/org/apache/servicecomb/authentication/provider/RSAProviderTokenManager.java
@@ -49,7 +49,6 @@ public class RSAProviderTokenManager {
         return false;
       }
       if (validatedToken.contains(rsaToken)) {
-        LOGGER.info("found vaildate token in vaildate pool");
         return true;
       }
 

-- 
To stop receiving notification emails like this one, please contact
wujimin@apache.org.