You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Yang Yang (JIRA)" <ji...@apache.org> on 2011/09/09 02:48:08 UTC
[jira] [Created] (CASSANDRA-3165) ArrayBackedSortedColumns is not
being used by ColumnFamily.cloneMeShallow()
ArrayBackedSortedColumns is not being used by ColumnFamily.cloneMeShallow()
---------------------------------------------------------------------------
Key: CASSANDRA-3165
URL: https://issues.apache.org/jira/browse/CASSANDRA-3165
Project: Cassandra
Issue Type: New Feature
Reporter: Yang Yang
Priority: Minor
JIRA 2843 utilizes ArrayBackedSortedColumns for read path.
but this is missed in ColumnFamily.cloneMeShallow(), which still calls ColumnFamily.create() without the factory, so it defaults to the slower SkipList-based one.
an easy change is to remember the factory, and use it when cloneMeShallow()
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-3165) ArrayBackedSortedColumns is not
being used by ColumnFamily.cloneMeShallow()
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne resolved CASSANDRA-3165.
-----------------------------------------
Resolution: Fixed
Fix Version/s: (was: 1.1)
1.0
Reviewer: jbellis
Assignee: Sylvain Lebresne
Alright, that make sense, committed to 1.0
> ArrayBackedSortedColumns is not being used by ColumnFamily.cloneMeShallow()
> ---------------------------------------------------------------------------
>
> Key: CASSANDRA-3165
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3165
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Affects Versions: 1.0
> Reporter: Yang Yang
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 1.0
>
> Attachments: 0001-ColumnFamily.cloneMeShallow-should-remember-the-fact.patch, 3165_v2.patch
>
>
> JIRA 2843 utilizes ArrayBackedSortedColumns for read path.
> but this is missed in ColumnFamily.cloneMeShallow(), which still calls ColumnFamily.create() without the factory, so it defaults to the slower SkipList-based one.
> an easy change is to remember the factory, and use it when cloneMeShallow()
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3165) ArrayBackedSortedColumns is not
being used by ColumnFamily.cloneMeShallow()
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-3165:
----------------------------------------
Attachment: 3165_v2.patch
We don't have to remember the factory, the columns can give it back to us. Adding v2 that does that.
But actually v2 adds a cloneMeShallow variant that allows to specify the factory, which allow to change the backing map in the clone. The patch uses it in CFS.filterColumnFamily, which should provide some speedup in the cached case.
> ArrayBackedSortedColumns is not being used by ColumnFamily.cloneMeShallow()
> ---------------------------------------------------------------------------
>
> Key: CASSANDRA-3165
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3165
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Affects Versions: 1.0
> Reporter: Yang Yang
> Priority: Minor
> Fix For: 1.1
>
> Attachments: 0001-ColumnFamily.cloneMeShallow-should-remember-the-fact.patch, 3165_v2.patch
>
>
> JIRA 2843 utilizes ArrayBackedSortedColumns for read path.
> but this is missed in ColumnFamily.cloneMeShallow(), which still calls ColumnFamily.create() without the factory, so it defaults to the slower SkipList-based one.
> an easy change is to remember the factory, and use it when cloneMeShallow()
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3165) ArrayBackedSortedColumns is not
being used by ColumnFamily.cloneMeShallow()
Posted by "Yang Yang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yang Yang updated CASSANDRA-3165:
---------------------------------
Attachment: 0001-ColumnFamily.cloneMeShallow-should-remember-the-fact.patch
remember factory
> ArrayBackedSortedColumns is not being used by ColumnFamily.cloneMeShallow()
> ---------------------------------------------------------------------------
>
> Key: CASSANDRA-3165
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3165
> Project: Cassandra
> Issue Type: New Feature
> Reporter: Yang Yang
> Priority: Minor
> Attachments: 0001-ColumnFamily.cloneMeShallow-should-remember-the-fact.patch
>
>
> JIRA 2843 utilizes ArrayBackedSortedColumns for read path.
> but this is missed in ColumnFamily.cloneMeShallow(), which still calls ColumnFamily.create() without the factory, so it defaults to the slower SkipList-based one.
> an easy change is to remember the factory, and use it when cloneMeShallow()
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3165) ArrayBackedSortedColumns is not
being used by ColumnFamily.cloneMeShallow()
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101210#comment-13101210 ]
Jonathan Ellis commented on CASSANDRA-3165:
-------------------------------------------
+1
Also think this should be in 1.0 since it corrects an omission in CASSANDRA-2843.
> ArrayBackedSortedColumns is not being used by ColumnFamily.cloneMeShallow()
> ---------------------------------------------------------------------------
>
> Key: CASSANDRA-3165
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3165
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Affects Versions: 1.0
> Reporter: Yang Yang
> Priority: Minor
> Fix For: 1.1
>
> Attachments: 0001-ColumnFamily.cloneMeShallow-should-remember-the-fact.patch, 3165_v2.patch
>
>
> JIRA 2843 utilizes ArrayBackedSortedColumns for read path.
> but this is missed in ColumnFamily.cloneMeShallow(), which still calls ColumnFamily.create() without the factory, so it defaults to the slower SkipList-based one.
> an easy change is to remember the factory, and use it when cloneMeShallow()
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3165) ArrayBackedSortedColumns is not
being used by ColumnFamily.cloneMeShallow()
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-3165:
----------------------------------------
Component/s: Core
Affects Version/s: 1.0
Fix Version/s: 1.1
> ArrayBackedSortedColumns is not being used by ColumnFamily.cloneMeShallow()
> ---------------------------------------------------------------------------
>
> Key: CASSANDRA-3165
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3165
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Affects Versions: 1.0
> Reporter: Yang Yang
> Priority: Minor
> Fix For: 1.1
>
> Attachments: 0001-ColumnFamily.cloneMeShallow-should-remember-the-fact.patch, 3165_v2.patch
>
>
> JIRA 2843 utilizes ArrayBackedSortedColumns for read path.
> but this is missed in ColumnFamily.cloneMeShallow(), which still calls ColumnFamily.create() without the factory, so it defaults to the slower SkipList-based one.
> an easy change is to remember the factory, and use it when cloneMeShallow()
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira