You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/25 04:15:00 UTC
[GitHub] [spark] gengliangwang opened a new pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
gengliangwang opened a new pull request #30493:
URL: https://github.com/apache/spark/pull/30493
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Remove SQL configuration spark.sql.legacy.allowCastNumericToTimestamp
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
In the current master branch, there is a new configuration `spark.sql.legacy.allowCastNumericToTimestamp` which controls whether to cast Numeric types to Timestamp or not. The default value is true.
After https://github.com/apache/spark/pull/30260, the type conversion between Timestamp type and Numeric type is disallowed in ANSI mode. So, we don't need to a separate configuration `spark.sql.legacy.allowCastNumericToTimestamp` for disallowing the conversion. Users just need to set `spark.sql.ansi.enabled` for the behavior.
As the configuration is not in any released yet, we should remove the configuration to make things simpler.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No, since the configuration is not released yet.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Existing test cases
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #30493:
URL: https://github.com/apache/spark/pull/30493#discussion_r530140422
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
##########
@@ -1311,20 +1311,6 @@ class CastSuite extends CastSuiteBase {
}
}
- test("SPARK-31710: fail casting from numeric to timestamp if it is forbidden") {
Review comment:
There is a similar test case in https://github.com/apache/spark/blob/master/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala#L844 already
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
##########
@@ -1311,20 +1311,6 @@ class CastSuite extends CastSuiteBase {
}
}
- test("SPARK-31710: fail casting from numeric to timestamp if it is forbidden") {
Review comment:
There is a similar test case in https://github.com/apache/spark/blob/master/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala#L844 already
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733488636
**[Test build #131742 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131742/testReport)** for PR 30493 at commit [`6d3e7e2`](https://github.com/apache/spark/commit/6d3e7e2b8bfb8c6d2a21fefc7133b766421fb050).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733467240
> According to the report of SPARK-31710, it was a correctness issue.
I just tried the following in Spark 3.0.0
```
create table test(id bigint);
insert into test select 1586318188000;
create table test1(id bigint) partitioned by (year string);
set hive.exec.dynamic.partition.mode=nonstrict;
insert overwrite table test1 partition(year) select 234,cast(id as TIMESTAMP) from test;
```
and there is no exception as reported in https://issues.apache.org/jira/browse/SPARK-31710.
Casting from Long type to Timestamp type can be ambiguous. Spark converts the Long value as "how many seconds from Unix epoch" by default. And it is considered as "wrong result" in https://issues.apache.org/jira/browse/SPARK-31710 .
> Are you using ANSI mode in production really?
It is possible when it is ready.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733467434
**[Test build #131732 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131732/testReport)** for PR 30493 at commit [`f98a5da`](https://github.com/apache/spark/commit/f98a5da47f2651d81719fee4ad04d6b55cebc547).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733454803
**[Test build #131731 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131731/testReport)** for PR 30493 at commit [`fcc1f12`](https://github.com/apache/spark/commit/fcc1f1278c192a8e6ec34731c29115bc6cbb53de).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733575869
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733473447
`HiveCompatibilitySuite.scala` seems to still have it.
```
/home/jenkins/workspace/SparkPullRequestBuilder@2/sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala:44:19: value legacyAllowCastNumericToTimestamp is not a member of org.apache.spark.sql.internal.SQLConf
[error] TestHive.conf.legacyAllowCastNumericToTimestamp
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733637340
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733454811
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #30493:
URL: https://github.com/apache/spark/pull/30493#discussion_r530136005
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
##########
@@ -1311,20 +1311,6 @@ class CastSuite extends CastSuiteBase {
}
}
- test("SPARK-31710: fail casting from numeric to timestamp if it is forbidden") {
Review comment:
> Users just need to set spark.sql.ansi.enabled for the behavior.
Just in case, should we leave the test, and check the cases under ^^ the config?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang edited a comment on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
gengliangwang edited a comment on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733456524
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733456524
@dongjoon-hyun I can understand your concern. But if we are going to have this configuration, then it is reasonable to add a feature flag for each disallowed conversion in ANSI mode (https://github.com/apache/spark/pull/30260).
Overall I think it is better to remove this configuration before 3.1.0 before it's too late.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733454811
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733575869
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang edited a comment on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
gengliangwang edited a comment on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733467240
> According to the report of SPARK-31710, it was a correctness issue.
I just tried the following in Spark 3.0.0
```
create table test(id bigint);
insert into test select 1586318188000;
create table test1(id bigint) partitioned by (year string);
set hive.exec.dynamic.partition.mode=nonstrict;
insert overwrite table test1 partition(year) select 234,cast(id as TIMESTAMP) from test;
```
and there is no exception as reported in https://issues.apache.org/jira/browse/SPARK-31710. (The affects version is 2.4.5)
Casting from Long type to Timestamp type can be ambiguous. Spark converts the Long value as "how many seconds from Unix epoch" by default. And it is considered as "wrong result" in https://issues.apache.org/jira/browse/SPARK-31710 .
> Are you using ANSI mode in production really?
It is possible when it is ready.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang edited a comment on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
gengliangwang edited a comment on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733467240
> According to the report of SPARK-31710, it was a correctness issue.
I just tried the following in Spark 3.0.0
```
create table test(id bigint);
insert into test select 1586318188000;
create table test1(id bigint) partitioned by (year string);
set hive.exec.dynamic.partition.mode=nonstrict;
insert overwrite table test1 partition(year) select 234,cast(id as TIMESTAMP) from test;
```
and there is no exception as reported in https://issues.apache.org/jira/browse/SPARK-31710. (The affects version is 2.4.5)
Casting from Long type to Timestamp type can be ambiguous. Spark converts the Long value as "how many seconds from Unix epoch" by default. And it is considered as "wrong result" in https://issues.apache.org/jira/browse/SPARK-31710 .
(That's why we should disallow it in ANSI mode.)
> Are you using ANSI mode in production really?
It is possible when it is ready.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733453828
**[Test build #131731 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131731/testReport)** for PR 30493 at commit [`fcc1f12`](https://github.com/apache/spark/commit/fcc1f1278c192a8e6ec34731c29115bc6cbb53de).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733470869
**[Test build #131732 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131732/testReport)** for PR 30493 at commit [`f98a5da`](https://github.com/apache/spark/commit/f98a5da47f2651d81719fee4ad04d6b55cebc547).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733639918
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733488636
**[Test build #131742 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131742/testReport)** for PR 30493 at commit [`6d3e7e2`](https://github.com/apache/spark/commit/6d3e7e2b8bfb8c6d2a21fefc7133b766421fb050).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang edited a comment on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
gengliangwang edited a comment on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733456524
@dongjoon-hyun I can understand your concern. But if we are going to have this configuration, then it is reasonable to add a feature flag for each disallowed conversion in ANSI mode (https://github.com/apache/spark/pull/30260).
Overall I think it is better to remove this configuration in 3.1.0 before it's too late.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733565341
GA passed, merging to master, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733470894
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733568871
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733568871
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733639918
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733469741
Got it, @gengliangwang .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733457527
According to the report of SPARK-31710, it was a correctness issue. This should be considered seriously. Are you using ANSI mode in production really?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733470894
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733467434
**[Test build #131732 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131732/testReport)** for PR 30493 at commit [`f98a5da`](https://github.com/apache/spark/commit/f98a5da47f2651d81719fee4ad04d6b55cebc547).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733453828
**[Test build #131731 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131731/testReport)** for PR 30493 at commit [`fcc1f12`](https://github.com/apache/spark/commit/fcc1f1278c192a8e6ec34731c29115bc6cbb53de).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #30493:
URL: https://github.com/apache/spark/pull/30493
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733631430
**[Test build #131742 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131742/testReport)** for PR 30493 at commit [`6d3e7e2`](https://github.com/apache/spark/commit/6d3e7e2b8bfb8c6d2a21fefc7133b766421fb050).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang edited a comment on pull request #30493: [SPARK-33549][SQL] Remove configuration spark.sql.legacy.allowCastNumericToTimestamp
Posted by GitBox <gi...@apache.org>.
gengliangwang edited a comment on pull request #30493:
URL: https://github.com/apache/spark/pull/30493#issuecomment-733467240
> According to the report of SPARK-31710, it was a correctness issue.
I just tried the following in Spark 3.0.0
```
create table test(id bigint);
insert into test select 1586318188000;
create table test1(id bigint) partitioned by (year string);
set hive.exec.dynamic.partition.mode=nonstrict;
insert overwrite table test1 partition(year) select 234,cast(id as TIMESTAMP) from test;
```
and there is no exception as reported in https://issues.apache.org/jira/browse/SPARK-31710.
Casting from Long type to Timestamp type can be ambiguous. Spark converts the Long value as "how many seconds from Unix epoch" by default. And it is considered as "wrong result" in https://issues.apache.org/jira/browse/SPARK-31710 .
> Are you using ANSI mode in production really?
It is possible when it is ready.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org